From patchwork Thu Mar 23 07:42:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: ye.xingchen@zte.com.cn X-Patchwork-Id: 13185196 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7B233C6FD1C for ; Thu, 23 Mar 2023 07:42:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:Cc:To:From:Mime-Version: Message-ID:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=1RfPq6BfU84YpOwd5PgAB54KILB+UuEFuYo2k+q1OyY=; b=dy0 ENgxB2ykXvAReXz/hsePHFt2xGKSDGFBHqg9LoSebY/jkoRNdntJK/Kgp0GD+6C5PXspKSYC4JAFR 2fJdNpK7qsnUjLsUiq8aXRFXDMiP2ptTYhQQUbcu5+RGc9W0kXZ8aeVub7m8c5HNAlLCAjh2CV5bH omtI8Jhpn8+yxtNfWUbAbcJvj6PZgeMbzHvCNN31S1gbjxkTC7bmtv94yiKP02e4wtFA4uEAzos0a Typ8qEXbql+PGTuIB3VsALdEgiqNkBkyUQ/gJQYat52i4E9kdQIYHCTg/aJZokAej0SR9gT8gCqLl EgL672twgu9cdsrJ2EolyBu2RUBW1jw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pfFai-0018BZ-2c; Thu, 23 Mar 2023 07:42:32 +0000 Received: from mxhk.zte.com.cn ([63.216.63.35]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pfFae-0018AO-13; Thu, 23 Mar 2023 07:42:30 +0000 Received: from mse-fl2.zte.com.cn (unknown [10.5.228.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mxhk.zte.com.cn (FangMail) with ESMTPS id 4Phy3f635rz6FK2Q; Thu, 23 Mar 2023 15:42:22 +0800 (CST) Received: from xaxapp01.zte.com.cn ([10.88.99.176]) by mse-fl2.zte.com.cn with SMTP id 32N7gAsq080139; Thu, 23 Mar 2023 15:42:10 +0800 (+08) (envelope-from ye.xingchen@zte.com.cn) Received: from mapi (xaxapp02[null]) by mapi (Zmail) with MAPI id mid31; Thu, 23 Mar 2023 15:42:12 +0800 (CST) Date: Thu, 23 Mar 2023 15:42:12 +0800 (CST) X-Zmail-TransId: 2afa641c02d44f0-7a6ec X-Mailer: Zmail v1.0 Message-ID: <202303231542125412125@zte.com.cn> Mime-Version: 1.0 From: To: Cc: , , , , , , , Subject: =?utf-8?q?=5BPATCH=5D_phy=3A_allwinner=3A_Use_dev=5Ferr=5Fprobe=28?= =?utf-8?q?=29?= X-MAIL: mse-fl2.zte.com.cn 32N7gAsq080139 X-Fangmail-Gw-Spam-Type: 0 X-Fangmail-Anti-Spam-Filtered: true X-Fangmail-MID-QID: 641C02DE.002/4Phy3f635rz6FK2Q X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230323_004228_509061_7CF2698B X-CRM114-Status: GOOD ( 10.06 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org From: Ye Xingchen Replace the open-code with dev_err_probe() to simplify the code. Signed-off-by: Ye Xingchen Acked-by: Jernej Skrabec --- drivers/phy/allwinner/phy-sun50i-usb3.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/phy/allwinner/phy-sun50i-usb3.c b/drivers/phy/allwinner/phy-sun50i-usb3.c index 84055b720016..c43087b85070 100644 --- a/drivers/phy/allwinner/phy-sun50i-usb3.c +++ b/drivers/phy/allwinner/phy-sun50i-usb3.c @@ -140,11 +140,8 @@ static int sun50i_usb3_phy_probe(struct platform_device *pdev) return -ENOMEM; phy->clk = devm_clk_get(dev, NULL); - if (IS_ERR(phy->clk)) { - if (PTR_ERR(phy->clk) != -EPROBE_DEFER) - dev_err(dev, "failed to get phy clock\n"); - return PTR_ERR(phy->clk); - } + if (IS_ERR(phy->clk)) + return dev_err_probe(dev, PTR_ERR(phy->clk), "failed to get phy clock\n"); phy->reset = devm_reset_control_get(dev, NULL); if (IS_ERR(phy->reset)) {