| Message ID | 20230516154329.3155031-4-Frank.Li@nxp.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | phy: cadence: salvo: some fixes and workarounds | expand |
On 16-05-23, 11:43, Frank Li wrote: > From: Peter Chen <peter.chen@nxp.com> > > Very limited parts may fail to work on full speed mode (both host and > device modes) for USB3 port due to higher threshold in full speed receiver > of USB2.0 PHY. > > One example failure symptom is, the enumeration is failed when connecting > full speed USB mouse to USB3 port, especially under high temperature. > > The workaround is to configure threshold voltage value of single ended > receiver by setting USB2.0 PHY register AFE_RX_REG5[2:0] to 3'b101. > > Signed-off-by: Peter Chen <peter.chen@nxp.com> This needs senders S-o-b as well! > --- > drivers/phy/cadence/phy-cadence-salvo.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/phy/cadence/phy-cadence-salvo.c b/drivers/phy/cadence/phy-cadence-salvo.c > index 2e3d4d8fb8eb..b9866dc146ce 100644 > --- a/drivers/phy/cadence/phy-cadence-salvo.c > +++ b/drivers/phy/cadence/phy-cadence-salvo.c > @@ -91,6 +91,7 @@ > > /* USB2 PHY register definition */ > #define UTMI_REG15 0xaf > +#define UTMI_AFE_RX_REG5 0x12 > > /* TB_ADDR_TX_RCVDETSC_CTRL */ > #define RXDET_IN_P3_32KHZ BIT(0) > @@ -247,6 +248,8 @@ static int cdns_salvo_phy_init(struct phy *phy) > cdns_salvo_write(salvo_phy, USB2_PHY_OFFSET, UTMI_REG15, > value | TXVALID_GATE_THRESHOLD_HS_0US); > > + cdns_salvo_write(salvo_phy, USB2_PHY_OFFSET, UTMI_AFE_RX_REG5, > + 0x5); single line reads better > udelay(10); > > clk_disable_unprepare(salvo_phy->clk); > -- > 2.34.1
diff --git a/drivers/phy/cadence/phy-cadence-salvo.c b/drivers/phy/cadence/phy-cadence-salvo.c index 2e3d4d8fb8eb..b9866dc146ce 100644 --- a/drivers/phy/cadence/phy-cadence-salvo.c +++ b/drivers/phy/cadence/phy-cadence-salvo.c @@ -91,6 +91,7 @@ /* USB2 PHY register definition */ #define UTMI_REG15 0xaf +#define UTMI_AFE_RX_REG5 0x12 /* TB_ADDR_TX_RCVDETSC_CTRL */ #define RXDET_IN_P3_32KHZ BIT(0) @@ -247,6 +248,8 @@ static int cdns_salvo_phy_init(struct phy *phy) cdns_salvo_write(salvo_phy, USB2_PHY_OFFSET, UTMI_REG15, value | TXVALID_GATE_THRESHOLD_HS_0US); + cdns_salvo_write(salvo_phy, USB2_PHY_OFFSET, UTMI_AFE_RX_REG5, + 0x5); udelay(10); clk_disable_unprepare(salvo_phy->clk);