From patchwork Wed Jun 21 15:33:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 13287516 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 76AB2EB64D8 for ; Wed, 21 Jun 2023 15:33:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1eglyur/qHhbTnh5YnEHrMBZsrLPqVpILwAModqSWY0=; b=KF5yvhlVwVeV7D lsCZjENna2Il8lbUJlyPHQq+QODjzy0sDgdnjGvkz/GaaljOdAOgeRWq7PfhqRmMdetSdJCzh/3XI DzDcXYlMWMKvExA//bb2xGZc73SGkHSAJeOkVZheCGkmPEZMj/zGvPCvZj0ww2riykYGW+sz4J1I6 u6BfXzGCA4F9kFkvmjOLJNU5DrltJ0EYRMzftLzY18NMMDbr7ncwy+X5keKnW4u1pA5JMRhFYb16D dubl5riyW0sw48wNSO9Ki2wVuXmSx1yvSlnoNPWd1By/nYTKGqsrNCK79KKeBzygdx0+9JUoITgSE nLUmrj+tMAiQmv6o/psA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qBzpk-00ExGg-0R; Wed, 21 Jun 2023 15:33:24 +0000 Received: from mail-lf1-x12f.google.com ([2a00:1450:4864:20::12f]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qBzph-00ExF0-0S for linux-phy@lists.infradead.org; Wed, 21 Jun 2023 15:33:22 +0000 Received: by mail-lf1-x12f.google.com with SMTP id 2adb3069b0e04-4f875b267d9so4530857e87.1 for ; Wed, 21 Jun 2023 08:33:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687361599; x=1689953599; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cinDdKc7qcFMBG/ILqluH58R0lxOnWl8AXgWQvYj7y8=; b=b9Uw8PP6PLmB5enJ+YN/gAWstIZcK2d6cPFFyC+HnhzhIc4frOT4XfJBKmua/afreb IDZChcMC5maApOrqooiLfSHE02o2EiXZesginJJzWeZeqlUHRrG7jR80XtE3AiI7VmtC HZI4aSI1i9RimFa0fI3huEzlOcx4k5B7HTtBTVo8pPX928LSi/n+Gm7Ydzk80Bodg6W4 32pdtMhAkfrKubVOvWraqT0AGWi0lueXE5aqgqRb0pQK8xF4e/GBqKld5i8nFHpkZ3IK GxJDe2d8G19zTxKfCBHCpquAI37gAW+/c5doRep6NLvS6/FgoagpIE5JH9jYpF4uYU7G beAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687361599; x=1689953599; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cinDdKc7qcFMBG/ILqluH58R0lxOnWl8AXgWQvYj7y8=; b=B8g1enYwpfzJJd3Glfx18uPEIOCrlgYDqYvOWEcjEHjFR0RAT9Oz/+i7UxPO80okmA 55jvpcJxTkHpPDwFyF4XZeARGFRrwWsGKC2uqp7aNjb7zfWWtZ9xwINk10H4YPlDZgJF yH/xL3uRq/wQUIbrmCAkVAjgXPAugUaLx1gcjGT29GO2I25CP1yZyfYG/YuSp9L3zC98 +mI6vcQ2WuiWP+feieHFHHl2Gy0Jb1JCzN5gdzggbdcCR8HonW82TnUViFALAndpJH2M GUwRhfxw6rwcjJBjQPgTMnBTVN+TVI/cZFbjH7XykwtMxKr9llsrMdvv1FGtnm0xyenH g6qg== X-Gm-Message-State: AC+VfDxEDRQgHXLQSWe7HyOIG4U2nHJttxGr9nuFR5SdWfd3sJCk4z0C Kk9zb9upmTy0ER51o4tU0VDZMQ== X-Google-Smtp-Source: ACHHUZ4Swfo7lJHYU8UGgmXXrp9UT8Vv0+TqrSkf2YR9MicmmVjGVh7uzAoR2yPbD5YuFHbEZVPeCQ== X-Received: by 2002:a19:6d0c:0:b0:4f8:4245:ed57 with SMTP id i12-20020a196d0c000000b004f84245ed57mr10106450lfc.35.1687361599343; Wed, 21 Jun 2023 08:33:19 -0700 (PDT) Received: from umbar.unikie.fi ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id o3-20020a056512050300b004f8751285a5sm804888lfb.80.2023.06.21.08.33.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jun 2023 08:33:18 -0700 (PDT) From: Dmitry Baryshkov To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Vinod Koul , Kishon Vijay Abraham I Cc: Philipp Zabel , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, Neil Armstrong , freedreno@lists.freedesktop.org Subject: [RESEND PATCH 1/7] phy: qcom: qmp-combo: correct bias0_en programming Date: Wed, 21 Jun 2023 18:33:11 +0300 Message-Id: <20230621153317.1025914-2-dmitry.baryshkov@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230621153317.1025914-1-dmitry.baryshkov@linaro.org> References: <20230621153317.1025914-1-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230621_083321_183657_13487881 X-CRM114-Status: GOOD ( 10.27 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org It seems the commit a2e927b0e50d ("phy: qcom-qmp-combo: Add sc8280xp USB/DP combo phys") contained a typo for selecting bias0_en values. First, bias0_en and bias1_en are expected to be symmetrical, and then the vendor driver also uses `flipped : 0x3E : 0x15` statement for bias0_en. Correct bias0_en programming to follow this. Fixes: 49742e9edab3 ("phy: qcom-qmp-combo: Add support for SM8550") Fixes: a2e927b0e50d ("phy: qcom-qmp-combo: Add sc8280xp USB/DP combo phys") Signed-off-by: Dmitry Baryshkov --- drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c index bebce8c591a3..9d03b7b8e00c 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c @@ -2322,7 +2322,7 @@ static int qmp_v5_configure_dp_phy(struct qmp_combo *qmp) return ret; if (dp_opts->lanes == 1) { - bias0_en = reverse ? 0x3e : 0x1a; + bias0_en = reverse ? 0x3e : 0x15; drvr0_en = reverse ? 0x13 : 0x10; bias1_en = reverse ? 0x15 : 0x3e; drvr1_en = reverse ? 0x10 : 0x13; @@ -2382,7 +2382,7 @@ static int qmp_v6_configure_dp_phy(struct qmp_combo *qmp) return ret; if (dp_opts->lanes == 1) { - bias0_en = reverse ? 0x3e : 0x1a; + bias0_en = reverse ? 0x3e : 0x15; drvr0_en = reverse ? 0x13 : 0x10; bias1_en = reverse ? 0x15 : 0x3e; drvr1_en = reverse ? 0x10 : 0x13;