diff mbox series

[RFC,net-next,5/8] net: phy: balance calls to ->suspend() and ->resume()

Message ID 20230817150644.3605105-6-vladimir.oltean@nxp.com
State Superseded
Headers show
Series Add C72/C73 copper backplane support for LX2160 | expand

Commit Message

Vladimir Oltean Aug. 17, 2023, 3:06 p.m. UTC 
Some future PHY drivers will need to do balanced stuff in these methods,
like phy_power_off() and phy_power_on(). Currently ->resume() is called
twice during initialization, leading to phy_power_off() not actually
doing anything during ->suspend() because the refcount in the generic
PHY core remains elevated.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 drivers/net/phy/phy_device.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
index 17cb3e07216a..9cb5aa04b2b5 100644
--- a/drivers/net/phy/phy_device.c
+++ b/drivers/net/phy/phy_device.c
@@ -1882,7 +1882,7 @@  int __phy_resume(struct phy_device *phydev)
 
 	lockdep_assert_held(&phydev->lock);
 
-	if (!phydrv || !phydrv->resume)
+	if (!phydrv || !phydrv->resume || !phydev->suspended)
 		return 0;
 
 	ret = phydrv->resume(phydev);
@@ -3275,6 +3275,8 @@  static int phy_probe(struct device *dev)
 	if (phydrv->flags & PHY_IS_INTERNAL)
 		phydev->is_internal = true;
 
+	phydev->suspended = true;
+
 	/* Deassert the reset signal */
 	phy_device_reset(phydev, 0);