| Message ID | 20230819031731.22618-6-semen.protsenko@linaro.org |
|---|---|
| State | Accepted |
| Commit | 255ec3879dd4d585799fd8d8a94a335eaf84d2ec |
| Headers | show |
| Series | arm64: exynos: Enable USB for E850-96 board | expand |
On 19/08/2023 05:17, Sam Protsenko wrote: > Modern Exynos chips (like Exynos850) might have 26 MHz OSCCLK external > clock, which is also used as a PHY reference clock. For some USB PHY > controllers (e.g USB DRD PHY block on Exynos850) there is no need to set > the refclk frequency at all (and corresponding bits in CLKRSTCTRL[7:5] > are marked RESERVED), so that value won't be set in the driver. But > even in that case, 26 MHz support still has to be added, otherwise > exynos5_rate_to_clk() fails, which leads in turn to probe error. > > Add the correct value for 26MHz refclk to make it possible to add > support for new Exynos USB DRD PHY controllers. > > Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> > --- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/drivers/phy/samsung/phy-exynos5-usbdrd.c b/drivers/phy/samsung/phy-exynos5-usbdrd.c index 1ece4a1a1a6e..41508db87b9b 100644 --- a/drivers/phy/samsung/phy-exynos5-usbdrd.c +++ b/drivers/phy/samsung/phy-exynos5-usbdrd.c @@ -30,6 +30,7 @@ #define EXYNOS5_FSEL_19MHZ2 0x3 #define EXYNOS5_FSEL_20MHZ 0x4 #define EXYNOS5_FSEL_24MHZ 0x5 +#define EXYNOS5_FSEL_26MHZ 0x82 #define EXYNOS5_FSEL_50MHZ 0x7 /* Exynos5: USB 3.0 DRD PHY registers */ @@ -244,6 +245,9 @@ static unsigned int exynos5_rate_to_clk(unsigned long rate, u32 *reg) case 24 * MHZ: *reg = EXYNOS5_FSEL_24MHZ; break; + case 26 * MHZ: + *reg = EXYNOS5_FSEL_26MHZ; + break; case 50 * MHZ: *reg = EXYNOS5_FSEL_50MHZ; break;
Modern Exynos chips (like Exynos850) might have 26 MHz OSCCLK external clock, which is also used as a PHY reference clock. For some USB PHY controllers (e.g USB DRD PHY block on Exynos850) there is no need to set the refclk frequency at all (and corresponding bits in CLKRSTCTRL[7:5] are marked RESERVED), so that value won't be set in the driver. But even in that case, 26 MHz support still has to be added, otherwise exynos5_rate_to_clk() fails, which leads in turn to probe error. Add the correct value for 26MHz refclk to make it possible to add support for new Exynos USB DRD PHY controllers. Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> --- drivers/phy/samsung/phy-exynos5-usbdrd.c | 4 ++++ 1 file changed, 4 insertions(+)