From patchwork Sat Sep 23 13:48:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Oltean X-Patchwork-Id: 13396756 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4ED22CE7A8B for ; Sat, 23 Sep 2023 13:49:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jpj+Y55mgwbi3PjIxRMhMCLVCbxbjJvSgXQ9c+/g9Ok=; b=cL8Yf7lwnepmYQ HvFSZVnwmyv2clX2TWgMzfseLwBU7W/rLD/bOuXP0GQx1O8qJcGa5/NIDC6VBaTQgV3k+i6Ry+OAx 0lc9XYYKLBJMQmkWC3waDkbDjvtHo4Za2zIJcwgGdMtFeH5O5pkjT6g5Pn2p5Cim7qfqktj32rrQW lARLqRmAheWRn1E+fKSa0JUv6CLVJCLlhDZ+csPz3ySOv2LdZjUE3zpzFyMf9gQfbPon8JVnFFxWl i9ROtGDtSVnqolfaPl/p010UWvUjz6bM1EdFI11BgTI1sR30AzTtqLKXFkIdEsisVAItQ+wXkVLrd T6uP9m5nB6RGmtCIQKuQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qk310-00B3As-08; Sat, 23 Sep 2023 13:49:46 +0000 Received: from mail-vi1eur05on2061e.outbound.protection.outlook.com ([2a01:111:f400:7d00::61e] helo=EUR05-VI1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qk30w-00B31M-3C for linux-phy@lists.infradead.org; Sat, 23 Sep 2023 13:49:44 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EYOt2smFwsLNOXpJtlKG9auOote6smGUEYZwYgfoRblngBu7t6M8Hpwqu5JvEDDHGKwGdJE0v0ywQ0QgAq+d55yy2KSBS1Cb9MhVF8sBfpYoj1KzH3MMS9NU7q0xum+eANZYTm73BXLdnjIJNWNsFT1KVK2zFwlcxxplrC5LMBMwwRlxryXSWgFeHGVr7XkE9PK4ZjNXdR4YVOB2//7iNAjwfAAn31F2zMNSr5ZSzMXUGIaulcQn5vMr6nj8BzWPygy9XTMbVtr6Eh8/5CdsnumamIqa1LsIESwCqWZHnLmYatn9rJNn9lFVQcicKh5Kq2PG3X4ylGIKsB7ploK4Gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=f2SciGmlkCgzOy99iuFcgQ8/NUtI7USZSQUF0JH52F4=; b=YTEwFrGmifKe3Kh+Ktvald9CeUsR9jHZromRtzmmTM82W41WwDTle2V1kkbQ4lJ0sS9zP6/+RnmL/rRDmEH0rMFYAW8x0QRRCbU5/cfy12KM6qKu+8Srwp0TGerXzq++3jVikef06uZl6VCF6twHopdqVVn5p8L1KwjhUqXS3Db4UEEr9hoAr7smT653pZXxnCRZ5ZN3MTfs63FSMA37NjVPwfzt3lCdYIeu7jByZK5zEmoXNGVEmeC95ml8V97TK7//Lz8BRwbQn3+gXMvPOilZ9oeQdw3AIfCb4HgBv7izNYuYCUbZMMCXAKLuwXGHXXaR8jC+MpPtvaNG/HD//A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f2SciGmlkCgzOy99iuFcgQ8/NUtI7USZSQUF0JH52F4=; b=r4+Ua2HMWh50mgmwuEw5gNlwlMe/ehCD9Soi66crh67ewps1Aso/R8FTnujp90Z6byJOKyY+tvma7Ch2nJVI1iLT9IvukxAgrutATmJpUJGWxZfU34vBHriNE5jFTzMnZFw4kc8aW2pxe+WEl9LaRne5uRgji3resJqcQ8wfHYY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM0PR04MB6452.eurprd04.prod.outlook.com (2603:10a6:208:16d::21) by AS1PR04MB9454.eurprd04.prod.outlook.com (2603:10a6:20b:4d9::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.21; Sat, 23 Sep 2023 13:49:34 +0000 Received: from AM0PR04MB6452.eurprd04.prod.outlook.com ([fe80::568a:57ee:35b5:e454]) by AM0PR04MB6452.eurprd04.prod.outlook.com ([fe80::568a:57ee:35b5:e454%3]) with mapi id 15.20.6813.024; Sat, 23 Sep 2023 13:49:34 +0000 From: Vladimir Oltean To: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org Cc: "Russell King (Oracle)" , Heiner Kallweit , Andrew Lunn , Florian Fainelli , Madalin Bucur , Ioana Ciornei , Camelia Groza , Li Yang , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sean Anderson , Maxime Chevallier , Vinod Koul , Kishon Vijay Abraham I Subject: [RFC PATCH v2 net-next 10/15] net: phylink: support all ethtool port modes with inband modes Date: Sat, 23 Sep 2023 16:48:59 +0300 Message-Id: <20230923134904.3627402-11-vladimir.oltean@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230923134904.3627402-1-vladimir.oltean@nxp.com> References: <20230923134904.3627402-1-vladimir.oltean@nxp.com> X-ClientProxiedBy: FR3P281CA0165.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::10) To AM0PR04MB6452.eurprd04.prod.outlook.com (2603:10a6:208:16d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM0PR04MB6452:EE_|AS1PR04MB9454:EE_ X-MS-Office365-Filtering-Correlation-Id: d32c1671-df61-4eb9-3fdd-08dbbc3beb61 X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8Jhxud0XyVF7/5WqN8gNU5QOkshPkIX5frQm1uAEzUy+KdHigRbWhCrfJc5PgXB8LQ/IutCnBFhAjiQCAbvRCiD5ojXiUSWjtzfCq5hsXN+9svhe7cXEvE0OGo3gmjvIxV/NDEQLRADiic8PJWjfYGugtbx0JM1o/FMdASo2Wfxya64llcOw4iQjsNq/5zEpUyAg3yVH3vHU7B15eHEDcOG6CPq21EKZOSGFlta93uVvzd/wExL1auOWldRlzvax8DP7yDOk19tiIz5/Jy3QslJDWr8PbHoV7oYJRostAXxT/gav1pCd9bGinrBH/8eZeh+Pu6yQlSEmHNZm7ucR0dyVsuYTaszfW96bbxtMq27kdknAx0WG3/fPoLID0oHtP18RWJmIQEVzDMSKdoB3o/9tFCxB3GuXJ7xoE63wPkFKLhvcllDVEPeDjTMKHQU23H+XMmAv28O96KdOvozITx0sdFDjHJcB3FrSjFGaqLRiN8eLZ48cHeAOybCE3Gwiaocd2QGPjYqv+YO/o3wRBa11A8tH6Nt9KA3+WFxoIH+X2/eD47TZUrfT3Ihbfi7PgIVWeOThv24NicNqo2rPhwQGfxVnL9SpxIGOLSH8O1VSW47HhIs+P5a+Ogwawmi2 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB6452.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366004)(346002)(39860400002)(136003)(396003)(376002)(230922051799003)(1800799009)(451199024)(186009)(66556008)(52116002)(2616005)(6506007)(6512007)(316002)(5660300002)(66946007)(38350700002)(6666004)(478600001)(1076003)(66476007)(26005)(44832011)(2906002)(4326008)(36756003)(41300700001)(7416002)(54906003)(38100700002)(6486002)(8936002)(86362001)(8676002)(83380400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: MAoeq/OoZgtICxCbhF2Rmx0lgXWWUbgkYK7W8liZQprq/RlYrmV0zpUOUsmWQohXKxx0WIKe3O/8H9yqRy16vldE39ZxgW+/AfQjVfv5UYM3DrMm0q25q6gtzgbN4+BeM+Y7JytAPpUw574bx5nZu5HloGNyaCeqLbBY00D0GgFgvnesh9VEaE4iKiWJfOwkwFSUZZXU7sXhQisDRcKXzdpwo8BO6QGAIxZOtNem9mgjb94Rf91j9ONEcL0W1K9I+fYLvy/yX/6+iSVlWE9CQkmRNWGbyLhGc+TkwBG65qB7LDN2qPGW3t9VZdnJm6afhvcwXGToM29cF9JT7xZlw3QsMlyskQ6Z3ykF9+F35Eb+sCEeYzmzNRAXUEnracczOAo73W8eUglobbMUKU63pBNZWmTSJ7kvqvWMumq1lvP+DMaYW8EXd4imzapPMWFl8MpSUkwcAb6u+LDz4R5e9ERtRkFMkWXNGOUDcI9Ul42GlHn4BRcP2leR6Udneh0vXgpeV8Sd44J6BRH59i4etKyFJDKHYYtGNZTs2u+7Y1pOyKYYQKO49C7fd2/0GzWRidv3QNf4bEF0vbjsRQzz9vyEgyqpE6zLvyENReaFoFpJDws7ReXvo1G7Qy3psXkHd25NhuiFzEv+lHDGA4wvunhA/K57CaKTpr2ZKriLQVlF0nkIYYVJHuAbTUYK2fnSa6AkaVw7V/7IZox3iVd9Bc9/ImEywIZgJTfwkBx0RzZhpNPz+jcLJ24AxBwSd+iC4tXP56w5iX0nJFjdqSCYQXDLpZIcZk2lCpttjPrlktVnCV5Dj8pwRFqGOFEx0MeekWg/KW/L9Aupjuo4JwqmbGxq+hVdPmV6wfqDNurW3EJu9dT+vcfnmUEurdcLl4FUoAAjpmiCMuIlBzdgPej7RNXHW7Y3Ul89GQX53p1Ua5K1mFz+X6VRiJxyKa3q9P5oMKPyDdLcqWJuax5N48OkvGVzigFmdIAFVTXW5FLKEoTdQ3knWtgDs04X33m7V0dMdivi5aN4llPlMPmfu7lBdST5oAEzA97gs/3e3LxOlGB8f0AOJ5LoDy0/nBzV2tlV4Gscw3dUkHo+4li98rdUuTFx0KStrmv3NTgMTunQYNLb+BQYr80ugGOMIpy7g8hH3aXZ5VJ89q2LyZHJzrAjPr/s2svEA/wz4WRWiGA9ZauoSk7384IEwKslyb0apNrK4IRAE5PXp6t+NGLDddJmsC1AGKr6PhzSmKqrhVfBMriQZMbcJVI344G7tFxpyj8WN2UmTkimPRRmakkTXKwqo0qH0V1PhgXMkeFufO2HmqkQlhTBFdLFcS+TS0FF/bLbhxnm8PmHR35n6I5O+n3nQBMtuHA1npZZYaB3Ke4V8jq67Yt0SYMt7By7jXZNRX1hHVBTioszzqHESHd1AFQ8Tv6BTp2eUvbHVVw+qZx3yviG17jJonALZCzRRzVazVtCbux2X18MkEea36Oo1vsjcBidv/hFGk19z64wHSmD1FbEtAGXAv3nNSgbySHLWDv0IDbEI55I8cM2nM9as9Qv/2KJFwQFNlL5yJ1Ls89W68g9H8NvQ2iViWO3SSBLsSs6qlDsWuHl3+E1PhOWr3fwHQ== X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: d32c1671-df61-4eb9-3fdd-08dbbc3beb61 X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2023 13:49:34.2688 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: m4W2km6SRx4VPXYBATJ8UPAsGXSfUv5Ae6ghCuytEvKXLSwbuavVyf7UONE/44K5a9nat9R8/fc0KvhzakweWw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9454 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230923_064943_032233_B37152B7 X-CRM114-Status: GOOD ( 11.51 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Currently, phylink_parse_mode() filters out all port modes except ETHTOOL_LINK_MODE_MII_BIT for in-band link modes. But if we're going to accept backplane port modes with inband autoneg, then we should also allow ETHTOOL_LINK_MODE_Backplane_BIT. Use phylink_set_port_modes() to just allow them all, and let the validate() functions of the MAC and phylink_pcs restrict what they don't support. Signed-off-by: Vladimir Oltean --- v1->v2: patch is new drivers/net/phy/phylink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c index 88ace7e203c3..6415c7b91053 100644 --- a/drivers/net/phy/phylink.c +++ b/drivers/net/phy/phylink.c @@ -880,7 +880,7 @@ static int phylink_parse_mode(struct phylink *pl, } linkmode_zero(pl->supported); - phylink_set(pl->supported, MII); + phylink_set_port_modes(pl->supported); phylink_set(pl->supported, Autoneg); phylink_set(pl->supported, Asym_Pause); phylink_set(pl->supported, Pause);