| Message ID | 20231017080354.538047-1-sakari.ailus@linux.intel.com |
|---|---|
| State | Accepted |
| Commit | d0ec7b9c3153c941f98226001d4019d9c03faf81 |
| Headers | show |
| Series | [1/1] phy: Kconfig: Select GENERIC_PHY for GENERIC_PHY_MIPI_DPHY | expand |
On 10/17/23 01:03, Sakari Ailus wrote: > GENERIC_PHY can be selected by GENERIC_PHY_MIPI_DPHY directly as > GENERIC_PHY has no dependencies. This way drivers that depend on > GENERIC_PHY_MIPI_DPHY can avoid having to select both --- which they > apparently often omit, too, which further leads to build failures. > > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Reviewed-by: Randy Dunlap <rdunlap@infradead.org> Tested-by: Randy Dunlap <rdunlap@infradead.org> Thanks. > --- > drivers/phy/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig > index d1670bbe6d6b..787354b849c7 100644 > --- a/drivers/phy/Kconfig > +++ b/drivers/phy/Kconfig > @@ -18,7 +18,7 @@ config GENERIC_PHY > > config GENERIC_PHY_MIPI_DPHY > bool > - depends on GENERIC_PHY > + select GENERIC_PHY > help > Generic MIPI D-PHY support. >
On Tue, 17 Oct 2023 11:03:54 +0300, Sakari Ailus wrote: > GENERIC_PHY can be selected by GENERIC_PHY_MIPI_DPHY directly as > GENERIC_PHY has no dependencies. This way drivers that depend on > GENERIC_PHY_MIPI_DPHY can avoid having to select both --- which they > apparently often omit, too, which further leads to build failures. > > Applied, thanks! [1/1] phy: Kconfig: Select GENERIC_PHY for GENERIC_PHY_MIPI_DPHY commit: d0ec7b9c3153c941f98226001d4019d9c03faf81 Best regards,
diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig index d1670bbe6d6b..787354b849c7 100644 --- a/drivers/phy/Kconfig +++ b/drivers/phy/Kconfig @@ -18,7 +18,7 @@ config GENERIC_PHY config GENERIC_PHY_MIPI_DPHY bool - depends on GENERIC_PHY + select GENERIC_PHY help Generic MIPI D-PHY support.
GENERIC_PHY can be selected by GENERIC_PHY_MIPI_DPHY directly as GENERIC_PHY has no dependencies. This way drivers that depend on GENERIC_PHY_MIPI_DPHY can avoid having to select both --- which they apparently often omit, too, which further leads to build failures. Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> --- drivers/phy/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)