| Message ID | 20231214062847.2215542-3-quic_ipkumar@quicinc.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Add PCIe support for Qualcomm IPQ5332 | expand |
On Thu, 14 Dec 2023 at 08:29, Praveenkumar I <quic_ipkumar@quicinc.com> wrote: > > Qualcomm IPQ5332 has a combo PHY for PCIe and USB. Either one of the > interface (PCIe/USB) can use this combo PHY and the PHY drivers are > different for PCIe and USB. Hence separate the PCIe and USB pipe clock > source from DT, and individual driver node can be used as a clock source > separately in the gcc. Add separate enum for PCIe and USB pipe clock and > change the parent in corresponding structures. > > Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> Please use your full name for the git authorship and or the S-o-B tags. This applies to the whole series. Other than that: Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > drivers/clk/qcom/gcc-ipq5332.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/clk/qcom/gcc-ipq5332.c b/drivers/clk/qcom/gcc-ipq5332.c > index f98591148a97..aa0f616c3b1b 100644 > --- a/drivers/clk/qcom/gcc-ipq5332.c > +++ b/drivers/clk/qcom/gcc-ipq5332.c > @@ -25,7 +25,8 @@ enum { > DT_SLEEP_CLK, > DT_PCIE_2LANE_PHY_PIPE_CLK, > DT_PCIE_2LANE_PHY_PIPE_CLK_X1, > - DT_USB_PCIE_WRAPPER_PIPE_CLK, > + DT_PCIE_WRAPPER_PIPE_CLK, > + DT_USB_WRAPPER_PIPE_CLK, > }; > > enum { > @@ -728,7 +729,7 @@ static struct clk_regmap_phy_mux gcc_pcie3x1_0_pipe_clk_src = { > .hw.init = &(struct clk_init_data) { > .name = "gcc_pcie3x1_0_pipe_clk_src", > .parent_data = &(const struct clk_parent_data) { > - .index = DT_USB_PCIE_WRAPPER_PIPE_CLK, > + .index = DT_PCIE_WRAPPER_PIPE_CLK, > }, > .num_parents = 1, > .ops = &clk_regmap_phy_mux_ops, > @@ -1072,7 +1073,7 @@ static struct clk_regmap_phy_mux gcc_usb0_pipe_clk_src = { > .hw.init = &(struct clk_init_data) { > .name = "gcc_usb0_pipe_clk_src", > .parent_data = &(const struct clk_parent_data) { > - .index = DT_USB_PCIE_WRAPPER_PIPE_CLK, > + .index = DT_USB_WRAPPER_PIPE_CLK, > }, > .num_parents = 1, > .ops = &clk_regmap_phy_mux_ops, > -- > 2.34.1 > >
On 12/14/2023 12:39 PM, Dmitry Baryshkov wrote: > On Thu, 14 Dec 2023 at 08:29, Praveenkumar I <quic_ipkumar@quicinc.com> wrote: >> Qualcomm IPQ5332 has a combo PHY for PCIe and USB. Either one of the >> interface (PCIe/USB) can use this combo PHY and the PHY drivers are >> different for PCIe and USB. Hence separate the PCIe and USB pipe clock >> source from DT, and individual driver node can be used as a clock source >> separately in the gcc. Add separate enum for PCIe and USB pipe clock and >> change the parent in corresponding structures. >> >> Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> > Please use your full name for the git authorship and or the S-o-B > tags. This applies to the whole series. My full name is "Praveenkumar I". In my region, we used to have only the initial letter of surname. -- Thanks, Praveenkumar > Other than that: > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > >> --- >> drivers/clk/qcom/gcc-ipq5332.c | 7 ++++--- >> 1 file changed, 4 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/clk/qcom/gcc-ipq5332.c b/drivers/clk/qcom/gcc-ipq5332.c >> index f98591148a97..aa0f616c3b1b 100644 >> --- a/drivers/clk/qcom/gcc-ipq5332.c >> +++ b/drivers/clk/qcom/gcc-ipq5332.c >> @@ -25,7 +25,8 @@ enum { >> DT_SLEEP_CLK, >> DT_PCIE_2LANE_PHY_PIPE_CLK, >> DT_PCIE_2LANE_PHY_PIPE_CLK_X1, >> - DT_USB_PCIE_WRAPPER_PIPE_CLK, >> + DT_PCIE_WRAPPER_PIPE_CLK, >> + DT_USB_WRAPPER_PIPE_CLK, >> }; >> >> enum { >> @@ -728,7 +729,7 @@ static struct clk_regmap_phy_mux gcc_pcie3x1_0_pipe_clk_src = { >> .hw.init = &(struct clk_init_data) { >> .name = "gcc_pcie3x1_0_pipe_clk_src", >> .parent_data = &(const struct clk_parent_data) { >> - .index = DT_USB_PCIE_WRAPPER_PIPE_CLK, >> + .index = DT_PCIE_WRAPPER_PIPE_CLK, >> }, >> .num_parents = 1, >> .ops = &clk_regmap_phy_mux_ops, >> @@ -1072,7 +1073,7 @@ static struct clk_regmap_phy_mux gcc_usb0_pipe_clk_src = { >> .hw.init = &(struct clk_init_data) { >> .name = "gcc_usb0_pipe_clk_src", >> .parent_data = &(const struct clk_parent_data) { >> - .index = DT_USB_PCIE_WRAPPER_PIPE_CLK, >> + .index = DT_USB_WRAPPER_PIPE_CLK, >> }, >> .num_parents = 1, >> .ops = &clk_regmap_phy_mux_ops, >> -- >> 2.34.1 >> >> >
On Fri, 15 Dec 2023 at 07:44, Praveenkumar I <quic_ipkumar@quicinc.com> wrote: > > > > On 12/14/2023 12:39 PM, Dmitry Baryshkov wrote: > > On Thu, 14 Dec 2023 at 08:29, Praveenkumar I <quic_ipkumar@quicinc.com> wrote: > >> Qualcomm IPQ5332 has a combo PHY for PCIe and USB. Either one of the > >> interface (PCIe/USB) can use this combo PHY and the PHY drivers are > >> different for PCIe and USB. Hence separate the PCIe and USB pipe clock > >> source from DT, and individual driver node can be used as a clock source > >> separately in the gcc. Add separate enum for PCIe and USB pipe clock and > >> change the parent in corresponding structures. > >> > >> Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> > > Please use your full name for the git authorship and or the S-o-B > > tags. This applies to the whole series. > My full name is "Praveenkumar I". In my region, we used to have only the > initial letter of surname. Oh, excuse me please then. I saw several of your colleagues using a single letter instead of their surname and I supposed that it's a case for you too.
diff --git a/drivers/clk/qcom/gcc-ipq5332.c b/drivers/clk/qcom/gcc-ipq5332.c index f98591148a97..aa0f616c3b1b 100644 --- a/drivers/clk/qcom/gcc-ipq5332.c +++ b/drivers/clk/qcom/gcc-ipq5332.c @@ -25,7 +25,8 @@ enum { DT_SLEEP_CLK, DT_PCIE_2LANE_PHY_PIPE_CLK, DT_PCIE_2LANE_PHY_PIPE_CLK_X1, - DT_USB_PCIE_WRAPPER_PIPE_CLK, + DT_PCIE_WRAPPER_PIPE_CLK, + DT_USB_WRAPPER_PIPE_CLK, }; enum { @@ -728,7 +729,7 @@ static struct clk_regmap_phy_mux gcc_pcie3x1_0_pipe_clk_src = { .hw.init = &(struct clk_init_data) { .name = "gcc_pcie3x1_0_pipe_clk_src", .parent_data = &(const struct clk_parent_data) { - .index = DT_USB_PCIE_WRAPPER_PIPE_CLK, + .index = DT_PCIE_WRAPPER_PIPE_CLK, }, .num_parents = 1, .ops = &clk_regmap_phy_mux_ops, @@ -1072,7 +1073,7 @@ static struct clk_regmap_phy_mux gcc_usb0_pipe_clk_src = { .hw.init = &(struct clk_init_data) { .name = "gcc_usb0_pipe_clk_src", .parent_data = &(const struct clk_parent_data) { - .index = DT_USB_PCIE_WRAPPER_PIPE_CLK, + .index = DT_USB_WRAPPER_PIPE_CLK, }, .num_parents = 1, .ops = &clk_regmap_phy_mux_ops,
Qualcomm IPQ5332 has a combo PHY for PCIe and USB. Either one of the interface (PCIe/USB) can use this combo PHY and the PHY drivers are different for PCIe and USB. Hence separate the PCIe and USB pipe clock source from DT, and individual driver node can be used as a clock source separately in the gcc. Add separate enum for PCIe and USB pipe clock and change the parent in corresponding structures. Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> --- drivers/clk/qcom/gcc-ipq5332.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)