diff mbox series

phy: armada-38x: add mux value for gbe port 0 on serdes 0

Message ID 20240106-fix-a38x-comphy-sd0-gbe0-v1-1-c7fd87272050@solid-run.com
State Accepted
Commit f7c6249d76f1167f2fc9843311e54e2528666d11
Headers show
Series phy: armada-38x: add mux value for gbe port 0 on serdes 0 | expand

Commit Message

Josua Mayer Jan. 6, 2024, 2:56 p.m. UTC 
Armada 38x supports 3 functions on serdes #0:
- pcie port 0
- sata port 0
- gbe port 0

Add missing entry for gbe port 0 on serdes 0 to the gbe_mux array.

Because this array looks obscure to new readers, also add a comment
explaining the meaning of rows, columns and values.

Signed-off-by: Josua Mayer <josua@solid-run.com>
---
 drivers/phy/marvell/phy-armada38x-comphy.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)


---
base-commit: b85ea95d086471afb4ad062012a4d73cd328fa86
change-id: 20240106-fix-a38x-comphy-sd0-gbe0-02b6861cf973

Sincerely,

Comments

Vinod Koul Jan. 24, 2024, 6 a.m. UTC | #1 
On Sat, 06 Jan 2024 15:56:33 +0100, Josua Mayer wrote:
> Armada 38x supports 3 functions on serdes #0:
> - pcie port 0
> - sata port 0
> - gbe port 0
> 
> Add missing entry for gbe port 0 on serdes 0 to the gbe_mux array.
> 
> [...]

Applied, thanks!

[1/1] phy: armada-38x: add mux value for gbe port 0 on serdes 0
      commit: f7c6249d76f1167f2fc9843311e54e2528666d11

Best regards,
diff mbox series

Patch

diff --git a/drivers/phy/marvell/phy-armada38x-comphy.c b/drivers/phy/marvell/phy-armada38x-comphy.c
index b7d99861526a..d3259984ee8e 100644
--- a/drivers/phy/marvell/phy-armada38x-comphy.c
+++ b/drivers/phy/marvell/phy-armada38x-comphy.c
@@ -47,8 +47,13 @@  struct a38x_comphy {
 	struct a38x_comphy_lane lane[MAX_A38X_COMPHY];
 };
 
+/*
+ * Map serdes lanes and gbe ports to serdes mux configuration values:
+ * row index = serdes lane,
+ * column index = gbe port number.
+ */
 static const u8 gbe_mux[MAX_A38X_COMPHY][MAX_A38X_PORTS] = {
-	{ 0, 0, 0 },
+	{ 3, 0, 0 },
 	{ 4, 5, 0 },
 	{ 0, 4, 0 },
 	{ 0, 0, 4 },