| Message ID | 20240401182240.55282-3-danila@jiaxyga.com |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | phy: qcom-qmp-ufs: Fix PHY QMP clocks for SC7180 | expand |
On Mon, 1 Apr 2024 at 21:23, Danila Tikhonov <danila@jiaxyga.com> wrote: > > QMP PHY used in SC7180 requires 3 clocks: > > * ref - 19.2MHz reference clock from RPMh > * ref_aux - Auxiliary reference clock from GCC > * qref - QREF clock from GCC > > While at it, let's move 'clocks' property before 'clock-names' to match > the style used commonly. > > Signed-off-by: Danila Tikhonov <danila@jiaxyga.com> > --- > arch/arm64/boot/dts/qcom/sc7180.dtsi | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> -- With best wishes Dmitry
On Mon, Apr 01, 2024 at 09:22:40PM +0300, Danila Tikhonov wrote: > QMP PHY used in SC7180 requires 3 clocks: > > * ref - 19.2MHz reference clock from RPMh > * ref_aux - Auxiliary reference clock from GCC > * qref - QREF clock from GCC > > While at it, let's move 'clocks' property before 'clock-names' to match > the style used commonly. > > Signed-off-by: Danila Tikhonov <danila@jiaxyga.com> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> - Mani > --- > arch/arm64/boot/dts/qcom/sc7180.dtsi | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi > index 2b481e20ae38..5c9ec8047f00 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > @@ -1585,9 +1585,12 @@ ufs_mem_phy: phy@1d87000 { > compatible = "qcom,sc7180-qmp-ufs-phy", > "qcom,sm7150-qmp-ufs-phy"; > reg = <0 0x01d87000 0 0x1000>; > - clocks = <&gcc GCC_UFS_MEM_CLKREF_CLK>, > - <&gcc GCC_UFS_PHY_PHY_AUX_CLK>; > - clock-names = "ref", "ref_aux"; > + clocks = <&rpmhcc RPMH_CXO_CLK>, > + <&gcc GCC_UFS_PHY_PHY_AUX_CLK>, > + <&gcc GCC_UFS_MEM_CLKREF_CLK>; > + clock-names = "ref", > + "ref_aux", > + "qref"; > power-domains = <&gcc UFS_PHY_GDSC>; > resets = <&ufs_mem_hc 0>; > reset-names = "ufsphy"; > -- > 2.44.0 >
diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi index 2b481e20ae38..5c9ec8047f00 100644 --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi @@ -1585,9 +1585,12 @@ ufs_mem_phy: phy@1d87000 { compatible = "qcom,sc7180-qmp-ufs-phy", "qcom,sm7150-qmp-ufs-phy"; reg = <0 0x01d87000 0 0x1000>; - clocks = <&gcc GCC_UFS_MEM_CLKREF_CLK>, - <&gcc GCC_UFS_PHY_PHY_AUX_CLK>; - clock-names = "ref", "ref_aux"; + clocks = <&rpmhcc RPMH_CXO_CLK>, + <&gcc GCC_UFS_PHY_PHY_AUX_CLK>, + <&gcc GCC_UFS_MEM_CLKREF_CLK>; + clock-names = "ref", + "ref_aux", + "qref"; power-domains = <&gcc UFS_PHY_GDSC>; resets = <&ufs_mem_hc 0>; reset-names = "ufsphy";
QMP PHY used in SC7180 requires 3 clocks: * ref - 19.2MHz reference clock from RPMh * ref_aux - Auxiliary reference clock from GCC * qref - QREF clock from GCC While at it, let's move 'clocks' property before 'clock-names' to match the style used commonly. Signed-off-by: Danila Tikhonov <danila@jiaxyga.com> --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)