| Message ID | 20240602-cn9130-som-v6-4-89393e86d4c7@solid-run.com |
|---|---|
| State | Accepted |
| Commit | 4de480264948cbf2b08a72c39ee122a9f9761e03 |
| Headers | show |
| Series | arm64: dts: add description for solidrun cn9130 som and clearfog boards | expand |
On Sun, Jun 02, 2024 at 05:49:39PM +0200, Josua Mayer wrote: > Armada CP110 UTMI supports swapping D+ and D- signals. > usb251xb.yaml already describes a suitable device-tree property for the > same purpose but as child usb controller node. > > Add optional swap-dx-lanes device-tree property to armada cp110 utmi phy > with same semantics as usb251xb: > The property lists all ports that swap D+ and D-, unlisted ports are > considered correct. > > Signed-off-by: Josua Mayer <josua@solid-run.com> > --- > .../devicetree/bindings/phy/marvell,armada-cp110-utmi-phy.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/marvell,armada-cp110-utmi-phy.yaml b/Documentation/devicetree/bindings/phy/marvell,armada-cp110-utmi-phy.yaml > index 9ce7b4c6d208..2ef02aac042a 100644 > --- a/Documentation/devicetree/bindings/phy/marvell,armada-cp110-utmi-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/marvell,armada-cp110-utmi-phy.yaml > @@ -41,6 +41,12 @@ properties: > Phandle to the system controller node > $ref: /schemas/types.yaml#/definitions/phandle > > + swap-dx-lanes: Missing a vendor prefix. Otherwise, to me naive eye, seems okay. > + $ref: /schemas/types.yaml#/definitions/uint32-array > + description: | This | probably isn't needed though, there's not any format here that seems worth preserving. Thanks, Conor. > + Specifies the ports which will swap the differential-pair (D+/D-), > + default is not-swapped. > + > # Required child nodes: > > patternProperties: > > -- > 2.35.3 >
On Tue, Jun 04, 2024 at 06:41:03PM +0100, Conor Dooley wrote: > On Sun, Jun 02, 2024 at 05:49:39PM +0200, Josua Mayer wrote: > > Armada CP110 UTMI supports swapping D+ and D- signals. > > usb251xb.yaml already describes a suitable device-tree property for the > > same purpose but as child usb controller node. > > > > Add optional swap-dx-lanes device-tree property to armada cp110 utmi phy > > with same semantics as usb251xb: > > The property lists all ports that swap D+ and D-, unlisted ports are > > considered correct. > > > > Signed-off-by: Josua Mayer <josua@solid-run.com> > > --- > > .../devicetree/bindings/phy/marvell,armada-cp110-utmi-phy.yaml | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/phy/marvell,armada-cp110-utmi-phy.yaml b/Documentation/devicetree/bindings/phy/marvell,armada-cp110-utmi-phy.yaml > > index 9ce7b4c6d208..2ef02aac042a 100644 > > --- a/Documentation/devicetree/bindings/phy/marvell,armada-cp110-utmi-phy.yaml > > +++ b/Documentation/devicetree/bindings/phy/marvell,armada-cp110-utmi-phy.yaml > > @@ -41,6 +41,12 @@ properties: > > Phandle to the system controller node > > $ref: /schemas/types.yaml#/definitions/phandle > > > > + swap-dx-lanes: > > Missing a vendor prefix. > Otherwise, to me naive eye, seems okay. Already have the same property elsewhere, so it's fine. > > > + $ref: /schemas/types.yaml#/definitions/uint32-array > > + description: | > > This | probably isn't needed though, there's not any format here that > seems worth preserving. > > Thanks, > Conor. > > > + Specifies the ports which will swap the differential-pair (D+/D-), > > + default is not-swapped. > > + > > # Required child nodes: > > > > patternProperties: > > > > -- > > 2.35.3 > >
On Sun, 02 Jun 2024 17:49:39 +0200, Josua Mayer wrote: > Armada CP110 UTMI supports swapping D+ and D- signals. > usb251xb.yaml already describes a suitable device-tree property for the > same purpose but as child usb controller node. > > Add optional swap-dx-lanes device-tree property to armada cp110 utmi phy > with same semantics as usb251xb: > The property lists all ports that swap D+ and D-, unlisted ports are > considered correct. > > Signed-off-by: Josua Mayer <josua@solid-run.com> > --- > .../devicetree/bindings/phy/marvell,armada-cp110-utmi-phy.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/phy/marvell,armada-cp110-utmi-phy.yaml b/Documentation/devicetree/bindings/phy/marvell,armada-cp110-utmi-phy.yaml index 9ce7b4c6d208..2ef02aac042a 100644 --- a/Documentation/devicetree/bindings/phy/marvell,armada-cp110-utmi-phy.yaml +++ b/Documentation/devicetree/bindings/phy/marvell,armada-cp110-utmi-phy.yaml @@ -41,6 +41,12 @@ properties: Phandle to the system controller node $ref: /schemas/types.yaml#/definitions/phandle + swap-dx-lanes: + $ref: /schemas/types.yaml#/definitions/uint32-array + description: | + Specifies the ports which will swap the differential-pair (D+/D-), + default is not-swapped. + # Required child nodes: patternProperties:
Armada CP110 UTMI supports swapping D+ and D- signals. usb251xb.yaml already describes a suitable device-tree property for the same purpose but as child usb controller node. Add optional swap-dx-lanes device-tree property to armada cp110 utmi phy with same semantics as usb251xb: The property lists all ports that swap D+ and D-, unlisted ports are considered correct. Signed-off-by: Josua Mayer <josua@solid-run.com> --- .../devicetree/bindings/phy/marvell,armada-cp110-utmi-phy.yaml | 6 ++++++ 1 file changed, 6 insertions(+)