| Message ID | 20240715-hdmi-tx-v6-3-d27f029627ad@freebox.fr |
|---|---|
| State | Superseded |
| Headers | show |
| Series | HDMI TX support in msm8998 | expand |
On Mon, Jul 15, 2024 at 02:21:16PM GMT, Marc Gonzalez wrote: > Current driver already supports the msm8998 HDMI TX. > We just need to add the compatible string. > > Signed-off-by: Marc Gonzalez <mgonzalez@freebox.fr> > --- > drivers/gpu/drm/msm/hdmi/hdmi.c | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
On Mon, Jul 15, 2024 at 02:21:16PM +0200, Marc Gonzalez wrote: > Current driver already supports the msm8998 HDMI TX. > We just need to add the compatible string. Why is this required when the driver change suggests that this device is compatible with the existing 8974? > > Signed-off-by: Marc Gonzalez <mgonzalez@freebox.fr> > --- > drivers/gpu/drm/msm/hdmi/hdmi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/hdmi.c > index 24abcb7254cc4..0bfee41c2e71a 100644 > --- a/drivers/gpu/drm/msm/hdmi/hdmi.c > +++ b/drivers/gpu/drm/msm/hdmi/hdmi.c > @@ -549,6 +549,7 @@ static void msm_hdmi_dev_remove(struct platform_device *pdev) > } > > static const struct of_device_id msm_hdmi_dt_match[] = { > + { .compatible = "qcom,hdmi-tx-8998", .data = &hdmi_tx_8974_config }, > { .compatible = "qcom,hdmi-tx-8996", .data = &hdmi_tx_8974_config }, > { .compatible = "qcom,hdmi-tx-8994", .data = &hdmi_tx_8974_config }, > { .compatible = "qcom,hdmi-tx-8084", .data = &hdmi_tx_8974_config }, > > -- > 2.34.1 >
On Mon, Jul 15, 2024 at 04:26:12PM +0100, Conor Dooley wrote: > On Mon, Jul 15, 2024 at 02:21:16PM +0200, Marc Gonzalez wrote: > > Current driver already supports the msm8998 HDMI TX. > > We just need to add the compatible string. > > Why is this required when the driver change suggests that this device is > compatible with the existing 8974? (I know I reviewed the binding already, just noticing this which suggests a fallback would be appropriate, despite the differing clocks etc) > > > > > Signed-off-by: Marc Gonzalez <mgonzalez@freebox.fr> > > --- > > drivers/gpu/drm/msm/hdmi/hdmi.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/hdmi.c > > index 24abcb7254cc4..0bfee41c2e71a 100644 > > --- a/drivers/gpu/drm/msm/hdmi/hdmi.c > > +++ b/drivers/gpu/drm/msm/hdmi/hdmi.c > > @@ -549,6 +549,7 @@ static void msm_hdmi_dev_remove(struct platform_device *pdev) > > } > > > > static const struct of_device_id msm_hdmi_dt_match[] = { > > + { .compatible = "qcom,hdmi-tx-8998", .data = &hdmi_tx_8974_config }, > > { .compatible = "qcom,hdmi-tx-8996", .data = &hdmi_tx_8974_config }, > > { .compatible = "qcom,hdmi-tx-8994", .data = &hdmi_tx_8974_config }, > > { .compatible = "qcom,hdmi-tx-8084", .data = &hdmi_tx_8974_config }, > > > > -- > > 2.34.1 > >
On Mon, 15 Jul 2024 at 18:28, Conor Dooley <conor@kernel.org> wrote: > > On Mon, Jul 15, 2024 at 04:26:12PM +0100, Conor Dooley wrote: > > On Mon, Jul 15, 2024 at 02:21:16PM +0200, Marc Gonzalez wrote: > > > Current driver already supports the msm8998 HDMI TX. > > > We just need to add the compatible string. > > > > Why is this required when the driver change suggests that this device is > > compatible with the existing 8974? > > (I know I reviewed the binding already, just noticing this which > suggests a fallback would be appropriate, despite the differing clocks > etc) Yes and no. All supported MMS HDMI controllers are backwards compatible at least back to msm8960. However as we were not using fallbacks before, does it really make sense to introduce them now? It's highly likely that there will be no new HDMI controllers (Qualcomm has stopped using them with MSM8998 at 2018). > > > > > > > > > Signed-off-by: Marc Gonzalez <mgonzalez@freebox.fr> > > > --- > > > drivers/gpu/drm/msm/hdmi/hdmi.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/hdmi.c > > > index 24abcb7254cc4..0bfee41c2e71a 100644 > > > --- a/drivers/gpu/drm/msm/hdmi/hdmi.c > > > +++ b/drivers/gpu/drm/msm/hdmi/hdmi.c > > > @@ -549,6 +549,7 @@ static void msm_hdmi_dev_remove(struct platform_device *pdev) > > > } > > > > > > static const struct of_device_id msm_hdmi_dt_match[] = { > > > + { .compatible = "qcom,hdmi-tx-8998", .data = &hdmi_tx_8974_config }, > > > { .compatible = "qcom,hdmi-tx-8996", .data = &hdmi_tx_8974_config }, > > > { .compatible = "qcom,hdmi-tx-8994", .data = &hdmi_tx_8974_config }, > > > { .compatible = "qcom,hdmi-tx-8084", .data = &hdmi_tx_8974_config }, > > > > > > -- > > > 2.34.1 > > > > >
diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/hdmi.c index 24abcb7254cc4..0bfee41c2e71a 100644 --- a/drivers/gpu/drm/msm/hdmi/hdmi.c +++ b/drivers/gpu/drm/msm/hdmi/hdmi.c @@ -549,6 +549,7 @@ static void msm_hdmi_dev_remove(struct platform_device *pdev) } static const struct of_device_id msm_hdmi_dt_match[] = { + { .compatible = "qcom,hdmi-tx-8998", .data = &hdmi_tx_8974_config }, { .compatible = "qcom,hdmi-tx-8996", .data = &hdmi_tx_8974_config }, { .compatible = "qcom,hdmi-tx-8994", .data = &hdmi_tx_8974_config }, { .compatible = "qcom,hdmi-tx-8084", .data = &hdmi_tx_8974_config },
Current driver already supports the msm8998 HDMI TX. We just need to add the compatible string. Signed-off-by: Marc Gonzalez <mgonzalez@freebox.fr> --- drivers/gpu/drm/msm/hdmi/hdmi.c | 1 + 1 file changed, 1 insertion(+)