| Message ID | 20240913103755.7290-6-quic_mukhopad@quicinc.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add support for DisplayPort on SA8775P platform | expand |
On Fri, 13 Sept 2024 at 13:38, Soutrik Mukhopadhyay <quic_mukhopad@quicinc.com> wrote: > > The Qualcomm SA8775P platform comes with a DisplayPort controller > with a different base offset than the previous SoCs, > add support for this in the DisplayPort driver. > > Signed-off-by: Soutrik Mukhopadhyay <quic_mukhopad@quicinc.com> > --- > v2: No change > > --- > drivers/gpu/drm/msm/dp/dp_display.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c > index e1228fb093ee..e4954fd99eb0 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -118,6 +118,12 @@ struct msm_dp_desc { > bool wide_bus_supported; > }; > > +static const struct msm_dp_desc sa8775p_dp_descs[] = { > + { .io_start = 0xaf54000, .id = MSM_DP_CONTROLLER_0, .wide_bus_supported = true }, > + { .io_start = 0xaf5c000, .id = MSM_DP_CONTROLLER_1, .wide_bus_supported = true }, Please wait for the discussion to end before posting new iterations. In this case Bjorn pointed out that this is not the full configuration. Please add a comment, describing that there is a second MDSS, which isn't declared here as it wasn't validated. > + {} > +}; > + > static const struct msm_dp_desc sc7180_dp_descs[] = { > { .io_start = 0x0ae90000, .id = MSM_DP_CONTROLLER_0, .wide_bus_supported = true }, > {} > @@ -162,6 +168,7 @@ static const struct msm_dp_desc x1e80100_dp_descs[] = { > }; > > static const struct of_device_id dp_dt_match[] = { > + { .compatible = "qcom,sa8775p-dp", .data = &sa8775p_dp_descs }, > { .compatible = "qcom,sc7180-dp", .data = &sc7180_dp_descs }, > { .compatible = "qcom,sc7280-dp", .data = &sc7280_dp_descs }, > { .compatible = "qcom,sc7280-edp", .data = &sc7280_dp_descs }, > -- > 2.17.1 >
diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index e1228fb093ee..e4954fd99eb0 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -118,6 +118,12 @@ struct msm_dp_desc { bool wide_bus_supported; }; +static const struct msm_dp_desc sa8775p_dp_descs[] = { + { .io_start = 0xaf54000, .id = MSM_DP_CONTROLLER_0, .wide_bus_supported = true }, + { .io_start = 0xaf5c000, .id = MSM_DP_CONTROLLER_1, .wide_bus_supported = true }, + {} +}; + static const struct msm_dp_desc sc7180_dp_descs[] = { { .io_start = 0x0ae90000, .id = MSM_DP_CONTROLLER_0, .wide_bus_supported = true }, {} @@ -162,6 +168,7 @@ static const struct msm_dp_desc x1e80100_dp_descs[] = { }; static const struct of_device_id dp_dt_match[] = { + { .compatible = "qcom,sa8775p-dp", .data = &sa8775p_dp_descs }, { .compatible = "qcom,sc7180-dp", .data = &sc7180_dp_descs }, { .compatible = "qcom,sc7280-dp", .data = &sc7280_dp_descs }, { .compatible = "qcom,sc7280-edp", .data = &sc7280_dp_descs },
The Qualcomm SA8775P platform comes with a DisplayPort controller with a different base offset than the previous SoCs, add support for this in the DisplayPort driver. Signed-off-by: Soutrik Mukhopadhyay <quic_mukhopad@quicinc.com> --- v2: No change --- drivers/gpu/drm/msm/dp/dp_display.c | 7 +++++++ 1 file changed, 7 insertions(+)