| Message ID | 20241020165102.340838-2-aford173@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/3] phy: freescale: fsl-samsung-hdmi: Expand Integer divider range | expand |
On 20.10.24 6:50 PM, Adam Ford wrote: > There are a series of for-loops which check various values of P and S > for the integer divder PLL. The for loops search all entries and use > the one closest to the nominal, but it continues to searches through > all for loops even after the nominal is achieved. Ending when the > nominal value is found stops wasting time, since it will not find > a better value than a deviation of 0 Hz. > > Signed-off-by: Adam Ford <aford173@gmail.com> Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de> > --- > drivers/phy/freescale/phy-fsl-samsung-hdmi.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/phy/freescale/phy-fsl-samsung-hdmi.c b/drivers/phy/freescale/phy-fsl-samsung-hdmi.c > index 3f9578f3f0ac..719f8972cb5a 100644 > --- a/drivers/phy/freescale/phy-fsl-samsung-hdmi.c > +++ b/drivers/phy/freescale/phy-fsl-samsung-hdmi.c > @@ -440,9 +440,13 @@ static unsigned long fsl_samsung_hdmi_phy_find_pms(unsigned long fout, u8 *p, u1 > min_delta = delta; > best_freq = tmp; > } > + > + /* If we have an exact match, stop looking for a better value */ > + if (!delta) > + goto done; > } > } > - > +done: > if (best_freq) { > *p = best_p; > *m = best_m;
diff --git a/drivers/phy/freescale/phy-fsl-samsung-hdmi.c b/drivers/phy/freescale/phy-fsl-samsung-hdmi.c index 3f9578f3f0ac..719f8972cb5a 100644 --- a/drivers/phy/freescale/phy-fsl-samsung-hdmi.c +++ b/drivers/phy/freescale/phy-fsl-samsung-hdmi.c @@ -440,9 +440,13 @@ static unsigned long fsl_samsung_hdmi_phy_find_pms(unsigned long fout, u8 *p, u1 min_delta = delta; best_freq = tmp; } + + /* If we have an exact match, stop looking for a better value */ + if (!delta) + goto done; } } - +done: if (best_freq) { *p = best_p; *m = best_m;
There are a series of for-loops which check various values of P and S for the integer divder PLL. The for loops search all entries and use the one closest to the nominal, but it continues to searches through all for loops even after the nominal is achieved. Ending when the nominal value is found stops wasting time, since it will not find a better value than a deviation of 0 Hz. Signed-off-by: Adam Ford <aford173@gmail.com> --- drivers/phy/freescale/phy-fsl-samsung-hdmi.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)