| Message ID | 20241031070232.1793078-4-masterr3c0rd@epochal.quest |
|---|---|
| State | New |
| Headers | show |
| Series | sunxi: A100/A133 second stage support | expand |
On Thu, 31 Oct 2024 04:02:16 -0300 Cody Eksal <masterr3c0rd@epochal.quest> wrote: > The USB PHY found in the A100 is similar to that found in the D1. Add a > compatible for the A100. > > Signed-off-by: Cody Eksal <masterr3c0rd@epochal.quest> Reviewed-by: Andre Przywara <andre.przywara@arm.com> > Acked-by: Rob Herring (Arm) <robh@kernel.org> Careful with that: you made quite some changes compared to v1, which Rob ACKed, so I wouldn't carry over his tag here. Cheers, Andre > --- > Changes in V2: > - Update binding to allow using the D1 as a compatible. > > .../bindings/phy/allwinner,sun50i-a64-usb-phy.yaml | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/phy/allwinner,sun50i-a64-usb-phy.yaml b/Documentation/devicetree/bindings/phy/allwinner,sun50i-a64-usb-phy.yaml > index f557feca9763..21209126ed00 100644 > --- a/Documentation/devicetree/bindings/phy/allwinner,sun50i-a64-usb-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/allwinner,sun50i-a64-usb-phy.yaml > @@ -15,9 +15,13 @@ properties: > const: 1 > > compatible: > - enum: > - - allwinner,sun20i-d1-usb-phy > - - allwinner,sun50i-a64-usb-phy > + oneOf: > + - enum: > + - allwinner,sun20i-d1-usb-phy > + - allwinner,sun50i-a64-usb-phy > + - items: > + - const: allwinner,sun50i-a100-usb-phy > + - const: allwinner,sun20i-d1-usb-phy > > reg: > items:
On 2024/10/31 8:36 am, Andre Przywara wrote: > On Thu, 31 Oct 2024 04:02:16 -0300 > Cody Eksal <masterr3c0rd@epochal.quest> wrote: > >> The USB PHY found in the A100 is similar to that found in the D1. Add >> a >> compatible for the A100. >> >> Signed-off-by: Cody Eksal <masterr3c0rd@epochal.quest> > > Reviewed-by: Andre Przywara <andre.przywara@arm.com> > >> Acked-by: Rob Herring (Arm) <robh@kernel.org> > > Careful with that: you made quite some changes compared to v1, which > Rob > ACKed, so I wouldn't carry over his tag here. I had made a note of this a few days ago, but it slipped through my pre-submission review. I'm terribly sorry; won't make this mistake in the future. - Cody > Cheers, > Andre > >> --- >> Changes in V2: >> - Update binding to allow using the D1 as a compatible. >> >> .../bindings/phy/allwinner,sun50i-a64-usb-phy.yaml | 10 >> +++++++--- >> 1 file changed, 7 insertions(+), 3 deletions(-) >> >> diff --git >> a/Documentation/devicetree/bindings/phy/allwinner,sun50i-a64-usb-phy.yaml >> b/Documentation/devicetree/bindings/phy/allwinner,sun50i-a64-usb-phy.yaml >> index f557feca9763..21209126ed00 100644 >> --- >> a/Documentation/devicetree/bindings/phy/allwinner,sun50i-a64-usb-phy.yaml >> +++ >> b/Documentation/devicetree/bindings/phy/allwinner,sun50i-a64-usb-phy.yaml >> @@ -15,9 +15,13 @@ properties: >> const: 1 >> >> compatible: >> - enum: >> - - allwinner,sun20i-d1-usb-phy >> - - allwinner,sun50i-a64-usb-phy >> + oneOf: >> + - enum: >> + - allwinner,sun20i-d1-usb-phy >> + - allwinner,sun50i-a64-usb-phy >> + - items: >> + - const: allwinner,sun50i-a100-usb-phy >> + - const: allwinner,sun20i-d1-usb-phy >> >> reg: >> items:
diff --git a/Documentation/devicetree/bindings/phy/allwinner,sun50i-a64-usb-phy.yaml b/Documentation/devicetree/bindings/phy/allwinner,sun50i-a64-usb-phy.yaml index f557feca9763..21209126ed00 100644 --- a/Documentation/devicetree/bindings/phy/allwinner,sun50i-a64-usb-phy.yaml +++ b/Documentation/devicetree/bindings/phy/allwinner,sun50i-a64-usb-phy.yaml @@ -15,9 +15,13 @@ properties: const: 1 compatible: - enum: - - allwinner,sun20i-d1-usb-phy - - allwinner,sun50i-a64-usb-phy + oneOf: + - enum: + - allwinner,sun20i-d1-usb-phy + - allwinner,sun50i-a64-usb-phy + - items: + - const: allwinner,sun50i-a100-usb-phy + - const: allwinner,sun20i-d1-usb-phy reg: items: