| Message ID | 20250122065249.1390081-1-arnd@kernel.org |
|---|---|
| State | Accepted |
| Commit | ca996321d32a732ee12e7af8ccd0c84bf885fd6f |
| Headers | show |
| Series | phy: rockchip: fix Kconfig dependency more | expand |
Hi, On Wed, Jan 22, 2025 at 07:52:44AM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > A previous patch ensured that USB Type C connector support is enabled, > but it is still possible to build the phy driver without enabling > CONFIG_USB (host support) or CONFIG_USB_GADGET (device support), and > in that case the common helper functions are unavailable: > > aarch64-linux-ld: drivers/phy/rockchip/phy-rockchip-usbdp.o: in function `rk_udphy_probe': > phy-rockchip-usbdp.c:(.text+0xe74): undefined reference to `usb_get_maximum_speed' > > Select CONFIG_USB_COMMON directly here, like we do in some other phy > drivers, to make sure this is available even when actual USB support > is disabled or in a loadable module that cannot be reached from a > built-in phy driver. > > Fixes: 9c79b779643e ("phy: rockchip: fix CONFIG_TYPEC dependency") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com> Thanks, -- Sebastian > drivers/phy/rockchip/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/phy/rockchip/Kconfig b/drivers/phy/rockchip/Kconfig > index 2f7a05f21dc5..dcb8e1628632 100644 > --- a/drivers/phy/rockchip/Kconfig > +++ b/drivers/phy/rockchip/Kconfig > @@ -125,6 +125,7 @@ config PHY_ROCKCHIP_USBDP > depends on ARCH_ROCKCHIP && OF > depends on TYPEC > select GENERIC_PHY > + select USB_COMMON > help > Enable this to support the Rockchip USB3.0/DP combo PHY with > Samsung IP block. This is required for USB3 support on RK3588. > -- > 2.39.5 > >
Am Mittwoch, 22. Januar 2025, 07:52:44 MEZ schrieb Arnd Bergmann: > From: Arnd Bergmann <arnd@arndb.de> > > A previous patch ensured that USB Type C connector support is enabled, > but it is still possible to build the phy driver without enabling > CONFIG_USB (host support) or CONFIG_USB_GADGET (device support), and > in that case the common helper functions are unavailable: > > aarch64-linux-ld: drivers/phy/rockchip/phy-rockchip-usbdp.o: in function `rk_udphy_probe': > phy-rockchip-usbdp.c:(.text+0xe74): undefined reference to `usb_get_maximum_speed' > > Select CONFIG_USB_COMMON directly here, like we do in some other phy > drivers, to make sure this is available even when actual USB support > is disabled or in a loadable module that cannot be reached from a > built-in phy driver. > > Fixes: 9c79b779643e ("phy: rockchip: fix CONFIG_TYPEC dependency") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Heiko Stuebner <heiko@sntech.de> @Vinod, I guess this should go into 6.14-rc? Thanks Heiko > --- > drivers/phy/rockchip/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/phy/rockchip/Kconfig b/drivers/phy/rockchip/Kconfig > index 2f7a05f21dc5..dcb8e1628632 100644 > --- a/drivers/phy/rockchip/Kconfig > +++ b/drivers/phy/rockchip/Kconfig > @@ -125,6 +125,7 @@ config PHY_ROCKCHIP_USBDP > depends on ARCH_ROCKCHIP && OF > depends on TYPEC > select GENERIC_PHY > + select USB_COMMON > help > Enable this to support the Rockchip USB3.0/DP combo PHY with > Samsung IP block. This is required for USB3 support on RK3588. >
On Wed, 22 Jan 2025 07:52:44 +0100, Arnd Bergmann wrote: > A previous patch ensured that USB Type C connector support is enabled, > but it is still possible to build the phy driver without enabling > CONFIG_USB (host support) or CONFIG_USB_GADGET (device support), and > in that case the common helper functions are unavailable: > > aarch64-linux-ld: drivers/phy/rockchip/phy-rockchip-usbdp.o: in function `rk_udphy_probe': > phy-rockchip-usbdp.c:(.text+0xe74): undefined reference to `usb_get_maximum_speed' > > [...] Applied, thanks! [1/1] phy: rockchip: fix Kconfig dependency more commit: ca996321d32a732ee12e7af8ccd0c84bf885fd6f Best regards,
diff --git a/drivers/phy/rockchip/Kconfig b/drivers/phy/rockchip/Kconfig index 2f7a05f21dc5..dcb8e1628632 100644 --- a/drivers/phy/rockchip/Kconfig +++ b/drivers/phy/rockchip/Kconfig @@ -125,6 +125,7 @@ config PHY_ROCKCHIP_USBDP depends on ARCH_ROCKCHIP && OF depends on TYPEC select GENERIC_PHY + select USB_COMMON help Enable this to support the Rockchip USB3.0/DP combo PHY with Samsung IP block. This is required for USB3 support on RK3588.