| Message ID | 20250131-8qxp_camera-v1-1-319402ab606a@nxp.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | media: imx8: add camera support | expand |
On Fri, Jan 31, 2025 at 04:33:46PM -0500, Frank Li wrote: > Add MIPI CSI phy binding doc for i.MX8QXP, i.MX8QM and i.MX8ULP. > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > .../bindings/phy/fsl,imx8qxp-mipi-cphy.yaml | 53 ++++++++++++++++++++++ > 1 file changed, 53 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/fsl,imx8qxp-mipi-cphy.yaml b/Documentation/devicetree/bindings/phy/fsl,imx8qxp-mipi-cphy.yaml > new file mode 100644 > index 0000000000000..c6cbedd9ed114 > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/fsl,imx8qxp-mipi-cphy.yaml > @@ -0,0 +1,53 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/phy/fsl,imx8qxp-mipi-cphy.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Freescale i.MX8 SoC MIPI CSI PHY > + > +maintainers: > + - Frank Li <Frank.Li@nxp.com> > + > +properties: > + "#phy-cells": > + const: 0 > + > + compatible: > + enum: > + - fsl,imx8qxp-mipi-cphy > + - fsl,imx8ulp-mipi-cphy Where's imx8qm? > + > + reg: > + maxItems: 1 > + > + power-domains: > + maxItems: 1 > + > +required: > + - "#phy-cells" > + - compatible > + > +allOf: > + - if: > + properties: > + compatible: > + contains: > + enum: > + - fsl,imx8qxp-mipi-cphy > + then: > + required: > + - reg How is the device accessed with no registers? > + - power-domains > + > +additionalProperties: false > + > +examples: > + - | > + phy@58221000 { > + compatible = "fsl,imx8qxp-mipi-cphy"; > + reg = <0x58221000 0x10000>; > + #phy-cells = <0>; > + power-domains = <&pd 0>; > + }; > + > > -- > 2.34.1 >
On Mon, Feb 03, 2025 at 04:02:30PM -0600, Rob Herring wrote: > On Fri, Jan 31, 2025 at 04:33:46PM -0500, Frank Li wrote: > > Add MIPI CSI phy binding doc for i.MX8QXP, i.MX8QM and i.MX8ULP. > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > --- > > .../bindings/phy/fsl,imx8qxp-mipi-cphy.yaml | 53 ++++++++++++++++++++++ > > 1 file changed, 53 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/phy/fsl,imx8qxp-mipi-cphy.yaml b/Documentation/devicetree/bindings/phy/fsl,imx8qxp-mipi-cphy.yaml > > new file mode 100644 > > index 0000000000000..c6cbedd9ed114 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/phy/fsl,imx8qxp-mipi-cphy.yaml > > @@ -0,0 +1,53 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/phy/fsl,imx8qxp-mipi-cphy.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Freescale i.MX8 SoC MIPI CSI PHY > > + > > +maintainers: > > + - Frank Li <Frank.Li@nxp.com> > > + > > +properties: > > + "#phy-cells": > > + const: 0 > > + > > + compatible: > > + enum: > > + - fsl,imx8qxp-mipi-cphy > > + - fsl,imx8ulp-mipi-cphy > > Where's imx8qm? Sorry, missed. dts use fsl,imx8qxp-mipi-cphy at 8qm, so I have not found it by DTB_CHECK. > > > + > > + reg: > > + maxItems: 1 > > + > > + power-domains: > > + maxItems: 1 > > + > > +required: > > + - "#phy-cells" > > + - compatible > > + > > +allOf: > > + - if: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - fsl,imx8qxp-mipi-cphy > > + then: > > + required: > > + - reg > > How is the device accessed with no registers? 8ulp boudle other function's register. csr_regs: csr@2dad0000 { compatible = "8upl-csr", "syscon", "simple-mfd"; reg = <0x2dad0000 0x10000>; clocks = <&pcc5 IMX8ULP_CLK_CSI_REGS>; csr_regs_rst: reset-controller { compatible = "nxp,imx8ulp-csr-regs-reset"; ... }; mipi-phy { compatible = "fsl,imx8ulp-mipi-cphy"; ... }; }; I have not 8ulp to do test now and this serial are already quite big. I plan update later. Just put a fsl,imx8ulp-mipi-cphy here, because it is quite similar with fsl,imx8qxp-mipi-cphy Frank > > > + - power-domains > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + phy@58221000 { > > + compatible = "fsl,imx8qxp-mipi-cphy"; > > + reg = <0x58221000 0x10000>; > > + #phy-cells = <0>; > > + power-domains = <&pd 0>; > > + }; > > + > > > > -- > > 2.34.1 > >
diff --git a/Documentation/devicetree/bindings/phy/fsl,imx8qxp-mipi-cphy.yaml b/Documentation/devicetree/bindings/phy/fsl,imx8qxp-mipi-cphy.yaml new file mode 100644 index 0000000000000..c6cbedd9ed114 --- /dev/null +++ b/Documentation/devicetree/bindings/phy/fsl,imx8qxp-mipi-cphy.yaml @@ -0,0 +1,53 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/phy/fsl,imx8qxp-mipi-cphy.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Freescale i.MX8 SoC MIPI CSI PHY + +maintainers: + - Frank Li <Frank.Li@nxp.com> + +properties: + "#phy-cells": + const: 0 + + compatible: + enum: + - fsl,imx8qxp-mipi-cphy + - fsl,imx8ulp-mipi-cphy + + reg: + maxItems: 1 + + power-domains: + maxItems: 1 + +required: + - "#phy-cells" + - compatible + +allOf: + - if: + properties: + compatible: + contains: + enum: + - fsl,imx8qxp-mipi-cphy + then: + required: + - reg + - power-domains + +additionalProperties: false + +examples: + - | + phy@58221000 { + compatible = "fsl,imx8qxp-mipi-cphy"; + reg = <0x58221000 0x10000>; + #phy-cells = <0>; + power-domains = <&pd 0>; + }; +
Add MIPI CSI phy binding doc for i.MX8QXP, i.MX8QM and i.MX8ULP. Signed-off-by: Frank Li <Frank.Li@nxp.com> --- .../bindings/phy/fsl,imx8qxp-mipi-cphy.yaml | 53 ++++++++++++++++++++++ 1 file changed, 53 insertions(+)