| Message ID | 20250309132959.19045-7-ansuelsmth@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | airoha: en7581: clk cleanup + USB support | expand |
On Sun, Mar 09, 2025 at 02:29:37PM +0100, Christian Marangi wrote: > The Airoha EN7581 clock-controller registers are placed in the SCU I don't understand. The registers moved? > (System Controller Unit). Now that additional pheriperals are supported > for the SCU, a dedicated SCU node is created and the clock-controller is > moved as a child of such node hence the register property is taken from > the parent node. > > To support this, make the reg property optional and provide an > additional example for this case. No, post complete binding instead of adding some sort of stubs and then later totally reworking them to match different Linux drivers. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml index fe2c5c1baf43..84e6c3d43868 100644 --- a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml +++ b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml @@ -51,7 +51,6 @@ properties: required: - compatible - - reg - '#clock-cells' allOf: @@ -66,6 +65,9 @@ allOf: '#reset-cells': false + required: + - reg + - if: properties: compatible: @@ -99,3 +101,12 @@ examples: #reset-cells = <1>; }; }; + + # Example with clock-controller in SCU MFD + - | + clock-controller { + compatible = "airoha,en7581-scu"; + + #clock-cells = <1>; + #reset-cells = <1>; + };
The Airoha EN7581 clock-controller registers are placed in the SCU (System Controller Unit). Now that additional pheriperals are supported for the SCU, a dedicated SCU node is created and the clock-controller is moved as a child of such node hence the register property is taken from the parent node. To support this, make the reg property optional and provide an additional example for this case. Driver supports both old and new implementation by checking the presence of the reg property and parsing the register accordingly. Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> --- .../bindings/clock/airoha,en7523-scu.yaml | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-)