| Message ID | 20250310063103.3924525-5-quic_ziyuzhan@quicinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | pci: qcom: Add QCS8300 PCIe support | expand |
On Mon, Mar 10, 2025 at 02:30:59PM +0800, Ziyue Zhang wrote: > Add support for QCS8300 SoC that uses controller version 5.90 so reusing > the 1.34.0 config. This is not a valid argument. You should mention that the controller is of version <Qcom IP version>, but compatible with version 1.34.0 controllers and hence reusing that ops. 5.90 is the synopsys IP version, not Qcom one. You should mention both. > Please add more info about the controller like link speed, max lane count, etc... Moreover, cfg_1_34_0 has the 'override_no_snoop' bit set to override read/write no snoop attributes. Are they applicable to this controller also? - Mani
diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c index e4d3366ead1f..7d917ab0b13f 100644 --- a/drivers/pci/controller/dwc/pcie-qcom.c +++ b/drivers/pci/controller/dwc/pcie-qcom.c @@ -1848,6 +1848,7 @@ static const struct of_device_id qcom_pcie_match[] = { { .compatible = "qcom,pcie-ipq9574", .data = &cfg_2_9_0 }, { .compatible = "qcom,pcie-msm8996", .data = &cfg_2_3_2 }, { .compatible = "qcom,pcie-qcs404", .data = &cfg_2_4_0 }, + { .compatible = "qcom,pcie-qcs8300", .data = &cfg_1_34_0 }, { .compatible = "qcom,pcie-sa8540p", .data = &cfg_sc8280xp }, { .compatible = "qcom,pcie-sa8775p", .data = &cfg_1_34_0}, { .compatible = "qcom,pcie-sc7280", .data = &cfg_1_9_0 },
Add support for QCS8300 SoC that uses controller version 5.90 so reusing the 1.34.0 config. Signed-off-by: Ziyue Zhang <quic_ziyuzhan@quicinc.com> --- drivers/pci/controller/dwc/pcie-qcom.c | 1 + 1 file changed, 1 insertion(+)