| Message ID | 20250321135854.1431375-7-ivo.ivanov.ivanov1@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | phy: samsung: add Exynos2200 SNPS eUSB2 driver | expand |
On Fri, Mar 21, 2025 at 03:58:50PM +0200, Ivaylo Ivanov wrote: > As described in the device tree bindings, it's not necessary for the > SNPS eUSB2 phy to be connected to a repeater. In configurations where > there are such instances, the driver probing fails and the usb > controller does not work. > > Make the repeater optional to avoid that, which also lets us use > the eUSB2 phy when it's connected to a repeater that is not configurable > by the kernel (for example it's missing a driver), as long as it has > been configured beforehand (usually by the bootloader). > > Signed-off-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com> > Acked-by: Neil Armstrong <neil.armstrong@linaro.org> > --- > drivers/phy/phy-snps-eusb2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
diff --git a/drivers/phy/phy-snps-eusb2.c b/drivers/phy/phy-snps-eusb2.c index fa878389f..8ccd432a0 100644 --- a/drivers/phy/phy-snps-eusb2.c +++ b/drivers/phy/phy-snps-eusb2.c @@ -428,7 +428,7 @@ static int snps_eusb2_hsphy_probe(struct platform_device *pdev) return dev_err_probe(dev, ret, "failed to get regulator supplies\n"); - phy->repeater = devm_of_phy_get_by_index(dev, np, 0); + phy->repeater = devm_of_phy_optional_get(dev, np, 0); if (IS_ERR(phy->repeater)) return dev_err_probe(dev, PTR_ERR(phy->repeater), "failed to get repeater\n");