| Message ID | 20250414-revert_hs_phy_settings-v2-2-25086e20a3a3@oss.qualcomm.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Reuse the IPQ6018 QUSB2 PHY settings for IPQ5424 | expand |
On 4/14/2025 5:22 PM, Kathiravan Thirumoorthy wrote: > With the settings used in the commit 9c56a1de296e ("phy: qcom-qusb2: add > QUSB2 support for IPQ5424"), complaince test cases especially compliance > eye-diagram (Host High-speed Signal Quality) tests are failing. > > Reuse the IPQ6018 settings for IPQ5424 as suggested by design team, No mention of team. Write it as generic. > which helps to meet all the complaince requirement test cases. compliance > > Fixes: 9c56a1de296e ("phy: qcom-qusb2: add QUSB2 support for IPQ5424") > Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com> > --- > drivers/phy/qualcomm/phy-qcom-qusb2.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/phy/qualcomm/phy-qcom-qusb2.c b/drivers/phy/qualcomm/phy-qcom-qusb2.c > index 81b9e9349c3ebb4d303cb040b5c913336bb6b6d6..49c37c53b38e70db2a1591081a1a12db7092555d 100644 > --- a/drivers/phy/qualcomm/phy-qcom-qusb2.c > +++ b/drivers/phy/qualcomm/phy-qcom-qusb2.c > @@ -929,6 +929,9 @@ static const struct phy_ops qusb2_phy_gen_ops = { > > static const struct of_device_id qusb2_phy_of_match_table[] = { > { > + .compatible = "qcom,ipq5424-qusb2-phy", > + .data = &ipq6018_phy_cfg, > + }, { > .compatible = "qcom,ipq6018-qusb2-phy", > .data = &ipq6018_phy_cfg, > }, { >
diff --git a/drivers/phy/qualcomm/phy-qcom-qusb2.c b/drivers/phy/qualcomm/phy-qcom-qusb2.c index 81b9e9349c3ebb4d303cb040b5c913336bb6b6d6..49c37c53b38e70db2a1591081a1a12db7092555d 100644 --- a/drivers/phy/qualcomm/phy-qcom-qusb2.c +++ b/drivers/phy/qualcomm/phy-qcom-qusb2.c @@ -929,6 +929,9 @@ static const struct phy_ops qusb2_phy_gen_ops = { static const struct of_device_id qusb2_phy_of_match_table[] = { { + .compatible = "qcom,ipq5424-qusb2-phy", + .data = &ipq6018_phy_cfg, + }, { .compatible = "qcom,ipq6018-qusb2-phy", .data = &ipq6018_phy_cfg, }, {
With the settings used in the commit 9c56a1de296e ("phy: qcom-qusb2: add QUSB2 support for IPQ5424"), complaince test cases especially eye-diagram (Host High-speed Signal Quality) tests are failing. Reuse the IPQ6018 settings for IPQ5424 as suggested by design team, which helps to meet all the complaince requirement test cases. Fixes: 9c56a1de296e ("phy: qcom-qusb2: add QUSB2 support for IPQ5424") Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com> --- drivers/phy/qualcomm/phy-qcom-qusb2.c | 3 +++ 1 file changed, 3 insertions(+)