diff mbox series

phy: qcom-qmp: Fix an error handling path in 'qcom_qmp_phy_power_on()'

Message ID 3c641172c5b57dce56872d63c52dfae2645cc2d1.1624795081.git.christophe.jaillet@wanadoo.fr
State Accepted
Headers show
Series phy: qcom-qmp: Fix an error handling path in 'qcom_qmp_phy_power_on()' | expand

Commit Message

Christophe JAILLET June 27, 2021, 11:59 a.m. UTC
If an error occurs after a successful 'clk_prepare_enable()' call, it must
be undone by a 'clk_disable_unprepare()' call, as already done in another
error handling path of this function.

Update the 'goto' to branch at the correct place of the error handling
path.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
/!\ This patch is speculative /!\
Review with care.

I've not been able to identify a Fixes tag.
---
 drivers/phy/qualcomm/phy-qcom-qmp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c
index cfe359488f5c..25006d80d347 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp.c
@@ -4504,7 +4504,7 @@  static int qcom_qmp_phy_power_on(struct phy *phy)
 
 	ret = reset_control_deassert(qmp->ufs_reset);
 	if (ret)
-		goto err_lane_rst;
+		goto err_pcs_ready;
 
 	qcom_qmp_phy_configure(pcs_misc, cfg->regs, cfg->pcs_misc_tbl,
 			       cfg->pcs_misc_tbl_num);