From patchwork Tue Jul 11 06:13:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 13308160 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 61EC5C001DE for ; Tue, 11 Jul 2023 06:13:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=b3Smd9VKQjozGLaRAwI6gtEZ7V3mocs3/IGUVlektt8=; b=ENv5SqlzT9zLpt 6YyyBBlm2qwchWaxLZnJCn2Fyco+rrXGBUh8PYdbFK+UjBEdasuSVs+8vV+49Fgji1V17BHL6tUh3 OXVxsIRjK35ov8YJ0lsLtofiOwaENShEl4orZ+SMhqa1XPvp7XA6vbkFVkFTcxGb0md7Nx+YJR4Pe rzLtJYMyVWrTt3X5tyifZ06xdu8pIjCxrkm/OoGcJxV/60kQEi1yjpVvCeHKqEajIQRys/4TcFK4s 0joc+7B2P2KyDgLND2EgnggG/nm3CWK+U7P0brrzIp2Qf59KsIyOw6DhA2AJwljzZlPJMXhaUOgUL /kqpo/4rM8v2Je3HVYHw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qJ6cx-00DqMu-07; Tue, 11 Jul 2023 06:13:35 +0000 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qJ6cu-00DqLZ-36 for linux-phy@lists.infradead.org; Tue, 11 Jul 2023 06:13:34 +0000 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-3fbc1218262so60532885e9.3 for ; Mon, 10 Jul 2023 23:13:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689056010; x=1691648010; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=o42Ks/tCHx59zpvkkxrFyhauoCCL1U7JUVEYu4RWWvs=; b=z8inQ+8MaqEzGKghYbTWt23tvZEQzsRbXLm7xauCjIH2NLhP0I3qVQSwTtGjwyLvrm xQ9bT7gT7LcA1bLwQyLOak1ybj9Z/QkM6HMKkFyNAMBBIsL1fREXvXYtH2IOmjZ62s7f 8P4NpAkj5Kc/JR4uiF3A+d/Z+g+wB3ZXIvdO6nT1E99yHbQHEYY4Asd5fvJQU1gLvms0 2Z/xX5af6r/vsvasoFMoVNK/G67xCRmzopDm0hePRoy1kwrYSPNwo9UQnM7bW33Vs5oX sp+8ChSIMKNfefGBojcBp+GNNAsEiGQ0YSduEIp+bWDc3VEBdsJ4C+KUSMlnPzRS0RBs LpbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689056010; x=1691648010; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=o42Ks/tCHx59zpvkkxrFyhauoCCL1U7JUVEYu4RWWvs=; b=LEqsrFlr3Gx/Mt+s5fo4nNjaM2UlN0D3KV2KtQcqcIHjYdCJ2ALYEF94DgMcI0zFbC 265nBAE2DZ99fqule+tYutnSxEZXzRKXDlUtPOmGgqii2EfVMRmYbde6y6wGigw0LcQE n/oFq6fP7KSCaHvfOje368UVwX5lKS7nhv5WgxhIT5pUSPx1AuN1kXwETsFjk5/M/BcA OadUM9ejiojx1iU6aZ+W40t9OD9zK4qT7bgL7A9dEnov+i40AFmqS+0Bw9f5IV5X/H1d l10ur6/xrIhq/IjYw8C/PpK4vlJrCWe6EZi/40gMNZ5GMrdo2cQHJPknktHPlXkN58ms z/9w== X-Gm-Message-State: ABy/qLZDATwg3hcizHYKO4VGr9IDXnRWYZyDYgbbe1mhN7vlz43cFHOI a7Bk8E+ER3yrxPk2LxuOZmnfEw== X-Google-Smtp-Source: APBJJlHE2lKKPaUynutVNkXNfVhKn5DdgxT7YI1AidUkNO+4JOc3NtprI1IvH5G5uV7tFh1/jMariQ== X-Received: by 2002:a05:600c:c8:b0:3fa:95c7:e891 with SMTP id u8-20020a05600c00c800b003fa95c7e891mr16791835wmm.35.1689056010209; Mon, 10 Jul 2023 23:13:30 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id 11-20020a05600c230b00b003fbaade0735sm11944239wmo.19.2023.07.10.23.13.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jul 2023 23:13:29 -0700 (PDT) Date: Tue, 11 Jul 2023 09:13:25 +0300 From: Dan Carpenter To: Markus Schneider-Pargmann Cc: Chun-Kuang Hu , Philipp Zabel , Chunfeng Yun , Vinod Koul , Kishon Vijay Abraham I , Matthias Brugger , AngeloGioacchino Del Regno , Bo-Chen Chen , Guillaume Ranquet , dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, kernel-janitors@vger.kernel.org Subject: [PATCH] phy: phy-mtk-dp: Fix an error code in probe() Message-ID: <3c699e00-2883-40d9-92c3-0da1dc38fdd4@moroto.mountain> MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230710_231332_996724_4C20DC32 X-CRM114-Status: GOOD ( 11.14 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Negative -EINVAL was intended instead of positive EINVAL. Fixes: 6a23afad443a ("phy: phy-mtk-dp: Add driver for DP phy") Signed-off-by: Dan Carpenter Reviewed-by: Chen-Yu Tsai Reviewed-by: AngeloGioacchino Del Regno --- drivers/phy/mediatek/phy-mtk-dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/mediatek/phy-mtk-dp.c b/drivers/phy/mediatek/phy-mtk-dp.c index 232fd3f1ff1b..d7024a144335 100644 --- a/drivers/phy/mediatek/phy-mtk-dp.c +++ b/drivers/phy/mediatek/phy-mtk-dp.c @@ -169,7 +169,7 @@ static int mtk_dp_phy_probe(struct platform_device *pdev) regs = *(struct regmap **)dev->platform_data; if (!regs) - return dev_err_probe(dev, EINVAL, + return dev_err_probe(dev, -EINVAL, "No data passed, requires struct regmap**\n"); dp_phy = devm_kzalloc(dev, sizeof(*dp_phy), GFP_KERNEL);