| Message ID | 84393e59efa7a76b89d4164fd64ca85b8739f6ee.1737118595.git.geert+renesas@glider.be |
|---|---|
| State | Superseded |
| Headers | show |
| Series | LAN966x PCIe endpoint cleanups | expand |
Hi Geert, On Fri, 17 Jan 2025 14:04:37 +0100 Geert Uytterhoeven <geert+renesas@glider.be> wrote: > The Microchip LAN966x outband interrupt controller is only present on > Microchip LAN966x SoCs, and only used in PCI endpoint mode. Hence add a > dependency on MCHP_LAN966X_PCI, to prevent asking the user about this > driver when configuring a kernel without Microchip LAN966x PCIe support. > > Fixes: 3e3a7b35332924c8 ("irqchip: Add support for LAN966x OIC") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > v2: > - Drop dependency on SOC_LAN966, as the OIC is used only in LAN966x > PCI endpoint mode, > - Replace MFD_LAN966X_PCI by MCHP_LAN966X_PCI, as the latter is the > symbol that ended upstream. > --- > drivers/irqchip/Kconfig | 1 + > 1 file changed, 1 insertion(+) > Thanks for this patch! Acked-by: Herve Codina <herve.codina@bootlin.com> Best regards, Hervé
On Fri, 17 Jan 2025 at 14:04, Geert Uytterhoeven <geert+renesas@glider.be> wrote: > The Microchip LAN966x outband interrupt controller is only present on > Microchip LAN966x SoCs, and only used in PCI endpoint mode. Hence add a > dependency on MCHP_LAN966X_PCI, to prevent asking the user about this > driver when configuring a kernel without Microchip LAN966x PCIe support. > > Fixes: 3e3a7b35332924c8 ("irqchip: Add support for LAN966x OIC") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > v2: > - Drop dependency on SOC_LAN966, as the OIC is used only in LAN966x > PCI endpoint mode, > - Replace MFD_LAN966X_PCI by MCHP_LAN966X_PCI, as the latter is the > symbol that ended upstream. Bummer, I messed up the subject here as well... Gr{oetje,eeting}s, Geert
diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig index 22f5fbd41f65d97e..cf713b6e9cc9346f 100644 --- a/drivers/irqchip/Kconfig +++ b/drivers/irqchip/Kconfig @@ -169,6 +169,7 @@ config IXP4XX_IRQ config LAN966X_OIC tristate "Microchip LAN966x OIC Support" + depends on MCHP_LAN966X_PCI || COMPILE_TEST select GENERIC_IRQ_CHIP select IRQ_DOMAIN help
The Microchip LAN966x outband interrupt controller is only present on Microchip LAN966x SoCs, and only used in PCI endpoint mode. Hence add a dependency on MCHP_LAN966X_PCI, to prevent asking the user about this driver when configuring a kernel without Microchip LAN966x PCIe support. Fixes: 3e3a7b35332924c8 ("irqchip: Add support for LAN966x OIC") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- v2: - Drop dependency on SOC_LAN966, as the OIC is used only in LAN966x PCI endpoint mode, - Replace MFD_LAN966X_PCI by MCHP_LAN966X_PCI, as the latter is the symbol that ended upstream. --- drivers/irqchip/Kconfig | 1 + 1 file changed, 1 insertion(+)