From patchwork Fri Mar 14 05:56:40 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: George Moussalem X-Patchwork-Id: 14016248 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C4FDC28B2F for ; Fri, 14 Mar 2025 05:57:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oOdXUq+OExCkj207rME8SX6NSHHbukn0dBNYmIJ9XEQ=; b=E/yYx143p3q6HP FfbXS2gaaSUuGosiU7+wiDciaP4gVmXwZCpxp2xsxfk9rr4s4iPGnLE61EVA4CHT/9PtIKgV23kD+ UPyv22fkOP8pAy8VErL6jY4nhv0KxuWyG7W7TPrIjrxVbixXS2yiBlheK/704cfEp1v+mRiISrE9a 6g62nwtsT6FbpVBuppuUURvjNElhhbQ5k7aNR9ekeBTH2PBdUeZYlF2pQMH9mil68V7xrTJHMTD1A LOOqVpoSZ+BEM2dWW/rK7mmYTZvMeh+nxuqRJuQ7lqLCdJB6VHEyOH1k9GWaNMcxSlvSg0DgGaofn P0W5KrhlreZdux9h88DQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tsy2f-0000000D8qk-1aDL; Fri, 14 Mar 2025 05:57:09 +0000 Received: from mail-bn7nam10olkn2080b.outbound.protection.outlook.com ([2a01:111:f403:2804::80b] helo=NAM10-BN7-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tsy2d-0000000D8pi-0CVg for linux-phy@lists.infradead.org; Fri, 14 Mar 2025 05:57:08 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=f8xT/T69DmyUCNdagxhwg3LObnWg1u3aw7O+++ZjKWWUZKeLfLPHP7TNDIFc4g2HMRYCBvMtBrhhKdH8KeaPrU8EQrxqK3pC5N5SCl71cFsFKOboyfhO+fhLps+Hmm18J0i/DPvfYbc+yCLo/fN4cyFLTu7BxNG3alcrvTS8tc0TtkcU6gNmyWiwKs2Xt+Rzyhpm7Q4QaKClEvZcmpdFpjO92WzPPGmFdvcqkQLv8s7c/sM3trYhDdupNmv/dqzCpfgszR416xz9E/fH+Rg7weAKOJiRPMztiMvzMKwJdPBIKWglzKr5W8lXAMj1gGsCKCKha7pAikWkLnY40d+ksA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/rb4Fz2eLhjsOK8TaETEHiImaJpPwH1MFsiLK9uFQBY=; b=Z4ot7MksPvD34JlsyTlzqtb9eatsO0qFRGVq5/fqzj1zR2wGthP9M4/q4KGr1Y6Xpl9HVuPmHDxDC73YNx+Y9Q6uxqaG70PqzfNgigvSrWdMwF931Lc56ycmRf3Htuew8MGcGTy+fLgL2Imp3USnI/MmL2T1Mrsb+gx26fmEa4SODkM2d2sYx2SMLcQYsDkJnBPpGutMUFz15G07GCB7sHdQEWEqWkj1sOUKykP2jelrApix4uo0FsnYaY0zFatjMjecANLAnGkovyJEOpk5KSdNDLRuaArAQhclBhBROXw66+B1FsCVOkALDZZjqno6Nq3qyfidbEGSvapwMBdTiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/rb4Fz2eLhjsOK8TaETEHiImaJpPwH1MFsiLK9uFQBY=; b=XyJt5B2LS/xC+dLW3F97gRB1c37vro0bKQbDqaaJ8sXc+RwQ+F63Gk1EHDGOmQnyApgM4dnceX8rdXzGA2Ee7eyAhgVAqV4QiPLDRVWDzDFm9BLvd/sQPkrQYT+z7xw5lNzao1Rkq8kwwyv7zMtBjICNnXn4f+phfya0iT6WPxFnRdP0RPpIow7SuHpIs6VRfFQebddqgSCLeie974t8Zj+PCpXinAp7ydCySUBpvQCoZC3xgIf3zU3OvpeEerQqe0ljaMQuSZco97esf2Ex+Et6WacMl6jWU4Lk+a45sFWO+kIERX8gNoHb+ucS3BVC/nWftZzKq3ju2Gcga+UM+A== Received: from DS7PR19MB8883.namprd19.prod.outlook.com (2603:10b6:8:253::16) by SA3PR19MB7795.namprd19.prod.outlook.com (2603:10b6:806:300::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.27; Fri, 14 Mar 2025 05:57:01 +0000 Received: from DS7PR19MB8883.namprd19.prod.outlook.com ([fe80::e0c2:5b31:534:4305]) by DS7PR19MB8883.namprd19.prod.outlook.com ([fe80::e0c2:5b31:534:4305%6]) with mapi id 15.20.8534.027; Fri, 14 Mar 2025 05:57:01 +0000 From: George Moussalem To: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-phy@lists.infradead.org, andersson@kernel.org, bhelgaas@google.com, conor+dt@kernel.org, devicetree@vger.kernel.org, lumag@kernel.org, kishon@kernel.org, konradybcio@kernel.org, krzk+dt@kernel.org, kw@linux.com, lpieralisi@kernel.org, manivannan.sadhasivam@linaro.org, p.zabel@pengutronix.de, quic_nsekar@quicinc.com, robh@kernel.org, robimarko@gmail.com, vkoul@kernel.org, george.moussalem@outlook.com Cc: quic_srichara@quicinc.com Subject: [PATCH v4 2/6] phy: qualcomm: qcom-uniphy-pcie 28LP add support for IPQ5018 Date: Fri, 14 Mar 2025 09:56:40 +0400 Message-ID: X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250314055644.32705-1-george.moussalem@outlook.com> References: <20250314055644.32705-1-george.moussalem@outlook.com> X-ClientProxiedBy: FR5P281CA0004.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:f2::13) To DS7PR19MB8883.namprd19.prod.outlook.com (2603:10b6:8:253::16) X-Microsoft-Original-Message-ID: <20250314055644.32705-2-george.moussalem@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR19MB8883:EE_|SA3PR19MB7795:EE_ X-MS-Office365-Filtering-Correlation-Id: efff2487-0ef0-46e0-a0db-08dd62bd09c0 X-Microsoft-Antispam: BCL:0;ARA:14566002|5072599009|15080799006|8060799006|19110799003|461199028|7092599003|3412199025|440099028|1710799026; X-Microsoft-Antispam-Message-Info: +AD7Byy6fmkCgmEFwEU3PggeFp3EHVzzXY3CPMdRPkS2j+M9Zj6kkc6iYYpRn6gcPHb70+tSQtW5GnUEZitKEmDRnfbxy8UY2/tnwuoqKwuvvGfpaf2JyopLuyt/Ek/7xZAu1TUIU3nahG9fhnT7Sg8ETtoyLUnOSqSYujTbP/5ihJeBp0+UJlu8yl3X4E9VCFSq75QKinRYag7ju+/4X0QAPQZQb86uZ84S2GKddi6WYw8rykgl4beqQB6/9viMWiW+nXYNzZirnP0nlU+0UiibiMuCVcJloo+13JurKFRvwkVim9QgS8uDrxEZu0wam9AAapd/giXUbfF/MIBgryS7RDI28tjDP8O5DGZfhiWBAN1piep2il32SfSdz9wHCCeG1kCBT8fruFCrdAH6Sva3eyFPNEw3aWliWI8Ujx54yQn9VGLWqiMvmkUxrlrCNTrMWDshdy8Fu1fSA310DLKyCMBcpFy4QkX8uMN/g6s66WrIO5Td4QpXahMhw2nUPSAeGwTMT9so0NEWikHKVX9duT18R+eNUTCjYTSq+66nye9sJhBxZTq7iTtOqmGtQUZx9pzwbe/SenGYlj/p3W1qXQzw8sdxQ6rxq7+6mvoMEZ2fYmfOypKjiCtt12qbuliUzhwZqaAM2ujifH0VsxNMzdNV9MIp2hPxcUTH6wfCg2koGVEPmonXPGasVf7sFzwp6FTdF/XkFhwiinPqVmZJB5jO9cdlMmftMtsE/uwfM+cDgxDpo9Zte6hiquc6SPWTOZDey/tywMUkoz0gAGZknnGSrsV8JB98WZpNs4JIHaBMCeZN/tX5JNY5IaxvL1Hrxo3pxN8Ib6C+OeashBZjXKq9fJyqCcTa8xHj29d6Tku+78PMDrwv3XSa2DrmmrilbhtNs2U4LCzoKrMjh4lzK97XJc8qSZIDsruhXtVlY67bqQ18oA9EdgXn2lU5vMv/7ATjFIq1VOVZkcZKg5zWUTHcT6wDnj0FTkfxLWoKsyRIS9W9ghXBMPzd38o3CfBM6t5xRjANKwy35oRtVuVJYr3CMhoR/2ffsNJpIEPkEdQy3jYPvBBn1l1algQfSrVRMmv4h91M4ZonlqR+l+uFoJv5VnoDIonWO3gemak= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: OzEud1HrngZ1A/10K3ZKiDAJgW5pzAjoHgoDvK7+NmaRyOUukP7999gW2JuAIW1zM+lLtWSltwOBEGFzhXQ8DHsBEt1DnxoX4VV/Rf2+E04CFpsq68Jn8gdedGkT6gA11YX+yjoyuzVQsIKW775rJ5e5lmRRixBk+fJ+b37jMPDYkML9kONqKdTB5IhPBxApShwtTIuOsJyajlldY24aTOTbfG7Z9xYn2ex5xfqyRb0wdPz2X5tgtDyG9+fqmM1KhSjVihdpMEoQ2viT6BPu+ugJ3Z7igTmqrVg/Y7TvzaA9r1RrxtiU0r7g3m+heU6jFTsJgkNNteNQZ/m5/JAIt0gUtnVHfXzqbkRVABoZa+JcVtDjHw54T5G+ANOkk4sXiyHigbP4UOPutAHR27ms1hkNhsG5BSfvuN5SZD5pkZuVzle9hXl84KjVEaBVBC4UKjoIAGHAe+CCaxn2afLUt7bfiYSTaCEqo9mfURhCNpo13yStE2Swt6V73m91aezrNdRtWFp0VQJGNMgQyxo1u1PqNEZyz/7LboX3KDCm3bn7KmtdwZ/fUV7Km2jkPujmVwQRGliE+UV4mprRZFvfQyZfupExa4pGnVMqLNx7hk+pEzWs45ydcdUHMHXNGF30ajZA6gqDukd+iQLxiFx6gWzV7pD+QFgfVs7eHou5CHj4jxcRKSo7dRiRiOqfZiEBXJuYy8dcZ1NeO8pE/5Wc2nXNPdAhuQ6iWu4dGBmsY15DuNPSI4TFTynCAdaepsU48eVqc7xj8io4Kv8BYfXORbWK+xA1KlJETvjPZKxjcC0DdF6+wYUwg/SmqNeIkfAOhEkp92Yo8xrl00g071gNf1Y5dGfZAuYCcn4sVLkWAkeD+TgrF73bd0pF7pNq+N/ZVFTexBK138wKsV0nmi7XLt8oOtXYJQ7iyHCs/n8CS8IykHAbiTct3txDOcRoHdmc5UbjJplRhZyYcWCGPGLOViV+9G1mC2x+lke6JUizxAXWsaGxduQYNdAE24jXg14ScuQnUG/ScSLtg69gvdfRjUdq6+6QJQSEfXk5jsucIFsRC2umu26IZr9AMjxgNHYi+PzTomF+9MuQvKbNmyTI7Ue688fcM+e7N8WaGmTkClvoIaYFqypNN6S3N04mHrgYsnXF4AD+h2xW66YtvqzD5WnyIzeaiVHtMurwPXAHgwx54Yciqdobiwl6er9096i9LaRTv2mRDqCGHtavveVCkW6KIQ0DO11VtPYiWdl5kOFUSf5YMS+Si3SlM5V5wYEG X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: efff2487-0ef0-46e0-a0db-08dd62bd09c0 X-MS-Exchange-CrossTenant-AuthSource: DS7PR19MB8883.namprd19.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2025 05:57:01.7665 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR19MB7795 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250313_225707_089262_7BC32C5C X-CRM114-Status: UNSURE ( 8.47 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org From: Nitheesh Sekar The Qualcomm UNIPHY PCIe PHY 28LP is found on both IPQ5332 and IPQ5018. Adding the PHY init sequence, pipe clock rate, and compatible for IPQ5018. Signed-off-by: Nitheesh Sekar Signed-off-by: Sricharan Ramabadhran Signed-off-by: George Moussalem --- .../phy/qualcomm/phy-qcom-uniphy-pcie-28lp.c | 45 +++++++++++++++++++ 1 file changed, 45 insertions(+) diff --git a/drivers/phy/qualcomm/phy-qcom-uniphy-pcie-28lp.c b/drivers/phy/qualcomm/phy-qcom-uniphy-pcie-28lp.c index c8b2a3818880..324c0a5d658e 100644 --- a/drivers/phy/qualcomm/phy-qcom-uniphy-pcie-28lp.c +++ b/drivers/phy/qualcomm/phy-qcom-uniphy-pcie-28lp.c @@ -75,6 +75,40 @@ struct qcom_uniphy_pcie { #define phy_to_dw_phy(x) container_of((x), struct qca_uni_pcie_phy, phy) +static const struct qcom_uniphy_pcie_regs ipq5018_regs[] = { + { + .offset = SSCG_CTRL_REG_4, + .val = 0x1cb9, + }, { + .offset = SSCG_CTRL_REG_5, + .val = 0x023a, + }, { + .offset = SSCG_CTRL_REG_3, + .val = 0xd360, + }, { + .offset = SSCG_CTRL_REG_1, + .val = 0x1, + }, { + .offset = SSCG_CTRL_REG_2, + .val = 0xeb, + }, { + .offset = CDR_CTRL_REG_4, + .val = 0x3f9, + }, { + .offset = CDR_CTRL_REG_5, + .val = 0x1c9, + }, { + .offset = CDR_CTRL_REG_2, + .val = 0x419, + }, { + .offset = CDR_CTRL_REG_1, + .val = 0x200, + }, { + .offset = PCS_INTERNAL_CONTROL_2, + .val = 0xf101, + }, +}; + static const struct qcom_uniphy_pcie_regs ipq5332_regs[] = { { .offset = PHY_CFG_PLLCFG, @@ -88,6 +122,14 @@ static const struct qcom_uniphy_pcie_regs ipq5332_regs[] = { }, }; +static const struct qcom_uniphy_pcie_data ipq5018_data = { + .lane_offset = 0x800, + .phy_type = PHY_TYPE_PCIE_GEN2, + .init_seq = ipq5018_regs, + .init_seq_num = ARRAY_SIZE(ipq5018_regs), + .pipe_clk_rate = 125 * MEGA, +}; + static const struct qcom_uniphy_pcie_data ipq5332_data = { .lane_offset = 0x800, .phy_type = PHY_TYPE_PCIE_GEN3, @@ -212,6 +254,9 @@ static inline int phy_pipe_clk_register(struct qcom_uniphy_pcie *phy, int id) static const struct of_device_id qcom_uniphy_pcie_id_table[] = { { + .compatible = "qcom,ipq5018-uniphy-pcie-phy", + .data = &ipq5018_data, + }, { .compatible = "qcom,ipq5332-uniphy-pcie-phy", .data = &ipq5332_data, }, {