| Message ID | b2e1d26f964a03163ec7a1ba6ac8d7c88d6cb111.1727159906.git.Sandor.yu@nxp.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Initial support Cadence MHDP8501(HDMI/DP) for i.MX8MQ | expand |
On Tue, Sep 24, 2024 at 03:36:48PM +0800, Sandor Yu wrote: > Add bindings for Cadence MHDP8501 DisplayPort/HDMI bridge. > > Signed-off-by: Sandor Yu <Sandor.yu@nxp.com> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Drop > --- > v16->v17: > - Add lane-mapping property That's a significant change. > > v9->v16: > *No change > > .../display/bridge/cdns,mhdp8501.yaml | 109 ++++++++++++++++++ > 1 file changed, 109 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/bridge/cdns,mhdp8501.yaml > > diff --git a/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8501.yaml b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8501.yaml > new file mode 100644 > index 0000000000000..3f79f328c7425 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8501.yaml > @@ -0,0 +1,109 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/bridge/cdns,mhdp8501.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Cadence MHDP8501 DP/HDMI bridge > + > +maintainers: > + - Sandor Yu <Sandor.yu@nxp.com> > + > +description: > + Cadence MHDP8501 DisplayPort/HDMI interface. > + > +properties: > + compatible: > + enum: > + - fsl,imx8mq-mhdp8501 > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + description: MHDP8501 DP/HDMI APB clock. > + > + phys: > + maxItems: 1 > + description: > + phandle to the DP/HDMI PHY > + > + interrupts: > + items: > + - description: Hotplug cable plugin. > + - description: Hotplug cable plugout. > + > + interrupt-names: > + items: > + - const: plug_in > + - const: plug_out > + > + lane-mapping: > + description: lane mapping for HDMI or DisplayPort interface. Where is the definition of this property? I do not see any $ref here, so did you add it to dtschema? Best regards, Krzysztof
On Tue, Sep 24, 2024 at 03:36:48PM GMT, Sandor Yu wrote: > Add bindings for Cadence MHDP8501 DisplayPort/HDMI bridge. > > Signed-off-by: Sandor Yu <Sandor.yu@nxp.com> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > v16->v17: > - Add lane-mapping property > > v9->v16: > *No change > > .../display/bridge/cdns,mhdp8501.yaml | 109 ++++++++++++++++++ > 1 file changed, 109 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/bridge/cdns,mhdp8501.yaml > > diff --git a/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8501.yaml b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8501.yaml > new file mode 100644 > index 0000000000000..3f79f328c7425 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8501.yaml > @@ -0,0 +1,109 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/bridge/cdns,mhdp8501.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Cadence MHDP8501 DP/HDMI bridge > + > +maintainers: > + - Sandor Yu <Sandor.yu@nxp.com> > + > +description: > + Cadence MHDP8501 DisplayPort/HDMI interface. > + > +properties: > + compatible: > + enum: > + - fsl,imx8mq-mhdp8501 > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + description: MHDP8501 DP/HDMI APB clock. > + > + phys: > + maxItems: 1 > + description: > + phandle to the DP/HDMI PHY > + > + interrupts: > + items: > + - description: Hotplug cable plugin. > + - description: Hotplug cable plugout. > + > + interrupt-names: > + items: > + - const: plug_in > + - const: plug_out > + > + lane-mapping: > + description: lane mapping for HDMI or DisplayPort interface. > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + Input port from display controller output. > + port@1: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + Output port to DisplayPort or HDMI connector. > + > + required: > + - port@0 > + - port@1 > + > +required: > + - compatible > + - reg > + - clocks > + - interrupts > + - interrupt-names > + - phys > + - lane-mapping > + - ports > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/imx8mq-clock.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + > + mhdp: display-bridge@32c00000 { > + compatible = "fsl,imx8mq-mhdp8501"; > + reg = <0x32c00000 0x100000>; > + interrupts = <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "plug_in", "plug_out"; > + clocks = <&clk IMX8MQ_CLK_DISP_APB_ROOT>; > + phys = <&mdhp_phy>; > + lane-mapping = <0xe4>; What does this value mean? The DT should be describing the hardware, not the register values. Can it be expressed as the data-lanes property of the corresponding port? > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + mhdp_in: endpoint { > + remote-endpoint = <&dcss_out>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + > + mhdp_out: endpoint { > + remote-endpoint = <&dp_connector>; > + }; > + }; > + }; > + }; > -- > 2.34.1 >
On Tue, 24 Sep 2024 15:36:48 +0800, Sandor Yu wrote: > Add bindings for Cadence MHDP8501 DisplayPort/HDMI bridge. > > Signed-off-by: Sandor Yu <Sandor.yu@nxp.com> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > v16->v17: > - Add lane-mapping property > > v9->v16: > *No change > > .../display/bridge/cdns,mhdp8501.yaml | 109 ++++++++++++++++++ > 1 file changed, 109 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/bridge/cdns,mhdp8501.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8501.yaml: lane-mapping: missing type definition doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/b2e1d26f964a03163ec7a1ba6ac8d7c88d6cb111.1727159906.git.Sandor.yu@nxp.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Hi Krzysztof， Thanks for your comments, > > > On Tue, Sep 24, 2024 at 03:36:48PM +0800, Sandor Yu wrote: > > Add bindings for Cadence MHDP8501 DisplayPort/HDMI bridge. > > > > Signed-off-by: Sandor Yu <Sandor.yu@nxp.com> > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Drop OK, I will remove it in the next version. > > > --- > > v16->v17: > > - Add lane-mapping property > > That's a significant change. OK. > > > > > v9->v16: > > *No change > > > > .../display/bridge/cdns,mhdp8501.yaml | 109 > ++++++++++++++++++ > > 1 file changed, 109 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/display/bridge/cdns,mhdp8501.yaml > > > > diff --git > > a/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8501.yaml > > b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8501.yaml > > new file mode 100644 > > index 0000000000000..3f79f328c7425 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8501.y > > +++ aml > > > @@ -0,0 +1,109 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) %YAML 1.2 > > +--- > > +$id: > > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi > > > +cetree.org%2Fschemas%2Fdisplay%2Fbridge%2Fcdns%2Cmhdp8501.yaml%2 > 3&dat > > > +a=05%7C02%7CSandor.yu%40nxp.com%7C40a6bd4ff1cd4d934da008dcdc72 > 9fd0%7C > > > +686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63862763207998660 > 8%7CUnkno > > > +wn%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1h > aWwi > > > +LCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=Uw%2FQQ0Qg36Y8Q6wFPC7Zg > LzLHvOj8GjH1 > > +k8McgcjrqI%3D&reserved=0 > > +$schema: > > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi > > > +cetree.org%2Fmeta-schemas%2Fcore.yaml%23&data=05%7C02%7CSandor.y > u%40n > > > +xp.com%7C40a6bd4ff1cd4d934da008dcdc729fd0%7C686ea1d3bc2b4c6fa92 > cd99c5 > > > +c301635%7C0%7C0%7C638627632080031124%7CUnknown%7CTWFpbGZs > b3d8eyJWIjoi > > > +MC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0% > 7C%7C% > > > +7C&sdata=IG9Em3AWOwzlpR1Wk0Vw%2FF161YcOxuMHbA4Y%2FzftgYA%3D > &reserved= > > +0 > > + > > +title: Cadence MHDP8501 DP/HDMI bridge > > + > > +maintainers: > > + - Sandor Yu <Sandor.yu@nxp.com> > > + > > +description: > > + Cadence MHDP8501 DisplayPort/HDMI interface. > > + > > +properties: > > + compatible: > > + enum: > > + - fsl,imx8mq-mhdp8501 > > + > > + reg: > > + maxItems: 1 > > + > > + clocks: > > + maxItems: 1 > > + description: MHDP8501 DP/HDMI APB clock. > > + > > + phys: > > + maxItems: 1 > > + description: > > + phandle to the DP/HDMI PHY > > + > > + interrupts: > > + items: > > + - description: Hotplug cable plugin. > > + - description: Hotplug cable plugout. > > + > > + interrupt-names: > > + items: > > + - const: plug_in > > + - const: plug_out > > + > > + lane-mapping: > > + description: lane mapping for HDMI or DisplayPort interface. > > Where is the definition of this property? I do not see any $ref here, so did you > add it to dtschema? My apologies, the $ref is missing, will add it in the next version.. B.R Sandor > > Best regards, > Krzysztof
On 29/09/2024 04:36, Sandor Yu wrote: > Hi Krzysztof， > > Thanks for your comments, > >> >> >> On Tue, Sep 24, 2024 at 03:36:48PM +0800, Sandor Yu wrote: >>> Add bindings for Cadence MHDP8501 DisplayPort/HDMI bridge. >>> >>> Signed-off-by: Sandor Yu <Sandor.yu@nxp.com> >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> >> Drop > OK, I will remove it in the next version. > >> >>> --- >>> v16->v17: >>> - Add lane-mapping property >> >> That's a significant change. > OK. > >> >>> >>> v9->v16: >>> *No change >>> >>> .../display/bridge/cdns,mhdp8501.yaml | 109 >> ++++++++++++++++++ >>> 1 file changed, 109 insertions(+) >>> create mode 100644 >>> Documentation/devicetree/bindings/display/bridge/cdns,mhdp8501.yaml >>> >>> diff --git >>> a/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8501.yaml >>> b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8501.yaml >>> new file mode 100644 >>> index 0000000000000..3f79f328c7425 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8501.y >>> +++ aml >> >>> @@ -0,0 +1,109 @@ >>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) %YAML 1.2 >>> +--- >>> +$id: >>> +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi >>> >> +cetree.org%2Fschemas%2Fdisplay%2Fbridge%2Fcdns%2Cmhdp8501.yaml%2 >> 3&dat >>> >> +a=05%7C02%7CSandor.yu%40nxp.com%7C40a6bd4ff1cd4d934da008dcdc72 >> 9fd0%7C >>> >> +686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63862763207998660 >> 8%7CUnkno >>> >> +wn%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1h >> aWwi >>> >> +LCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=Uw%2FQQ0Qg36Y8Q6wFPC7Zg >> LzLHvOj8GjH1 >>> +k8McgcjrqI%3D&reserved=0 >>> +$schema: >>> +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi >>> >> +cetree.org%2Fmeta-schemas%2Fcore.yaml%23&data=05%7C02%7CSandor.y >> u%40n >>> >> +xp.com%7C40a6bd4ff1cd4d934da008dcdc729fd0%7C686ea1d3bc2b4c6fa92 >> cd99c5 >>> >> +c301635%7C0%7C0%7C638627632080031124%7CUnknown%7CTWFpbGZs >> b3d8eyJWIjoi >>> >> +MC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0% >> 7C%7C% >>> >> +7C&sdata=IG9Em3AWOwzlpR1Wk0Vw%2FF161YcOxuMHbA4Y%2FzftgYA%3D >> &reserved= >>> +0 >>> + >>> +title: Cadence MHDP8501 DP/HDMI bridge >>> + >>> +maintainers: >>> + - Sandor Yu <Sandor.yu@nxp.com> >>> + >>> +description: >>> + Cadence MHDP8501 DisplayPort/HDMI interface. >>> + >>> +properties: >>> + compatible: >>> + enum: >>> + - fsl,imx8mq-mhdp8501 >>> + >>> + reg: >>> + maxItems: 1 >>> + >>> + clocks: >>> + maxItems: 1 >>> + description: MHDP8501 DP/HDMI APB clock. >>> + >>> + phys: >>> + maxItems: 1 >>> + description: >>> + phandle to the DP/HDMI PHY >>> + >>> + interrupts: >>> + items: >>> + - description: Hotplug cable plugin. >>> + - description: Hotplug cable plugout. >>> + >>> + interrupt-names: >>> + items: >>> + - const: plug_in >>> + - const: plug_out >>> + >>> + lane-mapping: >>> + description: lane mapping for HDMI or DisplayPort interface. >> >> Where is the definition of this property? I do not see any $ref here, so did you >> add it to dtschema? > > My apologies, the $ref is missing, will add it in the next version.. And that's different than existing properties, e.g. data-lanes or lane-polarities? There is no description here except copying property name, which is not useful at all. Come with solution matching other bridges and media devices. Best regards, Krzysztof
> > On 29/09/2024 04:36, Sandor Yu wrote: > > Hi Krzysztof， > > > > Thanks for your comments, > > > >> > >> > >> On Tue, Sep 24, 2024 at 03:36:48PM +0800, Sandor Yu wrote: > >>> Add bindings for Cadence MHDP8501 DisplayPort/HDMI bridge. > >>> > >>> Signed-off-by: Sandor Yu <Sandor.yu@nxp.com> > >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >> > >> Drop > > OK, I will remove it in the next version. > > > >> > >>> --- > >>> v16->v17: > >>> - Add lane-mapping property > >> > >> That's a significant change. > > OK. > > > >> > >>> > >>> v9->v16: > >>> *No change > >>> > >>> .../display/bridge/cdns,mhdp8501.yaml | 109 > >> ++++++++++++++++++ > >>> 1 file changed, 109 insertions(+) > >>> create mode 100644 > >>> Documentation/devicetree/bindings/display/bridge/cdns,mhdp8501.yaml > >>> > >>> diff --git > >>> > a/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8501.yam > >>> l > >>> > b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8501.yam > >>> l > >>> new file mode 100644 > >>> index 0000000000000..3f79f328c7425 > >>> --- /dev/null > >>> +++ > b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8501 > >>> +++ .y > >>> +++ aml > >> > >>> @@ -0,0 +1,109 @@ > >>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) %YAML 1.2 > >>> +--- > >>> +$id: > >>> > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fde > >>> > +vi%2F&data=05%7C02%7Csandor.yu%40nxp.com%7C3c6bfe07c23945a1052 > 608dc > >>> > +e13ffde7%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6386329 > 121918 > >>> > +65139%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2 > luMzIiL > >>> > +CJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=yrG%2FJsGK5 > czDeRwf > >>> +A8e6%2F5r0Ui5v95uiC4OlK7DJ5QY%3D&reserved=0 > >>> > >> > +cetree.org%2Fschemas%2Fdisplay%2Fbridge%2Fcdns%2Cmhdp8501.yaml% > 2 > >> 3&dat > >>> > >> > +a=05%7C02%7CSandor.yu%40nxp.com%7C40a6bd4ff1cd4d934da008dcdc72 > >> 9fd0%7C > >>> > >> > +686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63862763207998660 > >> 8%7CUnkno > >>> > >> > +wn%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1 > h > >> aWwi > >>> > >> > +LCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=Uw%2FQQ0Qg36Y8Q6wFPC7Z > g > >> LzLHvOj8GjH1 > >>> +k8McgcjrqI%3D&reserved=0 > >>> +$schema: > >>> > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fde > >>> > +vi%2F&data=05%7C02%7Csandor.yu%40nxp.com%7C3c6bfe07c23945a1052 > 608dc > >>> > +e13ffde7%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6386329 > 121918 > >>> > +95630%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2 > luMzIiL > >>> > +CJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=%2BKccVMx > nf5oUwZgf > >>> +smPXiKN2VycnLCdDKx6FZFBBAJM%3D&reserved=0 > >>> > >> > +cetree.org%2Fmeta-schemas%2Fcore.yaml%23&data=05%7C02%7CSandor. > y > >> u%40n > >>> > >> > +xp.com%7C40a6bd4ff1cd4d934da008dcdc729fd0%7C686ea1d3bc2b4c6fa9 > 2 > >> cd99c5 > >>> > >> > +c301635%7C0%7C0%7C638627632080031124%7CUnknown%7CTWFpbGZs > >> b3d8eyJWIjoi > >>> > >> > +MC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0 > % > >> 7C%7C% > >>> > >> > +7C&sdata=IG9Em3AWOwzlpR1Wk0Vw%2FF161YcOxuMHbA4Y%2FzftgYA%3 > D > >> &reserved= > >>> +0 > >>> + > >>> +title: Cadence MHDP8501 DP/HDMI bridge > >>> + > >>> +maintainers: > >>> + - Sandor Yu <Sandor.yu@nxp.com> > >>> + > >>> +description: > >>> + Cadence MHDP8501 DisplayPort/HDMI interface. > >>> + > >>> +properties: > >>> + compatible: > >>> + enum: > >>> + - fsl,imx8mq-mhdp8501 > >>> + > >>> + reg: > >>> + maxItems: 1 > >>> + > >>> + clocks: > >>> + maxItems: 1 > >>> + description: MHDP8501 DP/HDMI APB clock. > >>> + > >>> + phys: > >>> + maxItems: 1 > >>> + description: > >>> + phandle to the DP/HDMI PHY > >>> + > >>> + interrupts: > >>> + items: > >>> + - description: Hotplug cable plugin. > >>> + - description: Hotplug cable plugout. > >>> + > >>> + interrupt-names: > >>> + items: > >>> + - const: plug_in > >>> + - const: plug_out > >>> + > >>> + lane-mapping: > >>> + description: lane mapping for HDMI or DisplayPort interface. > >> > >> Where is the definition of this property? I do not see any $ref here, > >> so did you add it to dtschema? > > > > My apologies, the $ref is missing, will add it in the next version.. > > And that's different than existing properties, e.g. data-lanes or lane-polarities? > There is no description here except copying property name, which is not > useful at all. > > Come with solution matching other bridges and media devices. The data-lanes property in media/video-interfaces.yaml supports lane reordering, which is what I expected. I'll use data-lanes to replace lane-mapping in the next version. Thanks Sandor > > Best regards, > Krzysztof
diff --git a/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8501.yaml b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8501.yaml new file mode 100644 index 0000000000000..3f79f328c7425 --- /dev/null +++ b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8501.yaml @@ -0,0 +1,109 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/bridge/cdns,mhdp8501.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Cadence MHDP8501 DP/HDMI bridge + +maintainers: + - Sandor Yu <Sandor.yu@nxp.com> + +description: + Cadence MHDP8501 DisplayPort/HDMI interface. + +properties: + compatible: + enum: + - fsl,imx8mq-mhdp8501 + + reg: + maxItems: 1 + + clocks: + maxItems: 1 + description: MHDP8501 DP/HDMI APB clock. + + phys: + maxItems: 1 + description: + phandle to the DP/HDMI PHY + + interrupts: + items: + - description: Hotplug cable plugin. + - description: Hotplug cable plugout. + + interrupt-names: + items: + - const: plug_in + - const: plug_out + + lane-mapping: + description: lane mapping for HDMI or DisplayPort interface. + + ports: + $ref: /schemas/graph.yaml#/properties/ports + + properties: + port@0: + $ref: /schemas/graph.yaml#/properties/port + description: + Input port from display controller output. + port@1: + $ref: /schemas/graph.yaml#/properties/port + description: + Output port to DisplayPort or HDMI connector. + + required: + - port@0 + - port@1 + +required: + - compatible + - reg + - clocks + - interrupts + - interrupt-names + - phys + - lane-mapping + - ports + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/imx8mq-clock.h> + #include <dt-bindings/interrupt-controller/arm-gic.h> + + mhdp: display-bridge@32c00000 { + compatible = "fsl,imx8mq-mhdp8501"; + reg = <0x32c00000 0x100000>; + interrupts = <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "plug_in", "plug_out"; + clocks = <&clk IMX8MQ_CLK_DISP_APB_ROOT>; + phys = <&mdhp_phy>; + lane-mapping = <0xe4>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + + mhdp_in: endpoint { + remote-endpoint = <&dcss_out>; + }; + }; + + port@1 { + reg = <1>; + + mhdp_out: endpoint { + remote-endpoint = <&dp_connector>; + }; + }; + }; + };