| Message ID | e34d8eddc1dda8bb0ff840a7dd18ca4dd6c62d22.1679479634.git.quic_varada@quicinc.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Enable IPQ9754 USB | expand |
On 22/03/2023 11:44, Varadarajan Narayanan wrote: > Add dt-bindings for USB3 PHY found on Qualcomm IPQ9574 > > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > > --- > Changes in v2: > - Updated sections missed in previous patch > --- > .../bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml > index e81a382..beae44c 100644 > --- a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml > @@ -21,6 +21,7 @@ properties: > enum: > - qcom,ipq6018-qmp-usb3-phy > - qcom,ipq8074-qmp-usb3-phy > + - qcom,ipq9574-qmp-usb3-phy > - qcom,msm8996-qmp-usb3-phy > - qcom,msm8998-qmp-usb3-phy > - qcom,qcm2290-qmp-usb3-phy > @@ -204,6 +205,27 @@ allOf: > compatible: > contains: > enum: > + - qcom,ipq9574-qmp-usb3-phy > + then: > + properties: > + clocks: > + maxItems: 2 toplevel defines minItems as 3, so are you sure this works? Did you test it? Best regards, Krzysztof
On Wed, Mar 22, 2023 at 10:52:44PM +0100, Krzysztof Kozlowski wrote: > On 22/03/2023 11:44, Varadarajan Narayanan wrote: > > Add dt-bindings for USB3 PHY found on Qualcomm IPQ9574 > > > > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > > > > --- > > Changes in v2: > > - Updated sections missed in previous patch > > --- > > .../bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml | 22 ++++++++++++++++++++++ > > 1 file changed, 22 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml > > index e81a382..beae44c 100644 > > --- a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml > > +++ b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml > > @@ -21,6 +21,7 @@ properties: > > enum: > > - qcom,ipq6018-qmp-usb3-phy > > - qcom,ipq8074-qmp-usb3-phy > > + - qcom,ipq9574-qmp-usb3-phy > > - qcom,msm8996-qmp-usb3-phy > > - qcom,msm8998-qmp-usb3-phy > > - qcom,qcm2290-qmp-usb3-phy > > @@ -204,6 +205,27 @@ allOf: > > compatible: > > contains: > > enum: > > + - qcom,ipq9574-qmp-usb3-phy > > + then: > > + properties: > > + clocks: > > + maxItems: 2 > > toplevel defines minItems as 3, so are you sure this works? Did you test it? Yes, this is tested. Able to do I/O. We only have 2 items. Is it ok change the minItems to 2? Thanks Varada > > Best regards, > Krzysztof >
On 23/03/2023 07:37, Varadarajan Narayanan wrote: > On Wed, Mar 22, 2023 at 10:52:44PM +0100, Krzysztof Kozlowski wrote: >> On 22/03/2023 11:44, Varadarajan Narayanan wrote: >>> Add dt-bindings for USB3 PHY found on Qualcomm IPQ9574 >>> >>> Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> >>> >>> --- >>> Changes in v2: >>> - Updated sections missed in previous patch >>> --- >>> .../bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml | 22 ++++++++++++++++++++++ >>> 1 file changed, 22 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml >>> index e81a382..beae44c 100644 >>> --- a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml >>> +++ b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml >>> @@ -21,6 +21,7 @@ properties: >>> enum: >>> - qcom,ipq6018-qmp-usb3-phy >>> - qcom,ipq8074-qmp-usb3-phy >>> + - qcom,ipq9574-qmp-usb3-phy >>> - qcom,msm8996-qmp-usb3-phy >>> - qcom,msm8998-qmp-usb3-phy >>> - qcom,qcm2290-qmp-usb3-phy >>> @@ -204,6 +205,27 @@ allOf: >>> compatible: >>> contains: >>> enum: >>> + - qcom,ipq9574-qmp-usb3-phy >>> + then: >>> + properties: >>> + clocks: >>> + maxItems: 2 >> >> toplevel defines minItems as 3, so are you sure this works? Did you test it? > > Yes, this is tested. Able to do I/O. Bindings do not impact on whether you can or can not do IO, so I meant tested as DTS is compliant with bindings. I assume it was not, so please test bindings and DTS before sending new version. see Documentation/devicetree/bindings/writing-schema.rst for instructions > We only have 2 items. Is it ok change the minItems to 2? Yes, because you must update top level (and maybe other) constraints to correct ones. Just test the code... Best regards, Krzysztof
On Thu, Mar 23, 2023 at 07:42:37AM +0100, Krzysztof Kozlowski wrote: > On 23/03/2023 07:37, Varadarajan Narayanan wrote: > > On Wed, Mar 22, 2023 at 10:52:44PM +0100, Krzysztof Kozlowski wrote: > >> On 22/03/2023 11:44, Varadarajan Narayanan wrote: > >>> Add dt-bindings for USB3 PHY found on Qualcomm IPQ9574 > >>> > >>> Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > >>> > >>> --- > >>> Changes in v2: > >>> - Updated sections missed in previous patch > >>> --- > >>> .../bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml | 22 ++++++++++++++++++++++ > >>> 1 file changed, 22 insertions(+) > >>> > >>> diff --git a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml > >>> index e81a382..beae44c 100644 > >>> --- a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml > >>> +++ b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml > >>> @@ -21,6 +21,7 @@ properties: > >>> enum: > >>> - qcom,ipq6018-qmp-usb3-phy > >>> - qcom,ipq8074-qmp-usb3-phy > >>> + - qcom,ipq9574-qmp-usb3-phy > >>> - qcom,msm8996-qmp-usb3-phy > >>> - qcom,msm8998-qmp-usb3-phy > >>> - qcom,qcm2290-qmp-usb3-phy > >>> @@ -204,6 +205,27 @@ allOf: > >>> compatible: > >>> contains: > >>> enum: > >>> + - qcom,ipq9574-qmp-usb3-phy > >>> + then: > >>> + properties: > >>> + clocks: > >>> + maxItems: 2 > >> > >> toplevel defines minItems as 3, so are you sure this works? Did you test it? > > > > Yes, this is tested. Able to do I/O. > > Bindings do not impact on whether you can or can not do IO, so I meant > tested as DTS is compliant with bindings. I assume it was not, so please > test bindings and DTS before sending new version. > see Documentation/devicetree/bindings/writing-schema.rst for instructions Sorry. Misunderstood the question. Yes, I ran make dtbs_check and got these messages. But couldn't relate them with the minItems/maxItems mismatch... phy@7d000: clocks: [[8, 93], [8, 102]] is too short phy@7d000: clock-names: ['aux', 'cfg_ahb'] is too short Will fix it now. Thanks for the clarification. > > We only have 2 items. Is it ok change the minItems to 2? > > Yes, because you must update top level (and maybe other) constraints to > correct ones. Just test the code... Ok. Thanks Varada > > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml index e81a382..beae44c 100644 --- a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml @@ -21,6 +21,7 @@ properties: enum: - qcom,ipq6018-qmp-usb3-phy - qcom,ipq8074-qmp-usb3-phy + - qcom,ipq9574-qmp-usb3-phy - qcom,msm8996-qmp-usb3-phy - qcom,msm8998-qmp-usb3-phy - qcom,qcm2290-qmp-usb3-phy @@ -204,6 +205,27 @@ allOf: compatible: contains: enum: + - qcom,ipq9574-qmp-usb3-phy + then: + properties: + clocks: + maxItems: 2 + clock-names: + items: + - const: aux + - const: cfg_ahb + resets: + maxItems: 2 + reset-names: + items: + - const: phy + - const: common + + - if: + properties: + compatible: + contains: + enum: - qcom,sm8150-qmp-usb3-phy - qcom,sm8150-qmp-usb3-uni-phy - qcom,sm8250-qmp-usb3-uni-phy
Add dt-bindings for USB3 PHY found on Qualcomm IPQ9574 Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> --- Changes in v2: - Updated sections missed in previous patch --- .../bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+)