| Message ID | e64265a4-9543-4728-a49f-ea910fccef7c@stanley.mountain |
|---|---|
| State | New |
| Headers | show |
| Series | [next] phy: rockchip-samsung-dcphy: Add missing assignment | expand |
Hey Dan, Am Freitag, 21. März 2025, 15:36:14 MEZ schrieb Dan Carpenter: > The "ret = " was accidentally dropped so the error handling doesn't work. > > Fixes: b2a1a2ae7818 ("phy: rockchip: Add Samsung MIPI D-/C-PHY driver") > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> oh darn ... thanks so much for catching that Reviewed-by: Heiko Stuebner <heiko@sntech.de> > --- > drivers/phy/rockchip/phy-rockchip-samsung-dcphy.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/phy/rockchip/phy-rockchip-samsung-dcphy.c b/drivers/phy/rockchip/phy-rockchip-samsung-dcphy.c > index 08c78c1bafc9..28a052e17366 100644 > --- a/drivers/phy/rockchip/phy-rockchip-samsung-dcphy.c > +++ b/drivers/phy/rockchip/phy-rockchip-samsung-dcphy.c > @@ -1653,7 +1653,7 @@ static __maybe_unused int samsung_mipi_dcphy_runtime_resume(struct device *dev) > return ret; > } > > - clk_prepare_enable(samsung->ref_clk); > + ret = clk_prepare_enable(samsung->ref_clk); > if (ret) { > dev_err(samsung->dev, "Failed to enable reference clock, %d\n", ret); > clk_disable_unprepare(samsung->pclk); >
diff --git a/drivers/phy/rockchip/phy-rockchip-samsung-dcphy.c b/drivers/phy/rockchip/phy-rockchip-samsung-dcphy.c index 08c78c1bafc9..28a052e17366 100644 --- a/drivers/phy/rockchip/phy-rockchip-samsung-dcphy.c +++ b/drivers/phy/rockchip/phy-rockchip-samsung-dcphy.c @@ -1653,7 +1653,7 @@ static __maybe_unused int samsung_mipi_dcphy_runtime_resume(struct device *dev) return ret; } - clk_prepare_enable(samsung->ref_clk); + ret = clk_prepare_enable(samsung->ref_clk); if (ret) { dev_err(samsung->dev, "Failed to enable reference clock, %d\n", ret); clk_disable_unprepare(samsung->pclk);
The "ret = " was accidentally dropped so the error handling doesn't work. Fixes: b2a1a2ae7818 ("phy: rockchip: Add Samsung MIPI D-/C-PHY driver") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> --- drivers/phy/rockchip/phy-rockchip-samsung-dcphy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)