| Message ID | f5dd0ee4-d97e-d878-ffde-c06e9b233e38@gmail.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | Add more Rockchip rk3128 compatible strings | expand |
On Sat, 10 Sep 2022 00:02:22 +0200, Johan Jonker wrote: > Add rockchip,rk3128-pwm compatible string. > > Signed-off-by: Johan Jonker <jbx6244@gmail.com> > --- > Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml | 1 + > 1 file changed, 1 insertion(+) > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/ pwm@10280000: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+' arch/arm/boot/dts/rv1108-elgin-r1.dtb arch/arm/boot/dts/rv1108-evb.dtb pwm@10280010: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+' arch/arm/boot/dts/rv1108-elgin-r1.dtb arch/arm/boot/dts/rv1108-evb.dtb pwm@10280020: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+' arch/arm/boot/dts/rv1108-elgin-r1.dtb arch/arm/boot/dts/rv1108-evb.dtb pwm@10280030: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+' arch/arm/boot/dts/rv1108-elgin-r1.dtb arch/arm/boot/dts/rv1108-evb.dtb pwm@20040000: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+' arch/arm/boot/dts/rv1108-elgin-r1.dtb arch/arm/boot/dts/rv1108-evb.dtb pwm@20040010: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+' arch/arm/boot/dts/rv1108-elgin-r1.dtb arch/arm/boot/dts/rv1108-evb.dtb pwm@20040020: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+' arch/arm/boot/dts/rv1108-elgin-r1.dtb arch/arm/boot/dts/rv1108-evb.dtb pwm@20040030: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+' arch/arm/boot/dts/rv1108-elgin-r1.dtb arch/arm/boot/dts/rv1108-evb.dtb pwm@ff1b0030: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+' arch/arm64/boot/dts/rockchip/rk3318-a95x-z2.dtb arch/arm64/boot/dts/rockchip/rk3328-a1.dtb arch/arm64/boot/dts/rockchip/rk3328-evb.dtb arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dtb arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dtb arch/arm64/boot/dts/rockchip/rk3328-rock64.dtb arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dtb arch/arm64/boot/dts/rockchip/rk3328-roc-pc.dtb
Hello, On Sat, Sep 10, 2022 at 12:02:22AM +0200, Johan Jonker wrote: > Add rockchip,rk3128-pwm compatible string. > > Signed-off-by: Johan Jonker <jbx6244@gmail.com> Considering the problems pointed out by Rob as orthogonal to this change: Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Best regards Uwe
On Sat, 10 Sep 2022 00:02:22 +0200, Johan Jonker wrote: > Add rockchip,rk3128-pwm compatible string. > > Signed-off-by: Johan Jonker <jbx6244@gmail.com> > --- > Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Rob Herring <robh@kernel.org>
Hello, On Sat, Sep 10, 2022 at 12:02:22AM +0200, Johan Jonker wrote: > Add rockchip,rk3128-pwm compatible string. > > Signed-off-by: Johan Jonker <jbx6244@gmail.com> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Is the expectation that this goes in via PWM, or together with the other patches via the rockchip maintainers? Best regards Uwe
Am Dienstag, 20. September 2022, 08:21:49 CEST schrieb Uwe Kleine-König: > Hello, > > On Sat, Sep 10, 2022 at 12:02:22AM +0200, Johan Jonker wrote: > > Add rockchip,rk3128-pwm compatible string. > > > > Signed-off-by: Johan Jonker <jbx6244@gmail.com> > > Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > Is the expectation that this goes in via PWM, or together with the other > patches via the rockchip maintainers? in general I think bindings always go through the subsystem that they're targetting - PWM in this case. Acked-by: Heiko Stuebner <heiko@sntech.de> Heiko
diff --git a/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml b/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml index a336ff936..f86170871 100644 --- a/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml +++ b/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml @@ -21,6 +21,7 @@ properties: - const: rockchip,rk2928-pwm - items: - enum: + - rockchip,rk3128-pwm - rockchip,rk3368-pwm - rockchip,rk3399-pwm - rockchip,rv1108-pwm
Add rockchip,rk3128-pwm compatible string. Signed-off-by: Johan Jonker <jbx6244@gmail.com> --- Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml | 1 + 1 file changed, 1 insertion(+)