mbox series

[0/6] devfreq: handle suspend/resume

Message ID 1542823301-23563-1-git-send-email-l.luba@partner.samsung.com (mailing list archive)
Headers show
Series devfreq: handle suspend/resume | expand

Message

Lukasz Luba Nov. 21, 2018, 6:01 p.m. UTC
Hi all,

This patch set aims to address the issue with devfreq devices' frequency
during suspend/resume. It extends suspend/resume by calls to Devfreq
framework. In the devfreq framework there is a small refactoring to avoid
code duplication in changging frequency (patch 2) and there are extensions
for suspending devices.

It has been tested on Odroid u3 with Exynos 4412.

The patch set draws on Tobias Jakobi's work posted ~2 years ago, who tried
to solve issue with devfreq device's frequency during suspend/resume.
During the discussion on LKML some corner cases and comments appeared
related to the design. This patch set address them keeping in mind
suggestions from Chanwoo Choi.
Tobias's paches:
https://www.spinics.net/lists/linux-samsung-soc/msg56602.html 

Regards,
Lukasz Luba

Lukasz Luba (6):
  devfreq: add basic fileds supporting suspend functionality
  devfreq: refactor set_target frequency function
  devfreq: add support for suspend/resume of a devfreq device
  devfreq: add devfreq_suspend/resume() functions
  drivers: power: suspend: call devfreq suspend/resume
  arm: dts: exynos4: set opp-suspend for DMC and leftbus

 arch/arm/boot/dts/exynos4210.dtsi |   2 +
 arch/arm/boot/dts/exynos4412.dtsi |   2 +
 drivers/base/power/main.c         |   3 +
 drivers/devfreq/devfreq.c         | 159 ++++++++++++++++++++++++++++++--------
 include/linux/devfreq.h           |  11 +++
 5 files changed, 146 insertions(+), 31 deletions(-)

Comments

Tobias Jakobi Nov. 22, 2018, 5:24 p.m. UTC | #1
Hey Lukasz,

just wanted to say hi and thanks for picking this up. Sadly my work no longer
permits me to spend time working on the kernel.

Anyway, great that this issue finally gets solved! :)

With best wishes,
Tobias


Lukasz Luba wrote:
> Hi all,
> 
> This patch set aims to address the issue with devfreq devices' frequency
> during suspend/resume. It extends suspend/resume by calls to Devfreq
> framework. In the devfreq framework there is a small refactoring to avoid
> code duplication in changging frequency (patch 2) and there are extensions
> for suspending devices.
> 
> It has been tested on Odroid u3 with Exynos 4412.
> 
> The patch set draws on Tobias Jakobi's work posted ~2 years ago, who tried
> to solve issue with devfreq device's frequency during suspend/resume.
> During the discussion on LKML some corner cases and comments appeared
> related to the design. This patch set address them keeping in mind
> suggestions from Chanwoo Choi.
> Tobias's paches:
> https://www.spinics.net/lists/linux-samsung-soc/msg56602.html 
> 
> Regards,
> Lukasz Luba
> 
> Lukasz Luba (6):
>   devfreq: add basic fileds supporting suspend functionality
>   devfreq: refactor set_target frequency function
>   devfreq: add support for suspend/resume of a devfreq device
>   devfreq: add devfreq_suspend/resume() functions
>   drivers: power: suspend: call devfreq suspend/resume
>   arm: dts: exynos4: set opp-suspend for DMC and leftbus
> 
>  arch/arm/boot/dts/exynos4210.dtsi |   2 +
>  arch/arm/boot/dts/exynos4412.dtsi |   2 +
>  drivers/base/power/main.c         |   3 +
>  drivers/devfreq/devfreq.c         | 159 ++++++++++++++++++++++++++++++--------
>  include/linux/devfreq.h           |  11 +++
>  5 files changed, 146 insertions(+), 31 deletions(-)
>
Lukasz Luba Nov. 22, 2018, 5:44 p.m. UTC | #2
Hi Tobias,

On 11/22/18 6:24 PM, Tobias Jakobi wrote:
> Hey Lukasz,
> 
> just wanted to say hi and thanks for picking this up. Sadly my work no longer
> permits me to spend time working on the kernel.
Fingers crossed for your current work and maybe for come back to kernel
development in the future!
> 
> Anyway, great that this issue finally gets solved! :)
Thank you for your idea and development of these patches in v1 and v2.
This functionality is really needed.

Regards,
Lukasz

> 
> With best wishes,
> Tobias
> 
> 
> Lukasz Luba wrote:
>> Hi all,
>>
>> This patch set aims to address the issue with devfreq devices' frequency
>> during suspend/resume. It extends suspend/resume by calls to Devfreq
>> framework. In the devfreq framework there is a small refactoring to avoid
>> code duplication in changging frequency (patch 2) and there are extensions
>> for suspending devices.
>>
>> It has been tested on Odroid u3 with Exynos 4412.
>>
>> The patch set draws on Tobias Jakobi's work posted ~2 years ago, who tried
>> to solve issue with devfreq device's frequency during suspend/resume.
>> During the discussion on LKML some corner cases and comments appeared
>> related to the design. This patch set address them keeping in mind
>> suggestions from Chanwoo Choi.
>> Tobias's paches:
>> https://www.spinics.net/lists/linux-samsung-soc/msg56602.html
>>
>> Regards,
>> Lukasz Luba
>>
>> Lukasz Luba (6):
>>    devfreq: add basic fileds supporting suspend functionality
>>    devfreq: refactor set_target frequency function
>>    devfreq: add support for suspend/resume of a devfreq device
>>    devfreq: add devfreq_suspend/resume() functions
>>    drivers: power: suspend: call devfreq suspend/resume
>>    arm: dts: exynos4: set opp-suspend for DMC and leftbus
>>
>>   arch/arm/boot/dts/exynos4210.dtsi |   2 +
>>   arch/arm/boot/dts/exynos4412.dtsi |   2 +
>>   drivers/base/power/main.c         |   3 +
>>   drivers/devfreq/devfreq.c         | 159 ++++++++++++++++++++++++++++++--------
>>   include/linux/devfreq.h           |  11 +++
>>   5 files changed, 146 insertions(+), 31 deletions(-)
>>
> 
> 
>