| Message ID | 1596087177-30329-1-git-send-email-ego@linux.vnet.ibm.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | cpuidle-pseries: Parse extended CEDE information for idle. | expand |
On Thu, 30 Jul 2020 11:02:54 +0530, Gautham R. Shenoy wrote: > This is a v3 of the patch series to parse the extended CEDE > information in the pseries-cpuidle driver. > > The previous two versions of the patches can be found here: > > v2: https://lore.kernel.org/lkml/1596005254-25753-1-git-send-email-ego@linux.vnet.ibm.com/ > > [...] Applied to powerpc/next. [1/3] cpuidle: pseries: Set the latency-hint before entering CEDE https://git.kernel.org/powerpc/c/3af0ada7dd98c6da35c1fd7f107af3b9aa5e904c [2/3] cpuidle: pseries: Add function to parse extended CEDE records https://git.kernel.org/powerpc/c/054e44ba99ae36918631fcbf5f034e466c2f1b73 [3/3] cpuidle: pseries: Fixup exit latency for CEDE(0) https://git.kernel.org/powerpc/c/d947fb4c965cdb7242f3f91124ea16079c49fa8b cheers
From: "Gautham R. Shenoy" <ego@linux.vnet.ibm.com> This is a v3 of the patch series to parse the extended CEDE information in the pseries-cpuidle driver. The previous two versions of the patches can be found here: v2: https://lore.kernel.org/lkml/1596005254-25753-1-git-send-email-ego@linux.vnet.ibm.com/ v1: https://lore.kernel.org/linuxppc-dev/1594120299-31389-1-git-send-email-ego@linux.vnet.ibm.com/ The change from v2 --> v1 : * Patch 1: Got rid of some #define-s which were needed mainly for Patches4 and 5 of v1, but were retained in v2. * Patch 2: * Based on feedback from Michael Ellerman, rewrote the function to parse the extended idle states by explicitly defining the structure of the object that is returned by ibm,get-system-parameters(CEDE_LATENCY_TOKEN) rtas-call. In the previous versions we were passing a character array and subsequently parsing the individual elements which can be bug-prone. This also gets rid of the excessive (cast *)ing that was in the previous versions. * Marked some of the functions static and annotated some of the functions with __init and data with __initdata. This makes Sparse happy. * Added comments for CEDE_LATENCY_TOKEN. * Renamed add_pseries_idle_states() to parse_xcede_idle_states(). Again, this is because Patch 4 and 5 from v1 are no longer there. * Patch 3: No functional changes, but minor changes to be consistent with Patch 1 and 2 of this series. I have additionally tested the code on POWER8 dedicated LPAR and found that it has no impact, since the wakeup latency of CEDE(1) is 30us which is greater that default latency that we are assuming for CEDE(0). So we do not need to fixup CEDE(0) latency on POWER8. Vaidy, I have removed your Reviewed-by for v1, since the code has changed a little bit. Gautham R. Shenoy (3): cpuidle-pseries: Set the latency-hint before entering CEDE cpuidle-pseries: Add function to parse extended CEDE records cpuidle-pseries : Fixup exit latency for CEDE(0) drivers/cpuidle/cpuidle-pseries.c | 190 +++++++++++++++++++++++++++++++++++++- 1 file changed, 188 insertions(+), 2 deletions(-)