| Message ID | 20191029164438.17012-1-ulf.hansson@linaro.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | cpuidle: psci: Support hierarchical CPU arrangement | expand |
On Tue, 29 Oct 2019 at 17:44, Ulf Hansson <ulf.hansson@linaro.org> wrote: > > Changes in v2: > - Avoid to affect the non-OSI path with specific changes for OSI. This > forced me to re-order the series and a caused more or less minor changes > to most of the patches. > - Updated the DT bindings for PSCI to clarify and to include the "psci" > name of the PM domain to attach to. > - Replaced patch1 with another patch from Sudeep, solving the same > problem, but in a different way. Hi Sudeep and Lorenzo, Apologize for nagging you about reviews, again. Can you please have a look at the new version!? Kind regards Uffe > > This is the same coverletter as in v1: > > This series enables initial support for hierarchical CPU arrangement, managed > by PSCI and its corresponding cpuidle driver. It's based on using the generic > PM domain (genpd), which nowadays also supports devices belonging to CPUs. > > The last DTS patch enables the hierarchical topology to be used for the Qcom > 410c Dragonboard, which supports the PSCI OS-initiated mode. > > Do note, most of the code in this series have been posted earlier, but from the > latest version being reviewed, we agreed on that it was better to re-work the > PSCI backend driver as a first step, simply to get a clean interface towards the > cpuidle driver. > > Summary of the main-changes since the last submission [1]: > > - Moved implementation from the psci FW dricer into cpuidle-psci. > > - Re-requesting review of the DT bindings, as we have moved to yaml. No > changes as such, but tried to clarify a few things in the text. > > - Drop the patch enabling support for CPU hotplug, postponing that to the next > step. > > - Respect the hierarchical topology in DT only when OSI mode is supported. > This is to start simple and we can always extend the support on top. > > The series is also available at: > git.linaro.org/people/ulf.hansson/linux-pm.git next > > Kind regards > Ulf Hansson > > [1] > https://lwn.net/Articles/788306/ > > Lina Iyer (1): > cpuidle: dt: Support hierarchical CPU idle states > > Sudeep Holla (1): > cpuidle: psci: Align psci_power_state count with idle state count > > Ulf Hansson (11): > dt: psci: Update DT bindings to support hierarchical PSCI states > firmware: psci: Export functions to manage the OSI mode > of: base: Add of_get_cpu_state_node() to get idle states for a CPU > node > cpuidle: psci: Simplify OF parsing of CPU idle state nodes > cpuidle: psci: Support hierarchical CPU idle states > cpuidle: psci: Add a helper to attach a CPU to its PM domain > cpuidle: psci: Attach CPU devices to their PM domains > cpuidle: psci: Prepare to use OS initiated suspend mode via PM domains > cpuidle: psci: Manage runtime PM in the idle path > cpuidle: psci: Add support for PM domains by using genpd > arm64: dts: Convert to the hierarchical CPU topology layout for > MSM8916 > > .../devicetree/bindings/arm/cpus.yaml | 15 + > .../devicetree/bindings/arm/psci.yaml | 102 ++++++ > arch/arm64/boot/dts/qcom/msm8916.dtsi | 57 +++- > drivers/cpuidle/Makefile | 4 +- > drivers/cpuidle/cpuidle-psci-domain.c | 302 ++++++++++++++++++ > drivers/cpuidle/cpuidle-psci.c | 123 +++++-- > drivers/cpuidle/cpuidle-psci.h | 17 + > drivers/cpuidle/dt_idle_states.c | 5 +- > drivers/firmware/psci/psci.c | 18 +- > drivers/of/base.c | 36 +++ > include/linux/of.h | 8 + > include/linux/psci.h | 2 + > 12 files changed, 654 insertions(+), 35 deletions(-) > create mode 100644 drivers/cpuidle/cpuidle-psci-domain.c > create mode 100644 drivers/cpuidle/cpuidle-psci.h > > -- > 2.17.1 >
On Mon, Nov 11, 2019 at 12:00:52PM +0100, Ulf Hansson wrote: > On Tue, 29 Oct 2019 at 17:44, Ulf Hansson <ulf.hansson@linaro.org> wrote: > > > > Changes in v2: > > - Avoid to affect the non-OSI path with specific changes for OSI. This > > forced me to re-order the series and a caused more or less minor changes > > to most of the patches. > > - Updated the DT bindings for PSCI to clarify and to include the "psci" > > name of the PM domain to attach to. > > - Replaced patch1 with another patch from Sudeep, solving the same > > problem, but in a different way. > > Hi Sudeep and Lorenzo, > > Apologize for nagging you about reviews, again. Can you please have a > look at the new version!? I will take a look later this week, sorry for the delay. -- Regards, Sudeep
On Mon, 11 Nov 2019 at 12:00, Ulf Hansson <ulf.hansson@linaro.org> wrote: > > On Tue, 29 Oct 2019 at 17:44, Ulf Hansson <ulf.hansson@linaro.org> wrote: > > > > Changes in v2: > > - Avoid to affect the non-OSI path with specific changes for OSI. This > > forced me to re-order the series and a caused more or less minor changes > > to most of the patches. > > - Updated the DT bindings for PSCI to clarify and to include the "psci" > > name of the PM domain to attach to. > > - Replaced patch1 with another patch from Sudeep, solving the same > > problem, but in a different way. > > Hi Sudeep and Lorenzo, > > Apologize for nagging you about reviews, again. Can you please have a > look at the new version!? Lorenzo, apologize for nagging you about reviewing this series. It seems like both me and Sudeep are now waiting to hear from you, can you please have look. Kind regards Uffe
Changes in v2: - Avoid to affect the non-OSI path with specific changes for OSI. This forced me to re-order the series and a caused more or less minor changes to most of the patches. - Updated the DT bindings for PSCI to clarify and to include the "psci" name of the PM domain to attach to. - Replaced patch1 with another patch from Sudeep, solving the same problem, but in a different way. This is the same coverletter as in v1: This series enables initial support for hierarchical CPU arrangement, managed by PSCI and its corresponding cpuidle driver. It's based on using the generic PM domain (genpd), which nowadays also supports devices belonging to CPUs. The last DTS patch enables the hierarchical topology to be used for the Qcom 410c Dragonboard, which supports the PSCI OS-initiated mode. Do note, most of the code in this series have been posted earlier, but from the latest version being reviewed, we agreed on that it was better to re-work the PSCI backend driver as a first step, simply to get a clean interface towards the cpuidle driver. Summary of the main-changes since the last submission [1]: - Moved implementation from the psci FW dricer into cpuidle-psci. - Re-requesting review of the DT bindings, as we have moved to yaml. No changes as such, but tried to clarify a few things in the text. - Drop the patch enabling support for CPU hotplug, postponing that to the next step. - Respect the hierarchical topology in DT only when OSI mode is supported. This is to start simple and we can always extend the support on top. The series is also available at: git.linaro.org/people/ulf.hansson/linux-pm.git next Kind regards Ulf Hansson [1] https://lwn.net/Articles/788306/ Lina Iyer (1): cpuidle: dt: Support hierarchical CPU idle states Sudeep Holla (1): cpuidle: psci: Align psci_power_state count with idle state count Ulf Hansson (11): dt: psci: Update DT bindings to support hierarchical PSCI states firmware: psci: Export functions to manage the OSI mode of: base: Add of_get_cpu_state_node() to get idle states for a CPU node cpuidle: psci: Simplify OF parsing of CPU idle state nodes cpuidle: psci: Support hierarchical CPU idle states cpuidle: psci: Add a helper to attach a CPU to its PM domain cpuidle: psci: Attach CPU devices to their PM domains cpuidle: psci: Prepare to use OS initiated suspend mode via PM domains cpuidle: psci: Manage runtime PM in the idle path cpuidle: psci: Add support for PM domains by using genpd arm64: dts: Convert to the hierarchical CPU topology layout for MSM8916 .../devicetree/bindings/arm/cpus.yaml | 15 + .../devicetree/bindings/arm/psci.yaml | 102 ++++++ arch/arm64/boot/dts/qcom/msm8916.dtsi | 57 +++- drivers/cpuidle/Makefile | 4 +- drivers/cpuidle/cpuidle-psci-domain.c | 302 ++++++++++++++++++ drivers/cpuidle/cpuidle-psci.c | 123 +++++-- drivers/cpuidle/cpuidle-psci.h | 17 + drivers/cpuidle/dt_idle_states.c | 5 +- drivers/firmware/psci/psci.c | 18 +- drivers/of/base.c | 36 +++ include/linux/of.h | 8 + include/linux/psci.h | 2 + 12 files changed, 654 insertions(+), 35 deletions(-) create mode 100644 drivers/cpuidle/cpuidle-psci-domain.c create mode 100644 drivers/cpuidle/cpuidle-psci.h