mbox series

[0/2] SCMI performance protocol power scale interface

Message ID 20201124104346.27167-1-lukasz.luba@arm.com (mailing list archive)
Headers show
Series SCMI performance protocol power scale interface | expand

Message

Lukasz Luba Nov. 24, 2020, 10:43 a.m. UTC
Hi all,

The Energy Model (EM) supports power values expressed in an abstract scale
via new API. The SCMI performance protocol provides the information about
power scale. This patch set implements the needed interface and updates
cpufreq driver to set the right scale in the EM.

It is based on top of patch series adding milli-Watts flag in EM [1]
(next-20201124 was used as a base).

Regards,
Lukasz

[1] https://lore.kernel.org/linux-pm/20201103090600.29053-1-lukasz.luba@arm.com/

Lukasz Luba (2):
  firmware: arm_scmi: Add power_scale_mw_get() interface
  cpufreq: arm_scmi: Discover the power scale in performance protocol

 drivers/cpufreq/scmi-cpufreq.c   | 4 +++-
 drivers/firmware/arm_scmi/perf.c | 8 ++++++++
 include/linux/scmi_protocol.h    | 1 +
 3 files changed, 12 insertions(+), 1 deletion(-)

Comments

Lukasz Luba Nov. 25, 2020, 9:29 a.m. UTC | #1
Hi Rafael,

On 11/24/20 10:43 AM, Lukasz Luba wrote:
> Hi all,
> 
> The Energy Model (EM) supports power values expressed in an abstract scale
> via new API. The SCMI performance protocol provides the information about
> power scale. This patch set implements the needed interface and updates
> cpufreq driver to set the right scale in the EM.
> 
> It is based on top of patch series adding milli-Watts flag in EM [1]
> (next-20201124 was used as a base).
> 
> Regards,
> Lukasz
> 
> [1] https://lore.kernel.org/linux-pm/20201103090600.29053-1-lukasz.luba@arm.com/
> 
> Lukasz Luba (2):
>    firmware: arm_scmi: Add power_scale_mw_get() interface
>    cpufreq: arm_scmi: Discover the power scale in performance protocol
> 
>   drivers/cpufreq/scmi-cpufreq.c   | 4 +++-
>   drivers/firmware/arm_scmi/perf.c | 8 ++++++++
>   include/linux/scmi_protocol.h    | 1 +
>   3 files changed, 12 insertions(+), 1 deletion(-)
> 

Could you take this patch set, please?

Patch 1/2, which is ARM firmware protocol change, got ACK from Sudeep in
case it would go via your PM tree.

The patch series is a follow up to the EM changes, which you have taken
recently into your PM tree (link in the cover letter above).

Regards,
Lukasz
Viresh Kumar Dec. 7, 2020, 7:13 a.m. UTC | #2
On 24-11-20, 10:43, Lukasz Luba wrote:
> Hi all,
> 
> The Energy Model (EM) supports power values expressed in an abstract scale
> via new API. The SCMI performance protocol provides the information about
> power scale. This patch set implements the needed interface and updates
> cpufreq driver to set the right scale in the EM.
> 
> It is based on top of patch series adding milli-Watts flag in EM [1]
> (next-20201124 was used as a base).
> 
> Regards,
> Lukasz
> 
> [1] https://lore.kernel.org/linux-pm/20201103090600.29053-1-lukasz.luba@arm.com/
> 
> Lukasz Luba (2):
>   firmware: arm_scmi: Add power_scale_mw_get() interface
>   cpufreq: arm_scmi: Discover the power scale in performance protocol
> 
>  drivers/cpufreq/scmi-cpufreq.c   | 4 +++-
>  drivers/firmware/arm_scmi/perf.c | 8 ++++++++
>  include/linux/scmi_protocol.h    | 1 +
>  3 files changed, 12 insertions(+), 1 deletion(-)

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Viresh Kumar Dec. 8, 2020, 4:48 a.m. UTC | #3
On 07-12-20, 12:43, Viresh Kumar wrote:
> On 24-11-20, 10:43, Lukasz Luba wrote:
> > Hi all,
> > 
> > The Energy Model (EM) supports power values expressed in an abstract scale
> > via new API. The SCMI performance protocol provides the information about
> > power scale. This patch set implements the needed interface and updates
> > cpufreq driver to set the right scale in the EM.
> > 
> > It is based on top of patch series adding milli-Watts flag in EM [1]
> > (next-20201124 was used as a base).
> > 
> > Regards,
> > Lukasz
> > 
> > [1] https://lore.kernel.org/linux-pm/20201103090600.29053-1-lukasz.luba@arm.com/
> > 
> > Lukasz Luba (2):
> >   firmware: arm_scmi: Add power_scale_mw_get() interface
> >   cpufreq: arm_scmi: Discover the power scale in performance protocol
> > 
> >  drivers/cpufreq/scmi-cpufreq.c   | 4 +++-
> >  drivers/firmware/arm_scmi/perf.c | 8 ++++++++
> >  include/linux/scmi_protocol.h    | 1 +
> >  3 files changed, 12 insertions(+), 1 deletion(-)
> 
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

More scmi stuff came in which I had to apply and so I applied this to
the ARM tree.

Rafael: I had to rebase this over one of the patches from your tree,
which was based on rc3:

commit c250d50fe2ce ("PM: EM: Add a flag indicating units of power values in Energy Model")

I hope you won't rebase it any further.

Applied. Thanks.
Lukasz Luba Dec. 8, 2020, 8:36 a.m. UTC | #4
On 12/8/20 4:48 AM, Viresh Kumar wrote:
> On 07-12-20, 12:43, Viresh Kumar wrote:
>> On 24-11-20, 10:43, Lukasz Luba wrote:
>>> Hi all,
>>>
>>> The Energy Model (EM) supports power values expressed in an abstract scale
>>> via new API. The SCMI performance protocol provides the information about
>>> power scale. This patch set implements the needed interface and updates
>>> cpufreq driver to set the right scale in the EM.
>>>
>>> It is based on top of patch series adding milli-Watts flag in EM [1]
>>> (next-20201124 was used as a base).
>>>
>>> Regards,
>>> Lukasz
>>>
>>> [1] https://lore.kernel.org/linux-pm/20201103090600.29053-1-lukasz.luba@arm.com/
>>>
>>> Lukasz Luba (2):
>>>    firmware: arm_scmi: Add power_scale_mw_get() interface
>>>    cpufreq: arm_scmi: Discover the power scale in performance protocol
>>>
>>>   drivers/cpufreq/scmi-cpufreq.c   | 4 +++-
>>>   drivers/firmware/arm_scmi/perf.c | 8 ++++++++
>>>   include/linux/scmi_protocol.h    | 1 +
>>>   3 files changed, 12 insertions(+), 1 deletion(-)
>>
>> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> 
> More scmi stuff came in which I had to apply and so I applied this to
> the ARM tree.
> 
> Rafael: I had to rebase this over one of the patches from your tree,
> which was based on rc3:
> 
> commit c250d50fe2ce ("PM: EM: Add a flag indicating units of power values in Energy Model")
> 
> I hope you won't rebase it any further.
> 
> Applied. Thanks.
> 

Thank you Viresh!

Regards,
Lukasz