mbox series

[v3,0/2] mfd: rn5t618: Extend ADC support

Message ID 20210712212111.18896-1-andreas@kemnade.info (mailing list archive)
Headers show
Series mfd: rn5t618: Extend ADC support | expand

Message

Andreas Kemnade July 12, 2021, 9:21 p.m. UTC
Add iio map to make voltage_now related channels accessible to power
driver.

Changes in v3:
- use scale functions
- add acks

Changes in v2:
- use iio_map instead of devicetree to allow mapping which does not
  block future extension by devicetree.


*** BLURB HERE ***

Andreas Kemnade (2):
  iio: adc: rn5t618: Add iio map
  power: supply: rn5t618: Add voltage_now property

 drivers/iio/adc/rn5t618-adc.c        | 23 +++++++++++++++++
 drivers/power/supply/Kconfig         |  2 ++
 drivers/power/supply/rn5t618_power.c | 38 ++++++++++++++++++++++++++++
 3 files changed, 63 insertions(+)

Comments

Lee Jones July 13, 2021, 8:27 a.m. UTC | #1
On Mon, 12 Jul 2021, Andreas Kemnade wrote:

> Add iio map to make voltage_now related channels accessible to power
> driver.
> 
> Changes in v3:
> - use scale functions
> - add acks
> 
> Changes in v2:
> - use iio_map instead of devicetree to allow mapping which does not
>   block future extension by devicetree.
> 
> 
> *** BLURB HERE ***

Doh!

> Andreas Kemnade (2):
>   iio: adc: rn5t618: Add iio map
>   power: supply: rn5t618: Add voltage_now property
> 
>  drivers/iio/adc/rn5t618-adc.c        | 23 +++++++++++++++++
>  drivers/power/supply/Kconfig         |  2 ++
>  drivers/power/supply/rn5t618_power.c | 38 ++++++++++++++++++++++++++++
>  3 files changed, 63 insertions(+)

Not sure I get this.

Firstly, the cover-letter is marked as MFD, but no MFD changes occur.
Secondly, I am only in receipt of the 0th patch which seems odd.  IMHO
patch sets should be sent threaded and all parties should see
discussion on all patches regardless of whether they maintain them or
not, since the overall conversation is often useful/relevant to all.
Jonathan Cameron July 17, 2021, 5:08 p.m. UTC | #2
On Tue, 13 Jul 2021 09:27:27 +0100
Lee Jones <lee.jones@linaro.org> wrote:

> On Mon, 12 Jul 2021, Andreas Kemnade wrote:
> 
> > Add iio map to make voltage_now related channels accessible to power
> > driver.
> > 
> > Changes in v3:
> > - use scale functions
> > - add acks
> > 
> > Changes in v2:
> > - use iio_map instead of devicetree to allow mapping which does not
> >   block future extension by devicetree.
> > 
> > 
> > *** BLURB HERE ***  
> 
> Doh!
> 
> > Andreas Kemnade (2):
> >   iio: adc: rn5t618: Add iio map
> >   power: supply: rn5t618: Add voltage_now property
> > 
> >  drivers/iio/adc/rn5t618-adc.c        | 23 +++++++++++++++++
> >  drivers/power/supply/Kconfig         |  2 ++
> >  drivers/power/supply/rn5t618_power.c | 38 ++++++++++++++++++++++++++++
> >  3 files changed, 63 insertions(+)  
> 
> Not sure I get this.
> 
> Firstly, the cover-letter is marked as MFD, but no MFD changes occur.

So this is a bit of a fun corner case.  The series 'used' to include an mfd
change that made that labelling relevant.  Then that went away as I suggested
that we could do it in a simpler fashion.
Under the circumstances the series needed a rename!

> Secondly, I am only in receipt of the 0th patch which seems odd.  IMHO
> patch sets should be sent threaded and all parties should see
> discussion on all patches regardless of whether they maintain them or
> not, since the overall conversation is often useful/relevant to all.
> 
Absolutely agree for small series like this.

Anyhow, as far as I'm concerned this is now in the hands of the power supply
maintainers anyway so ignoring it ;)

Jonathan
Sebastian Reichel Aug. 13, 2021, 4 p.m. UTC | #3
Hi,

On Mon, Jul 12, 2021 at 11:21:09PM +0200, Andreas Kemnade wrote:
> Add iio map to make voltage_now related channels accessible to power
> driver.
> 
> Changes in v3:
> - use scale functions
> - add acks
> 
> Changes in v2:
> - use iio_map instead of devicetree to allow mapping which does not
>   block future extension by devicetree.

Thanks, queued.

-- Sebastian

> *** BLURB HERE ***

:)

> Andreas Kemnade (2):
>   iio: adc: rn5t618: Add iio map
>   power: supply: rn5t618: Add voltage_now property
> 
>  drivers/iio/adc/rn5t618-adc.c        | 23 +++++++++++++++++
>  drivers/power/supply/Kconfig         |  2 ++
>  drivers/power/supply/rn5t618_power.c | 38 ++++++++++++++++++++++++++++
>  3 files changed, 63 insertions(+)
> 
> -- 
> 2.30.2
>