| Message ID | 20210726132223.1661-1-sshivamurthy@micron.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Abrupt Shutdown for NVMe SSD | expand |
On Mon, Jul 26, 2021 at 01:22:21PM +0000, shiva.linuxworks@gmail.com wrote: > In the platform with a limited backup power supply, devices like NVMe > SSD does unsafe shutdown. > > These two patches address this issue by adding a power loss imminent > flag. The platform will enable the power loss imminent flag if the > platform's power is running on the limited backup power supply. During > the shutdown, the driver checks this information and pwerforms the > abrupt shutdown. I think the pm framework and nvme usage are ok, but you need a platform specific caller to set the new power loss flag before this should be considered, otherwise this is just unreachable code.
Micron Confidential Hi, > > > On Mon, Jul 26, 2021 at 01:22:21PM +0000, shiva.linuxworks@gmail.com wrote: > > In the platform with a limited backup power supply, devices like NVMe > > SSD does unsafe shutdown. > > > > These two patches address this issue by adding a power loss imminent > > flag. The platform will enable the power loss imminent flag if the > > platform's power is running on the limited backup power supply. During > > the shutdown, the driver checks this information and pwerforms the > > abrupt shutdown. > > I think the pm framework and nvme usage are ok, but you need a platform > specific caller to set the new power loss flag before this should be > considered, otherwise this is just unreachable code. Sure, I will send platform specific caller along with V3. Thanks, Shiva Micron Confidential
From: Shivamurthy Shastri <sshivamurthy@micron.com> In the platform with a limited backup power supply, devices like NVMe SSD does unsafe shutdown. These two patches address this issue by adding a power loss imminent flag. The platform will enable the power loss imminent flag if the platform's power is running on the limited backup power supply. During the shutdown, the driver checks this information and pwerforms the abrupt shutdown. Shivamurthy Shastri (2): PM: introduce power loss imminent nvme: Add abrupt shutdown support drivers/nvme/host/core.c | 7 ++++++- drivers/nvme/host/pci.c | 6 ++++-- include/linux/suspend.h | 28 +++++++++++++++++++++++++--- 3 files changed, 35 insertions(+), 6 deletions(-)