| Message ID | 20220708131412.81078-1-hdegoede@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Fix 2 5.19 power-off regressions caused by sys-off-handler work | expand |
On 7/8/22 16:14, Hans de Goede wrote: > Hi All, > > I noticed that my Lenovo Yoga Tablet 2 1050L was hanging on power-off again > with 5.19, even though I had implemented a workaround for this in 5.17 . > > I quickly realized that this was caused by the recent sys-off-handler work > and fixed this by switching the workaround over to register_sys_off_handler > with a priority of SYS_OFF_PRIO_FIRMWARE + 1, so that the workaround runs > before acpi_power_off() get a chance to run. > > This made me realize that the efi_power_off handler which sometimes is > used in preference of acpi_power_off had the same problem, so the second > patch in this series fixes that. > > I plan to include patch 1/2 in a fixes pull-req to Linus soon. Ard, > if I can get your Ack for 2/2 then I can include this in the pull-req > if you want; or you can send this to Linus yourself. > > Regards, > > Hans > > > Hans de Goede (2): > platform/x86: x86-android-tablets: Fix Lenovo Yoga Tablet 2 830/1050 > poweroff again > efi: Fix efi_power_off() not being run before acpi_power_off() when > necessary > > drivers/firmware/efi/reboot.c | 21 +++++++++++---------- > drivers/platform/x86/x86-android-tablets.c | 17 +++++++++++++---- > 2 files changed, 24 insertions(+), 14 deletions(-) > Thank you for the fixes. It's great that the RC is getting more testing since I couldn't test everything and we don't have CI for the power-off testing.
Hi, On 7/8/22 15:14, Hans de Goede wrote: > Hi All, > > I noticed that my Lenovo Yoga Tablet 2 1050L was hanging on power-off again > with 5.19, even though I had implemented a workaround for this in 5.17 . > > I quickly realized that this was caused by the recent sys-off-handler work > and fixed this by switching the workaround over to register_sys_off_handler > with a priority of SYS_OFF_PRIO_FIRMWARE + 1, so that the workaround runs > before acpi_power_off() get a chance to run. > > This made me realize that the efi_power_off handler which sometimes is > used in preference of acpi_power_off had the same problem, so the second > patch in this series fixes that. > > I plan to include patch 1/2 in a fixes pull-req to Linus soon. Ard, > if I can get your Ack for 2/2 then I can include this in the pull-req > if you want; or you can send this to Linus yourself. I've added these to my review-hans (soon to be for-next) branch now and I'll include them in my upcoming 5.19 fixes pull-req. Regards, Hans > > Regards, > > Hans > > > Hans de Goede (2): > platform/x86: x86-android-tablets: Fix Lenovo Yoga Tablet 2 830/1050 > poweroff again > efi: Fix efi_power_off() not being run before acpi_power_off() when > necessary > > drivers/firmware/efi/reboot.c | 21 +++++++++++---------- > drivers/platform/x86/x86-android-tablets.c | 17 +++++++++++++---- > 2 files changed, 24 insertions(+), 14 deletions(-) >
Hi All, I noticed that my Lenovo Yoga Tablet 2 1050L was hanging on power-off again with 5.19, even though I had implemented a workaround for this in 5.17 . I quickly realized that this was caused by the recent sys-off-handler work and fixed this by switching the workaround over to register_sys_off_handler with a priority of SYS_OFF_PRIO_FIRMWARE + 1, so that the workaround runs before acpi_power_off() get a chance to run. This made me realize that the efi_power_off handler which sometimes is used in preference of acpi_power_off had the same problem, so the second patch in this series fixes that. I plan to include patch 1/2 in a fixes pull-req to Linus soon. Ard, if I can get your Ack for 2/2 then I can include this in the pull-req if you want; or you can send this to Linus yourself. Regards, Hans Hans de Goede (2): platform/x86: x86-android-tablets: Fix Lenovo Yoga Tablet 2 830/1050 poweroff again efi: Fix efi_power_off() not being run before acpi_power_off() when necessary drivers/firmware/efi/reboot.c | 21 +++++++++++---------- drivers/platform/x86/x86-android-tablets.c | 17 +++++++++++++---- 2 files changed, 24 insertions(+), 14 deletions(-)