| Message ID | 20220722200007.1839356-1-daniel.lezcano@linexp.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | thermal OF rework | expand |
Hi Rafael, On 22/07/2022 21:59, Daniel Lezcano wrote: > The thermal framework initialization with the device tree appears to > be complicated and hard to make it to evolve. > > It contains duplication of almost the same thermal generic structures > and has an assymetric initialization making hard any kind of serious > changes for more complex features. One of them is the multiple sensors > support per thermal zone. > > In order to set the scene for the aforementioned feature with generic > code, we need to cleanup and rework the device tree initialization. > > However this rework is not obvious because of the multiple components > entering in the composition of a thermal zone and being initialized at > different moments. For instance, a cooling device can be initialized > before a sensor, so the thermal zones must exist before the cooling > device as well as the sensor. This asynchronous initialization forces > the thermal zone to be created with fake ops because they are > mandotory and build a list of cooling devices which is used to lookup > afterwards when the cooling device driver is registering itself. > > As there could be a large number of changes, this first series provide > some steps forward for a simpler device tree initialization. > > More series for cleanup and code duplication removal will follow. > > Changelog: > > - v6: > - Folded patches 8, 9, 10 > - Removed thermal_zone_get_trips() and thermal_zone_get_num_trips() > - Moved tz->ntrips => tz->num_trips changes into patch 11 to fix the > git bisecting > I believe all the comments were addressed, is it fine if I merge this series ?
Hi Daniel, On Mon, Jul 25, 2022 at 6:34 PM Daniel Lezcano <daniel.lezcano@linaro.org> wrote: > > > Hi Rafael, > > On 22/07/2022 21:59, Daniel Lezcano wrote: > > The thermal framework initialization with the device tree appears to > > be complicated and hard to make it to evolve. > > > > It contains duplication of almost the same thermal generic structures > > and has an assymetric initialization making hard any kind of serious > > changes for more complex features. One of them is the multiple sensors > > support per thermal zone. > > > > In order to set the scene for the aforementioned feature with generic > > code, we need to cleanup and rework the device tree initialization. > > > > However this rework is not obvious because of the multiple components > > entering in the composition of a thermal zone and being initialized at > > different moments. For instance, a cooling device can be initialized > > before a sensor, so the thermal zones must exist before the cooling > > device as well as the sensor. This asynchronous initialization forces > > the thermal zone to be created with fake ops because they are > > mandotory and build a list of cooling devices which is used to lookup > > afterwards when the cooling device driver is registering itself. > > > > As there could be a large number of changes, this first series provide > > some steps forward for a simpler device tree initialization. > > > > More series for cleanup and code duplication removal will follow. > > > > Changelog: > > > > - v6: > > - Folded patches 8, 9, 10 > > - Removed thermal_zone_get_trips() and thermal_zone_get_num_trips() > > - Moved tz->ntrips => tz->num_trips changes into patch 11 to fix the > > git bisecting > > > > I believe all the comments were addressed, is it fine if I merge this > series ? Yes, please!
Hi Daniel, On 7/25/22 17:34, Daniel Lezcano wrote: > > Hi Rafael, > > On 22/07/2022 21:59, Daniel Lezcano wrote: >> The thermal framework initialization with the device tree appears to >> be complicated and hard to make it to evolve. >> >> It contains duplication of almost the same thermal generic structures >> and has an assymetric initialization making hard any kind of serious >> changes for more complex features. One of them is the multiple sensors >> support per thermal zone. >> >> In order to set the scene for the aforementioned feature with generic >> code, we need to cleanup and rework the device tree initialization. >> >> However this rework is not obvious because of the multiple components >> entering in the composition of a thermal zone and being initialized at >> different moments. For instance, a cooling device can be initialized >> before a sensor, so the thermal zones must exist before the cooling >> device as well as the sensor. This asynchronous initialization forces >> the thermal zone to be created with fake ops because they are >> mandotory and build a list of cooling devices which is used to lookup >> afterwards when the cooling device driver is registering itself. >> >> As there could be a large number of changes, this first series provide >> some steps forward for a simpler device tree initialization. >> >> More series for cleanup and code duplication removal will follow. >> >> Changelog: >> >> - v6: >> - Folded patches 8, 9, 10 >> - Removed thermal_zone_get_trips() and thermal_zone_get_num_trips() >> - Moved tz->ntrips => tz->num_trips changes into patch 11 to fix the >> git bisecting >> > > I believe all the comments were addressed, is it fine if I merge this > series ? > > My apologies for being quiet, I was on holiday last week. Please don't wait for me, I'm still catching up with internal stuff. Based on your changelog I can see you've addressed my comments. Regards, Lukasz
The thermal framework initialization with the device tree appears to be complicated and hard to make it to evolve. It contains duplication of almost the same thermal generic structures and has an assymetric initialization making hard any kind of serious changes for more complex features. One of them is the multiple sensors support per thermal zone. In order to set the scene for the aforementioned feature with generic code, we need to cleanup and rework the device tree initialization. However this rework is not obvious because of the multiple components entering in the composition of a thermal zone and being initialized at different moments. For instance, a cooling device can be initialized before a sensor, so the thermal zones must exist before the cooling device as well as the sensor. This asynchronous initialization forces the thermal zone to be created with fake ops because they are mandotory and build a list of cooling devices which is used to lookup afterwards when the cooling device driver is registering itself. As there could be a large number of changes, this first series provide some steps forward for a simpler device tree initialization. More series for cleanup and code duplication removal will follow. Changelog: - v6: - Folded patches 8, 9, 10 - Removed thermal_zone_get_trips() and thermal_zone_get_num_trips() - Moved tz->ntrips => tz->num_trips changes into patch 11 to fix the git bisecting - v5: - Remove extra of_node_put() reported by lkp - V4: - Added of_node_put(trips) - Changed naming 'ntrips' -> 'num_trips' - Updated documentation for added and renamed fields in the thermal zone structure - Fixed bad parameter type 'thermal_zone' -> 'thermal_zone_device' - Clarified there is more cleanups coming in the changelog - Put 'trips' and 'num_trips' fields all together - Made git-bisect safe the series - V3: - Removed patch 1 and 2 from the V2 which consist in renaming the thermal_zone_device_ops to thermal_sensor_ops and separating the structure. I'll do a separate proposal for that after the incoming cleanups - V2: - Drop patch 1/15 which contains too many changes for a simple structure renaming. This could be addressed in a separate series as it is not necessary for the OF rework - Fixed of_node_put with gchild not initialized as reported by kbuild and Dan Carpenter - V1: - Initial post Daniel Lezcano (10): thermal/core: Remove duplicate information when an error occurs thermal/of: Replace device node match with device node search thermal/of: Remove the device node pointer for thermal_trip thermal/of: Move thermal_trip structure to thermal.h thermal/core: Remove unneeded EXPORT_SYMBOLS thermal/core: Move thermal_set_delay_jiffies to static thermal/core: Rename 'trips' to 'num_trips' thermal/core: Add thermal_trip in thermal_zone thermal/of: Use thermal trips stored in the thermal zone thermal/of: Initialize trip points separately drivers/thermal/gov_fair_share.c | 6 +- drivers/thermal/gov_power_allocator.c | 4 +- drivers/thermal/tegra/tegra30-tsensor.c | 2 +- drivers/thermal/thermal_core.c | 53 +++++-- drivers/thermal/thermal_core.h | 15 -- drivers/thermal/thermal_helpers.c | 13 +- drivers/thermal/thermal_netlink.c | 2 +- drivers/thermal/thermal_of.c | 201 +++++++++++++----------- drivers/thermal/thermal_sysfs.c | 22 +-- include/linux/thermal.h | 24 ++- 10 files changed, 189 insertions(+), 153 deletions(-)