[0/2] Save cpuhp dynamic state

Message

Pierre Gondois Sept. 14, 2022, 4:28 p.m. UTC

Requesting a CPUHP_AP_ONLINE_DYN cpuhp state reserves a state
among the range [CPUHP_AP_ONLINE_DYN:CPUHP_AP_ONLINE_DYN_END].
The reserved state must be saved in order to remove it later.

Cf. __cpuhp_setup_state_cpuslocked() documentation:
Return:
  On success:
    Positive state number if @state is CPUHP_AP_ONLINE_DYN;
    0 for all other states

Indeed, the following:
  cpuhp_remove_state(CPUHP_AP_ONLINE_DYN);
removes the first dynamic states added to the cpuhp state machine.

Patches were tested as:
- powercap/drivers/dtpm: on a Juno-r2, using a late_initcall()
  to init and exit the dtpm framework.
- driver: soc: xilinx: the patch was only compile tested
  due to missing hardware.

Pierre Gondois (2):
  driver: soc: xilinx: Save cpuhp dynamic state
  powercap/drivers/dtpm: Save cpuhp dynamic state

 drivers/powercap/dtpm_cpu.c             |  7 ++++++-
 drivers/soc/xilinx/xlnx_event_manager.c | 12 ++++++++++--
 2 files changed, 16 insertions(+), 3 deletions(-)

Comments

Pierre Gondois Oct. 6, 2022, 7:54 a.m. UTC | #1

Hello,
Just a ping in case this was forgotten,

Regards,
Pierre

On 9/14/22 18:28, Pierre Gondois wrote:
> Requesting a CPUHP_AP_ONLINE_DYN cpuhp state reserves a state
> among the range [CPUHP_AP_ONLINE_DYN:CPUHP_AP_ONLINE_DYN_END].
> The reserved state must be saved in order to remove it later.
> 
> Cf. __cpuhp_setup_state_cpuslocked() documentation:
> Return:
>    On success:
>      Positive state number if @state is CPUHP_AP_ONLINE_DYN;
>      0 for all other states
> 
> Indeed, the following:
>    cpuhp_remove_state(CPUHP_AP_ONLINE_DYN);
> removes the first dynamic states added to the cpuhp state machine.
> 
> Patches were tested as:
> - powercap/drivers/dtpm: on a Juno-r2, using a late_initcall()
>    to init and exit the dtpm framework.
> - driver: soc: xilinx: the patch was only compile tested
>    due to missing hardware.
> 
> Pierre Gondois (2):
>    driver: soc: xilinx: Save cpuhp dynamic state
>    powercap/drivers/dtpm: Save cpuhp dynamic state
> 
>   drivers/powercap/dtpm_cpu.c             |  7 ++++++-
>   drivers/soc/xilinx/xlnx_event_manager.c | 12 ++++++++++--
>   2 files changed, 16 insertions(+), 3 deletions(-)
>

Pierre Gondois Feb. 1, 2023, 4:20 p.m. UTC | #2

Hello Daniel, Abhyuday,
Another ping just in case,

Regards,
Pierre

On 10/6/22 09:54, Pierre Gondois wrote:
> Hello,
> Just a ping in case this was forgotten,
> 
> Regards,
> Pierre
> 
> On 9/14/22 18:28, Pierre Gondois wrote:
>> Requesting a CPUHP_AP_ONLINE_DYN cpuhp state reserves a state
>> among the range [CPUHP_AP_ONLINE_DYN:CPUHP_AP_ONLINE_DYN_END].
>> The reserved state must be saved in order to remove it later.
>>
>> Cf. __cpuhp_setup_state_cpuslocked() documentation:
>> Return:
>>     On success:
>>       Positive state number if @state is CPUHP_AP_ONLINE_DYN;
>>       0 for all other states
>>
>> Indeed, the following:
>>     cpuhp_remove_state(CPUHP_AP_ONLINE_DYN);
>> removes the first dynamic states added to the cpuhp state machine.
>>
>> Patches were tested as:
>> - powercap/drivers/dtpm: on a Juno-r2, using a late_initcall()
>>     to init and exit the dtpm framework.
>> - driver: soc: xilinx: the patch was only compile tested
>>     due to missing hardware.
>>
>> Pierre Gondois (2):
>>     driver: soc: xilinx: Save cpuhp dynamic state
>>     powercap/drivers/dtpm: Save cpuhp dynamic state
>>
>>    drivers/powercap/dtpm_cpu.c             |  7 ++++++-
>>    drivers/soc/xilinx/xlnx_event_manager.c | 12 ++++++++++--
>>    2 files changed, 16 insertions(+), 3 deletions(-)
>>