From patchwork Mon Feb 6 17:21:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wyes Karny X-Patchwork-Id: 13130401 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FF96C05027 for ; Mon, 6 Feb 2023 17:22:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230092AbjBFRW2 (ORCPT ); Mon, 6 Feb 2023 12:22:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229573AbjBFRW1 (ORCPT ); Mon, 6 Feb 2023 12:22:27 -0500 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CBFE02917F; Mon, 6 Feb 2023 09:22:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j7Li5eUQx+xwSV7yHTE2j7PMGaZ5FFhNRM8kflIYQBiSoe2fDghrxYhu4OXIcJ1ZEYxuo0feK3teKRQNHE1irDPE/nZU+UpnnNoqLfDIxncUm7omvdIvt3maW0bYVM5RfGPPpcEa3SkgWYo+fFNMGYm1UrY80gO20lc7G6yGw8X5PJSAH2rBi8Zwv7W9LwSKYR6r4YWQWoyhhg2u7dbsMI+UaB14FmBqSRStFTjJfcWxyUQMWknTbcBIqy6MLjkGG1t317A190sw1XSZJySnUOxLt5WNp6ra2N9SKmDUoU5yW//if3uyFx/nd5BUBRl9dzrrJQKaOko6YwtvV6IGxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/gMA2AwGuEpdjyDomVuavhKIRZBmsCJXUgolOYg5XYo=; b=VFywqQwvQm1oaE0o6rhl8SXMAXi80lnriCKKxkVB38I9EGPlkR00+h3ZVGNnkcKwNhWDxDeeQJfFIEdOpp2FPrYMsZaQhQt08hyjb6jw25GZoP8mb4WmWI23VugrsZ965ZOFCpw1j48ld6YkS07/8Cky9dCt5kNLF5bARsA52jq2tY8qVd664OrE2SVIcDR6W1iKhFOcUTf0ypShBLuzGV8WgzwZgFcDqch3gScC3oVOjA+n3B3/37ut8C/Dz1ONiHahy02BQP5ymcXi8VSJpftibbDWD/g5i3VMAKi/IAk1TK3xmNRQ8IBpaI1WNeT0mDkcASFhK50gPpLn9fNb7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/gMA2AwGuEpdjyDomVuavhKIRZBmsCJXUgolOYg5XYo=; b=zyMMb3ODp7nWrUE5K8KWelMVo38invg3L1XTObVQPfu8cVC8AUWA9SsNSHWC2s2ZFwIPbboUH75rr1TNXe4xCH3PS7RiA0qcUMDCXo0joipv1NgNcYmB5+lf7JxQPsZkOEehtkNPTygZOQa/Fuyc72VlaiM82uo9eZLREpNySQ8= Received: from DM5PR08CA0043.namprd08.prod.outlook.com (2603:10b6:4:60::32) by BN9PR12MB5291.namprd12.prod.outlook.com (2603:10b6:408:104::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Mon, 6 Feb 2023 17:22:19 +0000 Received: from DS1PEPF0000B07A.namprd05.prod.outlook.com (2603:10b6:4:60:cafe::97) by DM5PR08CA0043.outlook.office365.com (2603:10b6:4:60::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34 via Frontend Transport; Mon, 6 Feb 2023 17:22:19 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DS1PEPF0000B07A.mail.protection.outlook.com (10.167.17.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6064.17 via Frontend Transport; Mon, 6 Feb 2023 17:22:18 +0000 Received: from beas.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 6 Feb 2023 11:22:13 -0600 From: Wyes Karny To: Rafael J Wysocki , Huang Rui , Jonathan Corbet , Viresh Kumar , , CC: , , , Bagas Sanjaya , , Len Brown , Robert Moore , Borislav Petkov , Ananth Narayan , , Tor Vic , Wyes Karny Subject: [PATCH v6 0/6] amd_pstate: Add guided autonomous mode support Date: Mon, 6 Feb 2023 17:21:51 +0000 Message-ID: <20230206172157.49887-1-wyes.karny@amd.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF0000B07A:EE_|BN9PR12MB5291:EE_ X-MS-Office365-Filtering-Correlation-Id: 965408e0-7336-4c52-c3a3-08db0866b359 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mSQNGaaTW1kJg3SrNptJoB8ZCZKhyBvBH+1frxcktWCTTQX97RoIO+K742+shFwOaAsBwOJSWVH3WEKToX1EEuK+kxsb2Qzlel7cM2YIdrLDYY58hwJs/upLacUBzXkk20PrvsSsSi1pZ511JKNbewUEBOkbOUIDnRAK855Hxv3JANPAgRk/ouiCTn8+JcFio0oh8hKy/sQ29aGzJNjFfQSjCatO23O6A2wVspW5wQSjJ1tuASPgkLYQJq5c+0QI39K8uYFlFnYwIzXhHlnlnBw0/sUG71U0YpYkshw2/Hwc2WuExDVsxD+1ywgt3lgUvv8p/g2ifHAltbAdNEFd9mBQcQagyk5kNiSuTw6TfuMQMvtQ6+Cjk6xWL0ay/7pDL1C2M9PSRAi2u+tTMKFNltCgB5spOyg84Qgs/FL1as+zmPMWKe79zkBZQ+Y+zUt644yDEoDrE6aj2rtZ8o89ZIYdDTFOmhV3DZ9S7q/5OVIiTXZIn9UXi5PsckbRPDEe3pqTaEDbCpjS0rwUPhB1i1C5Q3w1tvVlJ0T3bVQkaOjqRwlrU6mWJf4eQv7T3CQwQNmOmqYqR5ZIQL2X6725uVfWFhFF6CTUHSa+MLgqhOKBai1RX1wyXXlT+YUrP56lCE5Erxw378KZCcYGNlFeYrT0m0b+aP2bnZe6GGMDMvQBKPlkrgtyfiUhmsHixCWAmop44rKJjDCyhMh+E3GUq7Rrm9gOs1sGtYkM1r/NJMYSwFfoVUoFDs545a5QI3ZgoV2MpW1xuMAqHOc+WtaAnlFcJFa57Acf6YOZB1v6zsPI0WzOyvrdZVNsDiJ7XpSw X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(376002)(346002)(396003)(136003)(451199018)(46966006)(36840700001)(40470700004)(36756003)(966005)(4326008)(70586007)(70206006)(356005)(8676002)(81166007)(47076005)(110136005)(54906003)(6636002)(316002)(36860700001)(82740400003)(7696005)(26005)(1076003)(16526019)(6666004)(40460700003)(5660300002)(44832011)(186003)(7416002)(86362001)(40480700001)(82310400005)(426003)(83380400001)(8936002)(336012)(2616005)(478600001)(41300700001)(2906002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2023 17:22:18.9716 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 965408e0-7336-4c52-c3a3-08db0866b359 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF0000B07A.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5291 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org From ACPI spec[1] below 3 modes for CPPC can be defined: 1. Non autonomous: OS scaling governor specifies operating frequency/ performance level through `Desired Performance` register and platform follows that. 2. Guided autonomous: OS scaling governor specifies min and max frequencies/ performance levels through `Minimum Performance` and `Maximum Performance` register, and platform can autonomously select an operating frequency in this range. 3. Fully autonomous: OS only hints (via EPP) to platform for the required energy performance preference for the workload and platform autonomously scales the frequency. Currently (1) is supported by amd_pstate as passive mode, and (3) is implemented by EPP support[2]. This change is to support (2). In guided autonomous mode the min_perf is based on the input from the scaling governor. For example, in case of schedutil this value depends on the current utilization. And max_perf is set to max capacity. To activate guided auto mode ``amd_pstate=guided`` command line parameter has to be passed in the kernel. Below are the results (normalized) of benchmarks with this patch: System: Genoa 96C 192T Kernel: 6.2.0-rc2 + EPP v12 + patch Scaling governor: schedutil ================ dbench comparisons ================ dbench result comparison: Here results are throughput (MB/s) Clients: acpi-cpufreq amd_pst+passive amd_pst+guided 1 1.00 (0.00 pct) 1.01 (1.00 pct) 1.02 (2.00 pct) 2 1.07 (0.00 pct) 1.06 (-0.93 pct) 1.07 (0.00 pct) 4 1.68 (0.00 pct) 1.70 (1.19 pct) 1.72 (2.38 pct) 8 2.61 (0.00 pct) 2.68 (2.68 pct) 2.76 (5.74 pct) 16 4.16 (0.00 pct) 4.24 (1.92 pct) 4.53 (8.89 pct) 32 5.98 (0.00 pct) 6.17 (3.17 pct) 7.30 (22.07 pct) 64 8.67 (0.00 pct) 8.99 (3.69 pct) 10.71 (23.52 pct) 128 11.98 (0.00 pct) 12.52 (4.50 pct) 14.67 (22.45 pct) 256 15.73 (0.00 pct) 16.13 (2.54 pct) 17.81 (13.22 pct) 512 15.77 (0.00 pct) 16.32 (3.48 pct) 16.39 (3.93 pct) dbench power comparison: Clients: acpi-cpufreq amd_pst+passive amd_pst+guided 1 1.00 (0.00 pct) 1.00 (0.00 pct) 1.04 (4.00 pct) 2 0.99 (0.00 pct) 0.97 (-2.02 pct) 1.02 (3.03 pct) 4 0.98 (0.00 pct) 0.98 (0.00 pct) 1.02 (4.08 pct) 8 0.98 (0.00 pct) 0.99 (1.02 pct) 1.02 (4.08 pct) 16 0.99 (0.00 pct) 1.00 (1.01 pct) 1.04 (5.05 pct) 32 1.02 (0.00 pct) 1.02 (0.00 pct) 1.07 (4.90 pct) 64 1.05 (0.00 pct) 1.05 (0.00 pct) 1.11 (5.71 pct) 128 1.08 (0.00 pct) 1.08 (0.00 pct) 1.15 (6.48 pct) 256 1.12 (0.00 pct) 1.12 (0.00 pct) 1.20 (7.14 pct) 512 1.18 (0.00 pct) 1.17 (-0.84 pct) 1.26 (6.77 pct) ================ git-source comparisons ================ git-source result comparison: Here results are throughput (compilations per 1000 sec) Threads: acpi-cpufreq amd_pst+passive amd_pst+guided 192 1.00 (0.00 pct) 0.93 (-7.00 pct) 1.00 (0.00 pct) git-source power comparison: Threads: acpi-cpufreq amd_pst+passive amd_pst+guided 192 1.00 (0.00 pct) 1.00 (0.00 pct) 0.96 (-4.00 pct) ================ kernbench comparisons ================ kernbench result comparison: Here results are throughput (compilations per 1000 sec) Load: acpi-cpufreq amd_pst+passive amd_pst+guided 32 1.00 (0.00 pct) 1.01 (1.00 pct) 1.02 (2.00 pct) 48 1.26 (0.00 pct) 1.28 (1.58 pct) 1.25 (-0.79 pct) 64 1.39 (0.00 pct) 1.47 (5.75 pct) 1.43 (2.87 pct) 96 1.48 (0.00 pct) 1.50 (1.35 pct) 1.49 (0.67 pct) 128 1.29 (0.00 pct) 1.32 (2.32 pct) 1.33 (3.10 pct) 192 1.17 (0.00 pct) 1.20 (2.56 pct) 1.21 (3.41 pct) 256 1.17 (0.00 pct) 1.18 (0.85 pct) 1.20 (2.56 pct) 384 1.16 (0.00 pct) 1.17 (0.86 pct) 1.21 (4.31 pct) kernbench power comparison: Clients: acpi-cpufreq amd_pst+passive amd_pst+guided 32 1.00 (0.00 pct) 0.97 (-3.00 pct) 1.00 (0.00 pct) 48 0.87 (0.00 pct) 0.81 (-6.89 pct) 0.88 (1.14 pct) 64 0.81 (0.00 pct) 0.73 (-9.87 pct) 0.77 (-4.93 pct) 96 0.75 (0.00 pct) 0.74 (-1.33 pct) 0.75 (0.00 pct) 128 0.83 (0.00 pct) 0.79 (-4.81 pct) 0.83 (0.00 pct) 192 0.92 (0.00 pct) 0.88 (-4.34 pct) 0.92 (0.00 pct) 256 0.92 (0.00 pct) 0.88 (-4.34 pct) 0.92 (0.00 pct) 384 0.92 (0.00 pct) 0.88 (-4.34 pct) 0.92 (0.00 pct) ================ tbench comparisons ================ tbench result comparison: Here results are throughput (MB/s) Clients: acpi-cpufreq amd_pst+passive amd_pst+guided 1 1.00 (0.00 pct) 0.70 (-30.00 pct) 1.37 (37.00 pct) 2 2.64 (0.00 pct) 1.39 (-47.34 pct) 2.70 (2.27 pct) 4 4.89 (0.00 pct) 2.75 (-43.76 pct) 5.28 (7.97 pct) 8 9.46 (0.00 pct) 5.42 (-42.70 pct) 10.22 (8.03 pct) 16 19.05 (0.00 pct) 10.42 (-45.30 pct) 19.94 (4.67 pct) 32 37.50 (0.00 pct) 20.23 (-46.05 pct) 36.87 (-1.68 pct) 64 61.24 (0.00 pct) 43.08 (-29.65 pct) 62.96 (2.80 pct) 128 67.16 (0.00 pct) 69.08 (2.85 pct) 67.34 (0.26 pct) 256 154.59 (0.00 pct) 162.33 (5.00 pct) 156.78 (1.41 pct) 512 154.02 (0.00 pct) 156.74 (1.76 pct) 153.48 (-0.35 pct) tbench power comparison: Clients: acpi-cpufreq amd_pst+passive amd_pst+guided 1 1.00 (0.00 pct) 0.97 (-3.00 pct) 1.08 (8.00 pct) 2 1.04 (0.00 pct) 0.97 (-6.73 pct) 1.11 (6.73 pct) 4 1.12 (0.00 pct) 0.99 (-11.60 pct) 1.18 (5.35 pct) 8 1.25 (0.00 pct) 1.04 (-16.80 pct) 1.31 (4.80 pct) 16 1.53 (0.00 pct) 1.13 (-26.14 pct) 1.58 (3.26 pct) 32 2.01 (0.00 pct) 1.36 (-32.33 pct) 2.03 (0.99 pct) 64 2.58 (0.00 pct) 2.14 (-17.05 pct) 2.61 (1.16 pct) 128 2.80 (0.00 pct) 2.81 (0.35 pct) 2.81 (0.35 pct) 256 3.39 (0.00 pct) 3.43 (1.17 pct) 3.42 (0.88 pct) 512 3.44 (0.00 pct) 3.44 (0.00 pct) 3.44 (0.00 pct) Note: this series is based on top of EPP v12 [3] series Change log: v5 -> v6 - Don't return -EBUSY when changing to same mode v4 -> v5: - Rebased on top of EPP v12 series - Addressed comments form Mario regarding documentation - Picked up RB flags from Mario and Bagas Sanjaya v3 -> v4: - Fixed active mode low frequency issue reported by Peter Jung and Tor Vic - Documentation modification suggested by Bagas Sanjaya v2 -> v3: - Addressed review comments form Mario. - Picked up RB tag from Mario. - Rebase on top of EPP v11 [3]. v1 -> v2: - Fix issue with shared mem systems. - Rebase on top of EPP series. [1]: https://uefi.org/sites/default/files/resources/ACPI_6_3_final_Jan30.pdf [2]: https://lore.kernel.org/lkml/20221110175847.3098728-1-Perry.Yuan@amd.com/ [3]: https://lore.kernel.org/linux-pm/20230131090016.3970625-1-perry.yuan@amd.com/ Wyes Karny (6): acpi: cppc: Add min and max perf reg writing support acpi: cppc: Add auto select register read/write support cpufreq: amd_pstate: Add guided autonomous mode Documentation: amd_pstate: Move amd_pstate param to alphabetical order cpufreq: amd_pstate: Add guided mode control support via sysfs Documentation: amd_pstate: Update amd_pstate status sysfs for guided .../admin-guide/kernel-parameters.txt | 41 ++-- Documentation/admin-guide/pm/amd-pstate.rst | 31 ++- drivers/acpi/cppc_acpi.c | 121 +++++++++++- drivers/cpufreq/amd-pstate.c | 183 +++++++++++++----- include/acpi/cppc_acpi.h | 11 ++ include/linux/amd-pstate.h | 2 + 6 files changed, 308 insertions(+), 81 deletions(-)