| Message ID | 20230414125721.1043589-1-thierry.reding@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | thermal: tegra: Do not register cooling device | expand |
Hi Thierry, are you planning to send a new version ? On 14/04/2023 14:57, Thierry Reding wrote: > From: Thierry Reding <treding@nvidia.com> > > Hi, > > this set of patches removes the registration of the SOCTHERM internal > throttling mechanism as cooling device. Since this throttling starts > automatically once a certain temperature threshold is crossed, it > doesn't make sense to represent it as a cooling device, which are > typically "manually" activated by the thermal framework when thermal > sensors report temperature thresholds being crossed. > > Instead of using the cooling device mechanism, this statically programs > the throttling mechanism when it is configured in device tree. In order > to do this, an additional device tree property is needed to replace the > information that was previously contained in trip points. > > There's a few preparatory patches to make the removal a bit simpler and > also some follow up cleanups included as well. > > Thierry > > Thierry Reding (10): > dt-bindings: thermal: tegra: Document throttle temperature > thermal: tegra: Use driver-private data consistently > thermal: tegra: Constify SoC-specific data > thermal: tegra: Do not register cooling device > thermal: tegra: Use unsigned int where appropriate > thermal: tegra: Avoid over-allocation of temporary array > thermal: tegra: Remove gratuitous error assignment > thermal: tegra: Minor stylistic cleanups > arm64: tegra: Rework SOCTHERM on Tegra132 and Tegra210 > ARM: tegra: Rework SOCTHERM on Tegra124 > > .../thermal/nvidia,tegra124-soctherm.yaml | 7 + > arch/arm/boot/dts/tegra124.dtsi | 65 +-- > arch/arm64/boot/dts/nvidia/tegra132.dtsi | 63 +-- > arch/arm64/boot/dts/nvidia/tegra210.dtsi | 83 +--- > drivers/thermal/tegra/soctherm.c | 392 ++++++------------ > drivers/thermal/tegra/soctherm.h | 1 + > drivers/thermal/tegra/tegra124-soctherm.c | 4 + > drivers/thermal/tegra/tegra132-soctherm.c | 4 + > drivers/thermal/tegra/tegra210-soctherm.c | 4 + > 9 files changed, 208 insertions(+), 415 deletions(-) >
Hi Thierry, do you have an update for this series? Thanks -- Daniel On 14/04/2023 14:57, Thierry Reding wrote: > From: Thierry Reding <treding@nvidia.com> > > Hi, > > this set of patches removes the registration of the SOCTHERM internal > throttling mechanism as cooling device. Since this throttling starts > automatically once a certain temperature threshold is crossed, it > doesn't make sense to represent it as a cooling device, which are > typically "manually" activated by the thermal framework when thermal > sensors report temperature thresholds being crossed. > > Instead of using the cooling device mechanism, this statically programs > the throttling mechanism when it is configured in device tree. In order > to do this, an additional device tree property is needed to replace the > information that was previously contained in trip points. > > There's a few preparatory patches to make the removal a bit simpler and > also some follow up cleanups included as well. > > Thierry > > Thierry Reding (10): > dt-bindings: thermal: tegra: Document throttle temperature > thermal: tegra: Use driver-private data consistently > thermal: tegra: Constify SoC-specific data > thermal: tegra: Do not register cooling device > thermal: tegra: Use unsigned int where appropriate > thermal: tegra: Avoid over-allocation of temporary array > thermal: tegra: Remove gratuitous error assignment > thermal: tegra: Minor stylistic cleanups > arm64: tegra: Rework SOCTHERM on Tegra132 and Tegra210 > ARM: tegra: Rework SOCTHERM on Tegra124 > > .../thermal/nvidia,tegra124-soctherm.yaml | 7 + > arch/arm/boot/dts/tegra124.dtsi | 65 +-- > arch/arm64/boot/dts/nvidia/tegra132.dtsi | 63 +-- > arch/arm64/boot/dts/nvidia/tegra210.dtsi | 83 +--- > drivers/thermal/tegra/soctherm.c | 392 ++++++------------ > drivers/thermal/tegra/soctherm.h | 1 + > drivers/thermal/tegra/tegra124-soctherm.c | 4 + > drivers/thermal/tegra/tegra132-soctherm.c | 4 + > drivers/thermal/tegra/tegra210-soctherm.c | 4 + > 9 files changed, 208 insertions(+), 415 deletions(-) >
On Tue, Jul 11, 2023 at 10:25:16AM +0200, Daniel Lezcano wrote: > Hi Thierry, > > do you have an update for this series? Yeah, I've been working on this on and off for a while since I ran into some complications with this version. I need to find a block of spare time to go over the latest version again and do some testing. Hopefully I can get around to that within this week or next. Thierry
On 11/07/2023 17:42, Thierry Reding wrote: > On Tue, Jul 11, 2023 at 10:25:16AM +0200, Daniel Lezcano wrote: >> Hi Thierry, >> >> do you have an update for this series? > > Yeah, I've been working on this on and off for a while since I ran into > some complications with this version. I need to find a block of spare > time to go over the latest version again and do some testing. Hopefully > I can get around to that within this week or next. That is great, thanks !
From: Thierry Reding <treding@nvidia.com> Hi, this set of patches removes the registration of the SOCTHERM internal throttling mechanism as cooling device. Since this throttling starts automatically once a certain temperature threshold is crossed, it doesn't make sense to represent it as a cooling device, which are typically "manually" activated by the thermal framework when thermal sensors report temperature thresholds being crossed. Instead of using the cooling device mechanism, this statically programs the throttling mechanism when it is configured in device tree. In order to do this, an additional device tree property is needed to replace the information that was previously contained in trip points. There's a few preparatory patches to make the removal a bit simpler and also some follow up cleanups included as well. Thierry Thierry Reding (10): dt-bindings: thermal: tegra: Document throttle temperature thermal: tegra: Use driver-private data consistently thermal: tegra: Constify SoC-specific data thermal: tegra: Do not register cooling device thermal: tegra: Use unsigned int where appropriate thermal: tegra: Avoid over-allocation of temporary array thermal: tegra: Remove gratuitous error assignment thermal: tegra: Minor stylistic cleanups arm64: tegra: Rework SOCTHERM on Tegra132 and Tegra210 ARM: tegra: Rework SOCTHERM on Tegra124 .../thermal/nvidia,tegra124-soctherm.yaml | 7 + arch/arm/boot/dts/tegra124.dtsi | 65 +-- arch/arm64/boot/dts/nvidia/tegra132.dtsi | 63 +-- arch/arm64/boot/dts/nvidia/tegra210.dtsi | 83 +--- drivers/thermal/tegra/soctherm.c | 392 ++++++------------ drivers/thermal/tegra/soctherm.h | 1 + drivers/thermal/tegra/tegra124-soctherm.c | 4 + drivers/thermal/tegra/tegra132-soctherm.c | 4 + drivers/thermal/tegra/tegra210-soctherm.c | 4 + 9 files changed, 208 insertions(+), 415 deletions(-)