From patchwork Fri Aug 4 11:50:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dhruva Gole X-Patchwork-Id: 13341721 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCE98C04A94 for ; Fri, 4 Aug 2023 11:51:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229665AbjHDLu7 (ORCPT ); Fri, 4 Aug 2023 07:50:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49130 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229538AbjHDLu6 (ORCPT ); Fri, 4 Aug 2023 07:50:58 -0400 Received: from lelv0142.ext.ti.com (lelv0142.ext.ti.com [198.47.23.249]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 091B0126; Fri, 4 Aug 2023 04:50:56 -0700 (PDT) Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 374BoiNI071530; Fri, 4 Aug 2023 06:50:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1691149844; bh=odtYzHDq0zirS7zeE2CRp3Jz/F3OYtBxsdZ8qAzg440=; h=From:To:CC:Subject:Date; b=Ue7e/GoTb3kAbOvLmNuyYZhqtzkrfrF2EtDJG5qtezqiNvEH9vVHgFW+oAk4FHa18 tupQdYRdSbfMWa5w0XLzuF+f3awCdhjsEhajI5+V3s00/p9GtVpN0UcSkPp2pQ8P5g mu5NloHEkpiqZEBVfClk/Wb9sbElmcUHAduMIUCA= Received: from DLEE113.ent.ti.com (dlee113.ent.ti.com [157.170.170.24]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 374BoiWP122800 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 4 Aug 2023 06:50:44 -0500 Received: from DLEE112.ent.ti.com (157.170.170.23) by DLEE113.ent.ti.com (157.170.170.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Fri, 4 Aug 2023 06:50:44 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE112.ent.ti.com (157.170.170.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Fri, 4 Aug 2023 06:50:44 -0500 Received: from localhost (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 374BohSW004640; Fri, 4 Aug 2023 06:50:44 -0500 From: Dhruva Gole To: Nishanth Menon , Tero Kristo , Santosh Shilimkar CC: , , , , Kevin Hilman , Vignesh R , Dhruva Gole , Andrew Davis , Vibhore Vardhan , Tony Lindgren Subject: [PATCH V7 0/4] firmware: ti_sci: Introduce system suspend support Date: Fri, 4 Aug 2023 17:20:33 +0530 Message-ID: <20230804115037.754994-1-d-gole@ti.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Abstract ******** This series introduces necessary ti_sci driver functionality to support DeepSleep mode (suspend to mem) on TI K3 AM62x. DeepSleep mode is described in section "6.2.4.4 DeepSleep" of the AM62x Technical Reference Manual [0]. Summary ******* This series is a fixup and rebase of the patch series by Dave Gerlach [1]. It applies on top of next-20230731. The kernel triggers entry to DeepSleep mode through the mem suspend transition with the following: * At the bootloader stage, one is expected to package the TIFS stub which then gets pulled into the Tightly coupled memory of the Device Mgr R5 when it starts up. If using U-Boot, then it requires tispl.bin to contain the TIFS stub. Refer to ti-u-boot patch [3] for further details. The supported firmware version is from TI Processor SDK >= 09.00 ie. tag 09.00.00.006 from ti-linux-firmware [4]. * Use a TF-A binary that supports PSCI_SYSTEM_SUSPEND call. This causes system to use PSCI system suspend as last step of mem sleep. * The firmware requires that the OS sends a TISCI_MSG_PREPARE_SLEEP message in order to provide details about suspend, so we must add the ability to send this message. We also add TISCI_MSG_LPM_WAKE_REASON and TISCI_MSG_SET_IO_ISOLATION messages as part of a new PM ops. These messages are part of the TISCI PM Low Power Mode API [2]. (Patch 2) * A memory address must be provided to the firmware using the above message, which is allocated and managed by dma_alloc_attrs() and friends. This memory address can be used by the firmware to save necessary context at that physical location in the DDR RAM. (Patch 3) * Finally, the ti_sci driver must actually send TISCI_MSG_PREPARE_SLEEP message to firmware with the above information included, which it does during the driver suspend handler when PM_MEM_SUSPEND is the determined state being entered. (Patch 4) It currently enables only DeepSleep mode, but even if any additional modes are needed to be supported in future, they would not require any changes to the TISCI LPM APIs [2]. The enabling of additional modes would be done via GenPD changes that is currently in the works. Testing: ******* In can be tested with the following branch: https://github.com/DhruvaG2000/v-linux/commits/lpm-upstream-6.5 Tested on SK-AM62B [6] here: https://gist.github.com/DhruvaG2000/8410fac048c677c40cd94f5169b5b0b4 Limitations: ************ * It is critical for deepsleep to work that the bootloader has loaded the TIFS stub at the desired location and that the DM has copied it correctly into it's TCM. Linux has no way of knowing whether a valid FS Stub exists and has been loaded or not. The Device Manager also doesn't send any NACK if a proper TIFS Stub is not present to prevent the deepsleep somehow. This problem is somewhat addressed in this patch series where we check which SOCs support LPM and based on that set the fw_caps. * Currently, DeepSleep is only supported on SK-AM62B with DDR4. Boards with LPDDR part like Beagle Play and AM62x LP have a known FW issue. Base commit: ************ commit ec8939156379 (tag: next-20230731) ("Add linux-next specific files for 20230731") origin: linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git Changelog: ********** v7: - Address Andrew's concerns on SYSFW fw_caps API - Remove all the unused functions and variables including set_io_isolation and wake_reason calls - use dma_free_attrs - remove IO isolation related code from linux side, TODO: Add it in ATF enter_sleep perhaps? v6: - link to v6 [5] - Loading of FS Stub from linux no longer needed, hence drop that patch, - Drop 1/6 and 5/6 from the previous series [4]. - Add system suspend resume callbacks which were removed in commit 9225bcdedf16297a346082e7d23b0e8434aa98ed ("firmware: ti_sci: Use system_state to determine polling") - Use IO isolation while putting the system in suspend to RAM v5: - Add support (patch 3) for detecting the low power modes (LPM) of the FW/SoC with a recently introduced core TISCI_MSG_QUERY_FW_CAPS message. - Use TISCI_MSG_QUERY_FW_CAPS instead of misusing the TISCI_MSG_PREPARE_SLEEP to detect the FW/SoC low power caps (patch 4). - Take into account the supported LPMs in ti_sci_prepare_system_suspend() and handle the case when CONFIG_SUSPEND is not enabled (patch 6) that was reported by Roger Quadros and LKP. - Pick up Rob Herring's "Reviewed-by" tag for the binding patch. v4: - Fix checkpacth warnings in patches 2 and 3. - Drop the links with anchors in patch 2. v3: - Fix the compile warnings on 32-bit platforms reported by the kernel test robot in patches (3,5). - Pick up Roger's "Tested-by" tags. v2: - Addressed comments received for v1 series [1]. - Updated v1 patch 5 to use pm notifier to avoid firmware loading issues. - Dropped the reserved region requirement and allocate DMA memory instead. The reserved region binding patch is also removed. - Introduce two more TISCI LPM messages that are supported in SysFW. - Fixes in error handling. References: *********** [0] https://www.ti.com/lit/pdf/spruiv7 [1] https://lore.kernel.org/lkml/20220421203659.27853-1-d-gerlach@ti.com [2] https://software-dl.ti.com/tisci/esd/latest/2_tisci_msgs/pm/lpm.html [3] https://git.ti.com/cgit/ti-u-boot/ti-u-boot/commit/?h=ti-u-boot-2023.04&id=91886b68025c7ad121e62d1fc1fa4601eeb736cd [4] https://git.ti.com/cgit/processor-firmware/ti-linux-firmware/commit/?h=ti-linux-firmware-next&id=905eb58564581d951d148f45828e8c8a142a5938 [5] https://lore.kernel.org/all/20230803064247.503036-1-d-gole@ti.com/ [6] https://www.ti.com/tool/SK-AM62B Cc: Andrew Davis Cc: Vibhore Vardhan Cc: Kevin Hilman Cc: Vignesh Raghavendra Cc: Tony Lindgren Dave Gerlach (2): firmware: ti_sci: Introduce Power Management Ops firmware: ti_sci: Allocate memory for Low Power Modes Dhruva Gole (1): firmware: ti_sci: Add system suspend call Georgi Vlaev (1): firmware: ti_sci: Add support for querying the firmware caps drivers/firmware/ti_sci.c | 234 ++++++++++++++++++++++++- drivers/firmware/ti_sci.h | 56 +++++- include/linux/soc/ti/ti_sci_protocol.h | 15 ++ 3 files changed, 303 insertions(+), 2 deletions(-)