mbox series

[v2,0/6] Add initial Exynos850 support to the thermal driver

Message ID 20240726110114.1509733-1-m.majewski2@samsung.com (mailing list archive)
Headers show
Series Add initial Exynos850 support to the thermal driver | expand

Message

Mateusz Majewski July 26, 2024, 11:01 a.m. UTC
This series adds initial Exynos850 support to the thermal driver
together with its requirements (sanitize_temp_error fix, adding the new
string to dt-bindings), while also cleaning up a bit (improving power
management support and removing some outdated information from
dt-bindings).

Changelog:
 v2:
   - Reimplemented to use the Exynos850 TMU clock: removed the patch to
     make the clock optional and changed dt-bindings change accordingly
   - Improved the Exynos850 implementation itself (style and one correct
     register offset)
   - Removed conditional compilation in favor of pm_sleep_ptr
   - Shortened dt-bindings description

Mateusz Majewski (6):
  drivers/thermal/exynos: use DEFINE_SIMPLE_DEV_PM_OPS
  drivers/thermal/exynos: use pm_sleep_ptr instead of conditional
    compilation
  drivers/thermal/exynos: improve sanitize_temp_error
  dt-bindings: thermal: samsung,exynos: add exynos850-tmu string
  drivers/thermal/exynos: add initial Exynos850 support
  dt-bindings: thermal: samsung,exynos: remove outdated information on
    trip point count

 .../thermal/samsung,exynos-thermal.yaml       |   8 +-
 drivers/thermal/samsung/exynos_tmu.c          | 219 ++++++++++++++++--
 2 files changed, 199 insertions(+), 28 deletions(-)

Comments

Mateusz Majewski July 26, 2024, 3:03 p.m. UTC | #1
Forgot to mention it in the cover letter, but as discussed in v1 in
https://lore.kernel.org/lkml/CAPLW+4nfEjP4FDjRJORyyKk46x4VfFAcMuK88jXUT_LJoP1N_g@mail.gmail.com,
this requires support for the TMU clock to run, available in
https://lore.kernel.org/lkml/20240723163311.28654-2-semen.protsenko@linaro.org.
This series builds fine without this, only it is not possible to write a
devicetree source for this without the mentioned series, so as I
understand it is ok for this to be in review anyway?

By the way, I am going to have some more time to help with the upstream
kernel, and have access to most of the supported SoCs. If you feel that
it is appropriate, I would be very happy to become one of the
maintainers of this driver :)
Krzysztof Kozlowski July 26, 2024, 3:08 p.m. UTC | #2
On 26/07/2024 17:03, Mateusz Majewski wrote:
> Forgot to mention it in the cover letter, but as discussed in v1 in
> https://lore.kernel.org/lkml/CAPLW+4nfEjP4FDjRJORyyKk46x4VfFAcMuK88jXUT_LJoP1N_g@mail.gmail.com,
> this requires support for the TMU clock to run, available in
> https://lore.kernel.org/lkml/20240723163311.28654-2-semen.protsenko@linaro.org.
> This series builds fine without this, only it is not possible to write a
> devicetree source for this without the mentioned series, so as I
> understand it is ok for this to be in review anyway?

It's okay. Also okay for merging via thermal tree, after merge window.
Only DTS will depend on the clock binding patch, which you will have to
mention in cover letter or patch changelog (---).

> 
> By the way, I am going to have some more time to help with the upstream
> kernel, and have access to most of the supported SoCs. If you feel that
> it is appropriate, I would be very happy to become one of the
> maintainers of this driver :)

If you have time, I think it would be great. +1

Reviews, tests, cleanups and any other non-developer activities are
welcomed anyway, regardless whether you are listed as maintainer or not.
Just set yourself a lei filter for specific keywords (e.g. samsung-soc
list or dfn: for paths) and just review all the code on the lists.

Best regards,
Krzysztof