mbox series

[0/4] sched/deadline: nanoseconds clarifications

Message ID 20240813144348.1180344-1-christian.loehle@arm.com (mailing list archive)
Headers show
Series sched/deadline: nanoseconds clarifications | expand

Message

Christian Loehle Aug. 13, 2024, 2:43 p.m. UTC 
A couple of clarifications about the time units for the deadline
parameters uncovered in the discussion around
https://lore.kernel.org/lkml/3c726cf5-0c94-4cc6-aff0-a453d840d452@arm.com/

While at it I changed the documentation example to chrt instead
of the schedtool fork.

No functional changes.

Christian Loehle (4):
  sched/deadline: Convert schedtool example to chrt
  sched/deadline: Clarify nanoseconds in uapi
  cpufreq/cppc: Use NSEC_PER_MSEC for deadline task
  sched/cpufreq: Use NSEC_PER_MSEC for deadline task

 Documentation/scheduler/sched-deadline.rst | 14 ++++++--------
 drivers/cpufreq/cppc_cpufreq.c             |  6 +++---
 include/uapi/linux/sched/types.h           |  6 +++---
 kernel/sched/cpufreq_schedutil.c           |  6 +++---
 4 files changed, 15 insertions(+), 17 deletions(-)

--
2.34.1

Comments

Juri Lelli Aug. 13, 2024, 4:02 p.m. UTC | #1 
Hi,

On 13/08/24 15:43, Christian Loehle wrote:
> A couple of clarifications about the time units for the deadline
> parameters uncovered in the discussion around
> https://lore.kernel.org/lkml/3c726cf5-0c94-4cc6-aff0-a453d840d452@arm.com/
> 
> While at it I changed the documentation example to chrt instead
> of the schedtool fork.
> 
> No functional changes.

Looks good to me!

At least for docs/uapi,

Acked-by: Juri Lelli <juri.lelli@redhat.com>

Thanks,
Juri
Christian Loehle Sept. 9, 2024, 1:01 p.m. UTC | #2 
On 8/13/24 17:02, Juri Lelli wrote:
> Hi,
> 
> On 13/08/24 15:43, Christian Loehle wrote:
>> A couple of clarifications about the time units for the deadline
>> parameters uncovered in the discussion around
>> https://lore.kernel.org/lkml/3c726cf5-0c94-4cc6-aff0-a453d840d452@arm.com/
>>
>> While at it I changed the documentation example to chrt instead
>> of the schedtool fork.
>>
>> No functional changes.
> 
> Looks good to me!
> 
> At least for docs/uapi,
> 
> Acked-by: Juri Lelli <juri.lelli@redhat.com>

(gentle ping)
Peter, do you want to take {1,2} and Rafael {3,4}?

Thanks,
Christian
Peter Zijlstra Sept. 9, 2024, 1:25 p.m. UTC | #3 
On Mon, Sep 09, 2024 at 02:01:38PM +0100, Christian Loehle wrote:
> On 8/13/24 17:02, Juri Lelli wrote:
> > Hi,
> > 
> > On 13/08/24 15:43, Christian Loehle wrote:
> >> A couple of clarifications about the time units for the deadline
> >> parameters uncovered in the discussion around
> >> https://lore.kernel.org/lkml/3c726cf5-0c94-4cc6-aff0-a453d840d452@arm.com/
> >>
> >> While at it I changed the documentation example to chrt instead
> >> of the schedtool fork.
> >>
> >> No functional changes.
> > 
> > Looks good to me!
> > 
> > At least for docs/uapi,
> > 
> > Acked-by: Juri Lelli <juri.lelli@redhat.com>
> 
> (gentle ping)
> Peter, do you want to take {1,2} and Rafael {3,4}?

I'll queue the lot if that is okay with Rafael.
Rafael J. Wysocki Sept. 9, 2024, 4:39 p.m. UTC | #4 
On Mon, Sep 9, 2024 at 3:25 PM Peter Zijlstra <peterz@infradead.org> wrote:
>
> On Mon, Sep 09, 2024 at 02:01:38PM +0100, Christian Loehle wrote:
> > On 8/13/24 17:02, Juri Lelli wrote:
> > > Hi,
> > >
> > > On 13/08/24 15:43, Christian Loehle wrote:
> > >> A couple of clarifications about the time units for the deadline
> > >> parameters uncovered in the discussion around
> > >> https://lore.kernel.org/lkml/3c726cf5-0c94-4cc6-aff0-a453d840d452@arm.com/
> > >>
> > >> While at it I changed the documentation example to chrt instead
> > >> of the schedtool fork.
> > >>
> > >> No functional changes.
> > >
> > > Looks good to me!
> > >
> > > At least for docs/uapi,
> > >
> > > Acked-by: Juri Lelli <juri.lelli@redhat.com>
> >
> > (gentle ping)
> > Peter, do you want to take {1,2} and Rafael {3,4}?
>
> I'll queue the lot if that is okay with Rafael.

It is, thank you!

And please feel free to add my ACKs to the patches.