mbox series

[v2,0/2] tools: power: cpupower: Allow overriding cross-compiling envs

Message ID 20240919-pm-v2-0-0f25686556b5@nxp.com (mailing list archive)
Headers show
Series tools: power: cpupower: Allow overriding cross-compiling envs | expand

Message

Peng Fan (OSS) Sept. 19, 2024, 12:08 p.m. UTC 
Two minor patches:
Patch 1 is not relevant for cross-compiling, but done when I playing
with cpupower on ARM64 boards.
Patch 2 is to make it easier for Yocto users to cross-compiling cpupower
tools.

Signed-off-by: Peng Fan <peng.fan@nxp.com>

V2:
 subject update, commit log update in patch 1, 2
 Use strerror in patch 1
 without patch 2, need update Makefile with 'CROSS =
 [cross toolchain path]/aarch64-poky-linux-'

---
Peng Fan (2):
      pm: cpupower: bench: print config file path when open cpufreq-bench.conf fails
      pm: cpupower: Makefile: Allow overriding cross-compiling env params

 tools/power/cpupower/Makefile      | 12 ++++++------
 tools/power/cpupower/bench/parse.c |  5 +++--
 2 files changed, 9 insertions(+), 8 deletions(-)
---
base-commit: 6708132e80a2ced620bde9b9c36e426183544a23
change-id: 20240917-pm-08147f104e70

Best regards,

Comments

John B. Wyatt IV Sept. 19, 2024, 4:38 p.m. UTC | #1 
Hi Peng,

A few comments:

> V2:
>  subject update, commit log update in patch 1, 2
>  Use strerror in patch 1
>  without patch 2, need update Makefile with 'CROSS =
>  [cross toolchain path]/aarch64-poky-linux-'

Version information is applied per commit patch. Not in the cover letter.

Example:

https://lore.kernel.org/linux-pm/20240905021916.15938-2-jwyatt@redhat.com/

Reference:

https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-canonical-patch-format

You will need to submit a V3 version of this.

>  without patch 2, need update Makefile with 'CROSS =
>  [cross toolchain path]/aarch64-poky-linux-'

I am not sure what this is saying exactly. Please clarify.

> Subject: Re: [PATCH v2 0/2] tools: power: cpupower: Allow overriding

Not sure you need 'tools: power: cpupower:' in the cover letter.

> pm: cpupower: bench: print config file path when open cpufreq-bench.conf fails

I do not think you need bench either.