From patchwork Mon Mar 25 06:02:30 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: William Breathitt Gray X-Patchwork-Id: 10867909 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E98CA1390 for ; Mon, 25 Mar 2019 06:02:02 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D495D2916C for ; Mon, 25 Mar 2019 06:02:02 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C80E6291D2; Mon, 25 Mar 2019 06:02:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 476292916C for ; Mon, 25 Mar 2019 06:02:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729581AbfCYGCB (ORCPT ); Mon, 25 Mar 2019 02:02:01 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:43757 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729373AbfCYGCB (ORCPT ); Mon, 25 Mar 2019 02:02:01 -0400 Received: by mail-pf1-f196.google.com with SMTP id c8so5588633pfd.10; Sun, 24 Mar 2019 23:02:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=kKfqIFUlDRltfcQS9D3SGEANKxPIE7Wk31cFSlLEgQQ=; b=USiFXxvghAZPI9KFsGNAdwmlkB7w5LFCMkLgGnz6jAic8z5UVO5eimSeyBaIfVKkEW OZLs5xpcSwDUtn3wr5xzpiFfuT9P7R+u9V7e82QY71cKLb+t9yNked326pvJHmbngQPX 4hcTRBcB0lSzbw2ydWoKoOkL5rGDmTkLKEspzU6b8GO3Acgak2M3/E0HEfJqXUPCtaUR LYhBUKVCLSSIKxeg1v4CrbLt/N7dnPoZ72r8eB1fSxSzf4L8pMu2xL+FyYPYdM9PPUhr unCba52ifCFyTHRKcuMaGd80Derkw8x0/Gh5mcIK20ywwwKgE50haa3E3HLiCjoUisIm cWog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=kKfqIFUlDRltfcQS9D3SGEANKxPIE7Wk31cFSlLEgQQ=; b=olQCsNWISzcviqPLwZUUyRM3nWpn/7U3Ay/0HAJiNdzPr2g7uWICWKaYCiVcF4l3Jw QnuiA21BEZRdt4RRlFHcgdzMqx5yg+0+gKtwH+abxdLrTPc0Cs4y0EZ6o1jKNMFWFth9 P1pBJvB+SDCHYok68tJV4vQau+vYLsNvWrzmAOW0QFPz6rMhk+TB7FtX50+EEpBWokn9 SfWOu1dpt+52Px5adFJ3GOVJViHxpZhzZmHAPG7hEtXDiVaEOaics9hfPmQuLIV9D77h yYR8y6sfZd+yuKsXFMOuLz/YlsU5MGuQWirL/utTU6QrCydp/wFEY9OvOrs3t0To2iO9 yp5Q== X-Gm-Message-State: APjAAAVm62q9hH7vEShskv22sz5iZUWp1+7HxHQA52LD2C1gzKmIX2QE vA2NOETyXJ/MPS8eLPaz0DI= X-Google-Smtp-Source: APXvYqyLmQCwSREDK+JfQvvOEj8by+8i6HkU4ZT4h6XtbumvzJ/YllMYwcd3aQSmwOUxWXXD0nm2oA== X-Received: by 2002:a63:618d:: with SMTP id v135mr21751583pgb.2.1553493720119; Sun, 24 Mar 2019 23:02:00 -0700 (PDT) Received: from localhost.localdomain ([2001:268:c0a5:e068:c70:4af9:86e2:2]) by smtp.gmail.com with ESMTPSA id w68sm22074644pfb.176.2019.03.24.23.01.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 24 Mar 2019 23:01:59 -0700 (PDT) From: William Breathitt Gray To: linus.walleij@linaro.org, bgolaszewski@baylibre.com Cc: akpm@linux-foundation.org, linux-gpio@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, andriy.shevchenko@linux.intel.com, linux@rasmusvillemoes.dk, yamada.masahiro@socionext.com, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, geert@linux-m68k.org, preid@electromag.com.au, William Breathitt Gray Subject: [PATCH v11 00/11] Introduce the for_each_set_clump8 macro Date: Mon, 25 Mar 2019 15:02:30 +0900 Message-Id: X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Changes in v11: - Reimplement low_mask definition in bitmap_set_value8 for a more efficient bitmask generation by using a shift operation - Fix typo in for_each_set_clump8 arguments list in the add_dts_thermal_zone function to properly dereference ptps bitmap - Utilize for_each_set_clump8 macro in drivers/gpio/gpio-74x164.c While adding GPIO get_multiple/set_multiple callback support for various drivers, I noticed a pattern of looping manifesting that would be useful standardized as a macro. This patchset introduces the for_each_set_clump8 macro and utilizes it in several GPIO drivers. The for_each_set_clump macro8 facilitates a for-loop syntax that iterates over a memory region entire groups of set bits at a time. For example, suppose you would like to iterate over a 32-bit integer 8 bits at a time, skipping over 8-bit groups with no set bit, where XXXXXXXX represents the current 8-bit group: Example: 10111110 00000000 11111111 00110011 First loop: 10111110 00000000 11111111 XXXXXXXX Second loop: 10111110 00000000 XXXXXXXX 00110011 Third loop: XXXXXXXX 00000000 11111111 00110011 Each iteration of the loop returns the next 8-bit group that has at least one set bit. The for_each_set_clump8 macro has four parameters: * start: set to the bit offset of the current clump * clump: set to the current clump value * bits: bitmap to search within * size: bitmap size in number of bits In this version of the patchset, the for_each_set_clump macro has been reimplemented and simplified based on the suggestions provided by Rasmus Villemoes and Andy Shevchenko in the version 4 submission. In particular, the function of the for_each_set_clump macro has been restricted to handle only 8-bit clumps; the drivers that use the for_each_set_clump macro only handle 8-bit ports so a generic for_each_set_clump implementation is not necessary. Thus, a solution for large clumps (i.e. those larger than the width of a bitmap word) can be postponed until a driver appears that actually requires such a generic for_each_set_clump implementation. For what it's worth, a semi-generic for_each_set_clump (i.e. for clumps smaller than the width of a bitmap word) can be implemented by simply replacing the hardcoded '8' and '0xFF' instances with respective variables. I have not yet had a need for such an implementation, and since it falls short of a true generic for_each_set_clump function, I have decided to forgo such an implementation for now. In addition, the bitmap_get_value8 and bitmap_set_value8 functions are introduced to get and set 8-bit values respectively. Their use is based on the behavior suggested in the patchset version 4 review. William Breathitt Gray (11): bitops: Introduce the for_each_set_clump8 macro lib/test_bitmap.c: Add for_each_set_clump8 test cases gpio: 104-dio-48e: Utilize for_each_set_clump8 macro gpio: 104-idi-48: Utilize for_each_set_clump8 macro gpio: gpio-mm: Utilize for_each_set_clump8 macro gpio: ws16c48: Utilize for_each_set_clump8 macro gpio: pci-idio-16: Utilize for_each_set_clump8 macro gpio: pcie-idio-24: Utilize for_each_set_clump8 macro gpio: uniphier: Utilize for_each_set_clump8 macro thermal: intel: intel_soc_dts_iosf: Utilize for_each_set_clump8 macro gpio: 74x164: Utilize the for_each_set_clump8 macro drivers/gpio/gpio-104-dio-48e.c | 73 ++++---------- drivers/gpio/gpio-104-idi-48.c | 37 ++----- drivers/gpio/gpio-74x164.c | 20 ++-- drivers/gpio/gpio-gpio-mm.c | 73 ++++---------- drivers/gpio/gpio-pci-idio-16.c | 75 ++++++-------- drivers/gpio/gpio-pcie-idio-24.c | 111 ++++++++------------- drivers/gpio/gpio-uniphier.c | 16 ++- drivers/gpio/gpio-ws16c48.c | 72 ++++--------- drivers/thermal/intel/intel_soc_dts_iosf.c | 29 +++--- drivers/thermal/intel/intel_soc_dts_iosf.h | 2 - include/asm-generic/bitops/find.h | 14 +++ include/linux/bitops.h | 5 + lib/find_bit.c | 81 +++++++++++++++ lib/test_bitmap.c | 65 ++++++++++++ 14 files changed, 340 insertions(+), 333 deletions(-)