From patchwork Sat Oct 5 18:36:54 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: William Breathitt Gray X-Patchwork-Id: 11175769 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 43C7114DB for ; Sat, 5 Oct 2019 18:37:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0D652222C8 for ; Sat, 5 Oct 2019 18:37:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PPLqQZGh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387884AbfJESh2 (ORCPT ); Sat, 5 Oct 2019 14:37:28 -0400 Received: from mail-yb1-f178.google.com ([209.85.219.178]:45966 "EHLO mail-yb1-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387477AbfJESh2 (ORCPT ); Sat, 5 Oct 2019 14:37:28 -0400 Received: by mail-yb1-f178.google.com with SMTP id q143so2004810ybg.12; Sat, 05 Oct 2019 11:37:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=2AJoVgoOlJtCM32LZiMknyZBvbEzY9NtgFLlTHYweRU=; b=PPLqQZGh3VQez+XWSDmGc6lG8dqyfSbgXIRoEBr2NGjzMqAne7AmQ88vPf5DLHjpKJ E/sUeKEJcKebNY7IinPGij6k3zD7bn9OvWM18EE3LS9VLHlmdwBdyuSqe9VqX22+9BU3 SdBnpkiV2s9ycDBlTtmHSDRZjh5jlUnbUHhI1Dj4pIw4yhMArxSdZVcnWv2dwngmURXt VPjrwwJQq+Z6cEXTz8YNOOwPlGjwB7onMuVa3afaTr1xsXshL6ELUIS9DbnQY35w/iFV XT02R3W7H2GtkMMrIrxswWk+3R6fIu3Blo0P1++CqXe5uSgOpvjiXInKo3f4jy6aZH8g q6Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=2AJoVgoOlJtCM32LZiMknyZBvbEzY9NtgFLlTHYweRU=; b=FP7JIg6dvEcRTqYvtM4eoWxXmsswkLfmvckeEDhFfuhgZ48e8Zcx+azt6wyjfcQpLY B1mSftZ822R6CaURR6k3f4JWR442TeHi1LUQI/hCf23hbz2OsvJNMnI+aQOEELnLYcsL GtQVbRChgT9/LRcvSpvpnCL73hAlPwJt0ekRPrCJ2sRhQU952iIXnzY84t9wgvgsCJMP Z+Bw52n2WH4XDIu72FArOQFPP2uEBzJGDGLSlbSut67ALOcJ1nd22wveWud1ctgMc3vR doQSDPcHnqoudY653vopkDSjyJnRBrAalBmo3VBgJwUK3jaJSdQfQWZG+iOiVlPPDk70 ep4g== X-Gm-Message-State: APjAAAUGqI4NN341cpndqsoiS918nyLnItxGqnmrysD/LEDxZLlLj2el KDurWQXZYdBHrc1mz6PRd3I= X-Google-Smtp-Source: APXvYqxh+/cWSsKTt6blKzy8HJ0ri4mJ030rKx7xhz++ocPtaTAWBxxq8fumwGmBPXZb0sGsej3elA== X-Received: by 2002:a25:2548:: with SMTP id l69mr5910083ybl.159.1570300646571; Sat, 05 Oct 2019 11:37:26 -0700 (PDT) Received: from localhost.localdomain (072-189-084-142.res.spectrum.com. [72.189.84.142]) by smtp.gmail.com with ESMTPSA id g128sm2376654ywb.13.2019.10.05.11.37.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Oct 2019 11:37:25 -0700 (PDT) From: William Breathitt Gray To: linus.walleij@linaro.org, bgolaszewski@baylibre.com Cc: akpm@linux-foundation.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, andriy.shevchenko@linux.intel.com, linux@rasmusvillemoes.dk, yamada.masahiro@socionext.com, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, geert@linux-m68k.org, preid@electromag.com.au, lukas@wunner.de, sean.nyekjaer@prevas.dk, morten.tiljeset@prevas.dk, William Breathitt Gray Subject: [PATCH v15 00/14] Introduce the for_each_set_clump8 macro Date: Sat, 5 Oct 2019 14:36:54 -0400 Message-Id: X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Changes in v15: - Move find_next_clump8 to lib/find_bit.c since it requires round_down (I want this to be static inline like the others, but I need help) - Utilize for_each_set_clump8 in pisosr, max3191x, and pca953x While adding GPIO get_multiple/set_multiple callback support for various drivers, I noticed a pattern of looping manifesting that would be useful standardized as a macro. This patchset introduces the for_each_set_clump8 macro and utilizes it in several GPIO drivers. The for_each_set_clump macro8 facilitates a for-loop syntax that iterates over a memory region entire groups of set bits at a time. For example, suppose you would like to iterate over a 32-bit integer 8 bits at a time, skipping over 8-bit groups with no set bit, where XXXXXXXX represents the current 8-bit group: Example: 10111110 00000000 11111111 00110011 First loop: 10111110 00000000 11111111 XXXXXXXX Second loop: 10111110 00000000 XXXXXXXX 00110011 Third loop: XXXXXXXX 00000000 11111111 00110011 Each iteration of the loop returns the next 8-bit group that has at least one set bit. The for_each_set_clump8 macro has four parameters: * start: set to the bit offset of the current clump * clump: set to the current clump value * bits: bitmap to search within * size: bitmap size in number of bits In this version of the patchset, the for_each_set_clump macro has been reimplemented and simplified based on the suggestions provided by Rasmus Villemoes and Andy Shevchenko in the version 4 submission. In particular, the function of the for_each_set_clump macro has been restricted to handle only 8-bit clumps; the drivers that use the for_each_set_clump macro only handle 8-bit ports so a generic for_each_set_clump implementation is not necessary. Thus, a solution for large clumps (i.e. those larger than the width of a bitmap word) can be postponed until a driver appears that actually requires such a generic for_each_set_clump implementation. For what it's worth, a semi-generic for_each_set_clump (i.e. for clumps smaller than the width of a bitmap word) can be implemented by simply replacing the hardcoded '8' and '0xFF' instances with respective variables. I have not yet had a need for such an implementation, and since it falls short of a true generic for_each_set_clump function, I have decided to forgo such an implementation for now. In addition, the bitmap_get_value8 and bitmap_set_value8 functions are introduced to get and set 8-bit values respectively. Their use is based on the behavior suggested in the patchset version 4 review. William Breathitt Gray (14): bitops: Introduce the for_each_set_clump8 macro lib/test_bitmap.c: Add for_each_set_clump8 test cases gpio: 104-dio-48e: Utilize for_each_set_clump8 macro gpio: 104-idi-48: Utilize for_each_set_clump8 macro gpio: gpio-mm: Utilize for_each_set_clump8 macro gpio: ws16c48: Utilize for_each_set_clump8 macro gpio: pci-idio-16: Utilize for_each_set_clump8 macro gpio: pcie-idio-24: Utilize for_each_set_clump8 macro gpio: uniphier: Utilize for_each_set_clump8 macro gpio: 74x164: Utilize the for_each_set_clump8 macro thermal: intel: intel_soc_dts_iosf: Utilize for_each_set_clump8 macro gpio: pisosr: Utilize the for_each_set_clump8 macro gpio: max3191x: Utilize the for_each_set_clump8 macro gpio: pca953x: Utilize the for_each_set_clump8 macro drivers/gpio/gpio-104-dio-48e.c | 73 ++++---------- drivers/gpio/gpio-104-idi-48.c | 36 ++----- drivers/gpio/gpio-74x164.c | 19 ++-- drivers/gpio/gpio-gpio-mm.c | 73 ++++---------- drivers/gpio/gpio-max3191x.c | 19 ++-- drivers/gpio/gpio-pca953x.c | 17 ++-- drivers/gpio/gpio-pci-idio-16.c | 75 +++++--------- drivers/gpio/gpio-pcie-idio-24.c | 109 ++++++++------------- drivers/gpio/gpio-pisosr.c | 12 +-- drivers/gpio/gpio-uniphier.c | 16 ++- drivers/gpio/gpio-ws16c48.c | 73 ++++---------- drivers/thermal/intel/intel_soc_dts_iosf.c | 29 +++--- drivers/thermal/intel/intel_soc_dts_iosf.h | 2 - include/asm-generic/bitops/find.h | 50 ++++++++++ include/linux/bitops.h | 5 + lib/find_bit.c | 14 +++ lib/test_bitmap.c | 65 ++++++++++++ 17 files changed, 325 insertions(+), 362 deletions(-)