From patchwork Tue Oct 8 09:14:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 13826099 Received: from baptiste.telenet-ops.be (baptiste.telenet-ops.be [195.130.132.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 169ED192D9E for ; Tue, 8 Oct 2024 09:14:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.130.132.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728378879; cv=none; b=RS1HJb2JoqRn6eUE+iYp3wdI0WA+1hgVlkaY32aNFJjhGiskMtRiLf3fksoLoWnptg7v4gEv6VaFR5AQ98Sci3U6/KNaarxdxyO8PH0dRHKShp2ifDYPd48zPI0vzo7c74HPSXoavkuEM8SOgr/3xZ4m9ZWn3B3Aib9Qjqz4Jrk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728378879; c=relaxed/simple; bh=aZ7a6do1I9lRvki6g0ztNEBHyJ+s91TElHWBfDtQ2h4=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=QXc8IRwYlS/i/F3DaK0Qny0nQVgkluio51KsHBLZvEqxXZ0tq1ycjNZZ+N6NmChyXZZOoyH5iE9QU1N0umvUsQgR1l18avnFWo+o4tubvlzD1ifqnFIS4+TLRkOhBBPNcUn+ukuBT7C6CEEuuLUawda93TBdMZ5QgsHnePDTl7A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=glider.be; spf=none smtp.mailfrom=linux-m68k.org; arc=none smtp.client-ip=195.130.132.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=glider.be Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux-m68k.org Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed80:af78:ce2e:2b4b:9f2a]) by baptiste.telenet-ops.be with cmsmtp id MlET2D00H0Eqs9l01lET5l; Tue, 08 Oct 2024 11:14:28 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from ) id 1sy6IL-003RYK-1y; Tue, 08 Oct 2024 11:14:27 +0200 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from ) id 1sy6IV-00D2DB-GN; Tue, 08 Oct 2024 11:14:27 +0200 From: Geert Uytterhoeven To: Lukasz Luba , Magnus Damm Cc: Kuninori Morimoto , Lad Prabhakar , linux-pm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH/RFC 0/2] arm64: dts: renesas: Re-add voltages to OPP tables Date: Tue, 8 Oct 2024 11:14:19 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi all, When CONFIG_ENERGY_MODEL=y, an error is printed on RZ/G2E and R-Car E3: cpu cpu0: EM: invalid perf. state: -22 This happens because the Operating Points Parameters tables do not list voltages, as they are all identical. Previously, it was assumed they were optional, and unused, when none of the CPU nodes is tied to a regulator using the "cpu-supply" property. This assumption turned out to be incorrect, causing the reported error message. This RFC patch series fixes this by adding the missing voltages. Note that the Energy Model calculates energy efficiency by dividing the (estimated) CPU power consumption by CPU core clock frequency. When all voltages have the same value, the former is proportional to clock frequency, and energy efficiency becomes a constant. Hence all operating points are considered to have the same efficiency, and the Energy Model always picks the one with the highest clock rate (see also [1]). Alternatively, the Energy Model could be changed to silently ignore OPP tables with missing frequencies. IMHO this is not an unusual case. Which approach should be taken? Thanks for your comments! [1] "PM: EM: Question Potential Issue with EM and OPP Table in cpufreq ondemand Governor" https://lore.kernel.org/all/a2ca883e-122e-43a1-b377-c43956b5b3be@arm.com Geert Uytterhoeven (2): arm64: dts: renesas: r8a774c0: Re-add voltages to OPP table arm64: dts: renesas: r8a77990: Re-add voltages to OPP table arch/arm64/boot/dts/renesas/r8a774c0.dtsi | 3 +++ arch/arm64/boot/dts/renesas/r8a77990.dtsi | 3 +++ 2 files changed, 6 insertions(+)