From patchwork Fri May 9 01:09:37 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: jhbird.choi@samsung.com X-Patchwork-Id: 4139841 Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id EFA60BFF02 for ; Fri, 9 May 2014 01:09:52 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1B834202FE for ; Fri, 9 May 2014 01:09:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2407A202EA for ; Fri, 9 May 2014 01:09:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755326AbaEIBJm (ORCPT ); Thu, 8 May 2014 21:09:42 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:53876 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754236AbaEIBJj convert rfc822-to-8bit (ORCPT ); Thu, 8 May 2014 21:09:39 -0400 Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N5A0057L8K19X90@mailout4.samsung.com>; Fri, 09 May 2014 10:09:38 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.49]) by epcpsbgr1.samsung.com (EPCPMTA) with SMTP id BF.23.18501.1DA2C635; Fri, 09 May 2014 10:09:37 +0900 (KST) X-AuditID: cbfee68d-b7f4e6d000004845-f2-536c2ad116ba Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 9E.ED.25708.1DA2C635; Fri, 09 May 2014 10:09:37 +0900 (KST) Received: from DOJHBIRDCHO03 ([12.36.166.127]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0N5A00ACP8K12260@mmp1.samsung.com>; Fri, 09 May 2014 10:09:37 +0900 (KST) From: Jonghwan Choi To: 'Viresh Kumar' Cc: 'Nishanth Menon' , 'Linux PM list' , 'open list' , "'Rafael J. Wysocki'" , 'Len Brown' , 'Amit Daniel Kachhap' References: <000001cf643d$69e5e350$3db1a9f0$@samsung.com> <003901cf6664$e4e8d2a0$aeba77e0$@samsung.com> <5367946F.1030407@ti.com> <003e01cf6984$fb950280$f2bf0780$@samsung.com> <001501cf6a5c$07bc2520$17346f60$@samsung.com> <000301cf6a62$413c16b0$c3b44410$@samsung.com> In-reply-to: Subject: RE: [PATCH 1/3] PM / OPP: Add support for descending order for cpufreq table Date: Fri, 09 May 2014 10:09:37 +0900 Message-id: <000e01cf6b23$58fda900$0af8fb00$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8BIT X-Mailer: Microsoft Outlook 14.0 Thread-index: AQIqe0fjYa0YwQL6oKQ2dX7E8rarYwGe0UWzAg3L9n0CFbDXrQI73VqNAJ+GCpEBnU9akQFwpfDYAuYRDbQCG7oysAHyEw+TAdaKEeECfNgZegIzixHbAtOrQxmZoXkiMA== Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrOIsWRmVeSWpSXmKPExsVy+t8zQ92LWjnBBs8vm1s0XA2xmDVlL5PF 5V1z2Cw+9x5htHjz4yyTxZnTl1gtNn71cGD3WLznJZPHnWt72Dy2XG1n8ejbsorR4/iN7Uwe nzfJBbBFcdmkpOZklqUW6dslcGUcn9XCXtAtVHGw8QprA+MD7i5GTg4JAROJj4/XsUHYYhIX 7q0Hsrk4hASWMUpc/TGNGabo2eM7rBCJRYwSLXOeQDn/GCU6/55lAqliE9CVOLZ+CyuILSKg I9H/exkzSBGzwF9GieVNP1kgOqawS1ze8hDI4eDgFAiWaDngB9IgLBAusWbdTCaQMIuAqsSc 5lKQMK+ApcSTW3fYIGxBiR+T77GA2MwC6hKT5i1ihrC1JZ68u8AKcamCxI6zrxlBVokITGGU eNyygB2iSERi34t3YAkJga/sEm8W9YAlWAQEJL5NPgR2j4SArMSmA1AvS0ocXHGDZQKjxCwk u2ch2T0Lye5ZSFYsYGRZxSiaWpBcUJyUXmSoV5yYW1yal66XnJ+7iRESyb07GG8fsD7EmAy0 fiKzlGhyPjAR5JXEGxqbGVmYmpgaG5lbmpEmrCTOm/QwKUhIID2xJDU7NbUgtSi+qDQntfgQ IxMHp1QDo0deaIbO8xDpL5v/tCsufHp6okeKpqPW9DbWAm0BjfT157gWav4xrqpew9A093HE rYb4+v/fi5UuTLG1Xf56foXF97t94qInbu7+XCH2pV9g/X1R5WeTSxZcP2mWvtAoT4PZa+fS E2tPnJyS8CvhR/20HWzPjHgDzTYIhd+6rFP+2z7qyy3llUosxRmJhlrMRcWJAOxcEwD6AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrCKsWRmVeSWpSXmKPExsVy+t9jAd2LWjnBBp+nGVs0XA2xmDVlL5PF 5V1z2Cw+9x5htHjz4yyTxZnTl1gtNn71cGD3WLznJZPHnWt72Dy2XG1n8ejbsorR4/iN7Uwe nzfJBbBFNTDaZKQmpqQWKaTmJeenZOal2yp5B8c7x5uaGRjqGlpamCsp5CXmptoqufgE6Lpl 5gCdoqRQlphTChQKSCwuVtK3wzQhNMRN1wKmMULXNyQIrsfIAA0krGPMOD6rhb2gW6jiYOMV 1gbGB9xdjJwcEgImEs8e32GFsMUkLtxbz9bFyMUhJLCIUaJlzhNWCOcfo0Tn37NMIFVsAroS x9ZvAesQEdCR6P+9jBmkiFngL6PE8qafLBAdU9glLm95CORwcHAKBEu0HPADaRAWCJdYs24m E0iYRUBVYk5zKUiYV8BS4smtO2wQtqDEj8n3WEBsZgF1iUnzFjFD2NoST95dgLpUQWLH2deM IKtEBKYwSjxuWcAOUSQise/FO8YJjEKzkMyahWTWLCSzZiFpWcDIsopRNLUguaA4KT3XSK84 Mbe4NC9dLzk/dxMjOE08k97BuKrB4hCjAAejEg/viynZwUKsiWXFlbmHGCU4mJVEeF8sAwrx piRWVqUW5ccXleakFh9iTAb6dCKzlGhyPjCF5ZXEGxqbmBlZGplZGJmYm5MmrCTOe7DVOlBI ID2xJDU7NbUgtQhmCxMHp1QDY0gRt7TGA615lWcXrBd8ZupnOvfZQeOK+iYWFaVyoztxk7V3 ZitN+cceMuH4p5bWt7krD5S4vpvwKsvP7IZWqvXB1lOBTAse8r4v3MOtLCsrzt/SfNDw/lom lgXGDmIb13J3VAr7HlsgOVFu08q/2gtDSgpl3p//1e8xsSQufNpJJu3I51t9lViKMxINtZiL ihMBHArEsVcDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 8 May 2014 2:56 PM, Viresh Kumar wrote: > > Not necessarily. People may need a multiplier as well or some other > configuration and so this stuff was left for drivers to implement. -> In exynos cpufreq driver, if we want to support more frequency, then we have to describe frequency information in dts file and have to change exynos cpufreq driver file also(For adding divider value). But if dev_pm_opp has a divider value for DVFS,when we want to support more frequency we have only to change the dts file. I think that it is easy to maintain cpufreq driver and very convenient. (Can be applied to devfreq) This is a example (exynos4210 doesn't support DT.) Thanks Best Regards. --- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/drivers/base/power/opp.c +++ b/drivers/base/power/opp.c @@ -64,6 +64,7 @@ struct dev_pm_opp { bool available; unsigned long rate; unsigned long u_volt; + unsigned int ctl[2]; struct device_opp *dev_opp; struct rcu_head head; diff --git a/arch/arm/boot/dts/exynos4210.dtsi b/arch/arm/boot/dts/exynos4210.dtsi index cacf614..007a411 100644 --- a/arch/arm/boot/dts/exynos4210.dtsi +++ b/arch/arm/boot/dts/exynos4210.dtsi @@ -81,6 +81,24 @@ interrupts = <2 2>, <3 2>; }; + cpufreq@160000 { + compatible = "samsung,exynos7842-cpufreq"; + reg = <0x160000 0x1000>; + interrupts = <0 57 0>; + operating-points = < + /* KHz uV clkdiv0 clkdiv1 */ + 1500000 1100000 0x11111 0x11111 + 1400000 1075000 0x22223 0x22222 + 1300000 1050000 0x33333 0x33333 + 1200000 1025000 0x44444 0x44444 + 1100000 1000000 0x55555 0x55555 + 1000000 975000 0x66666 0x66666 + 900000 950000 0x77777 0x77777 + 800000 925000 0x88888 0x88888 + >; + }; + + pinctrl_0: pinctrl@11400000 { compatible = "samsung,exynos4210-pinctrl"; reg = <0x11400000 0x1000>;