| Message ID | 001201d92c93$98c8a040$ca59e0c0$@telus.net (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Shuah Khan |
| Headers | show |
| Series | selftests: amd-pstate: Don't delete source files via Makefile | expand |
On Fri, Jan 20, 2023 at 01:54:01PM +0800, Doug Smythies wrote: > Revert the portion of a recent Makefile change that incorrectly > deletes source files when doing "make clean". > > Fixes: ba2d788aa873 ("selftests: amd-pstate: Trigger tbench benchmark and test cpus") > Reported-by: Sedat Dilek <sedat.dilek@gmail.com> > Tested-by: Sedat Dilek <sedat.dilek@gmail.com> > Signed-off-by: Doug Smythies <dsmythies@telus.net> (+ Shuah and linux-kselftest mailing list) Thanks for fix! Acked-by: Huang Rui <ray.huang@amd.com> > --- > tools/testing/selftests/amd-pstate/Makefile | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/tools/testing/selftests/amd-pstate/Makefile b/tools/testing/selftests/amd-pstate/Makefile > index 5f195ee756d6..5fd1424db37d 100644 > --- a/tools/testing/selftests/amd-pstate/Makefile > +++ b/tools/testing/selftests/amd-pstate/Makefile > @@ -7,11 +7,6 @@ all: > uname_M := $(shell uname -m 2>/dev/null || echo not) > ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/x86/ -e s/x86_64/x86/) > > -ifeq (x86,$(ARCH)) > -TEST_GEN_FILES += ../../../power/x86/amd_pstate_tracer/amd_pstate_trace.py > -TEST_GEN_FILES += ../../../power/x86/intel_pstate_tracer/intel_pstate_tracer.py > -endif > - > TEST_PROGS := run.sh > TEST_FILES := basic.sh tbench.sh gitsource.sh > > -- > 2.25.1 > >
On Fri, Jan 20, 2023 at 6:54 AM Doug Smythies <dsmythies@telus.net> wrote: > > Revert the portion of a recent Makefile change that incorrectly > deletes source files when doing "make clean". > > Fixes: ba2d788aa873 ("selftests: amd-pstate: Trigger tbench benchmark and test cpus") > Reported-by: Sedat Dilek <sedat.dilek@gmail.com> > Tested-by: Sedat Dilek <sedat.dilek@gmail.com> > Signed-off-by: Doug Smythies <dsmythies@telus.net> Hi Doug, Thanks for the patch! Small nit, I saw this with: $ make -C tools/ clean Otherwise: Reviewed-by: Sedat Dilek <sedat.dilek@gmail.com> BR, -Sedat- > --- > tools/testing/selftests/amd-pstate/Makefile | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/tools/testing/selftests/amd-pstate/Makefile b/tools/testing/selftests/amd-pstate/Makefile > index 5f195ee756d6..5fd1424db37d 100644 > --- a/tools/testing/selftests/amd-pstate/Makefile > +++ b/tools/testing/selftests/amd-pstate/Makefile > @@ -7,11 +7,6 @@ all: > uname_M := $(shell uname -m 2>/dev/null || echo not) > ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/x86/ -e s/x86_64/x86/) > > -ifeq (x86,$(ARCH)) > -TEST_GEN_FILES += ../../../power/x86/amd_pstate_tracer/amd_pstate_trace.py > -TEST_GEN_FILES += ../../../power/x86/intel_pstate_tracer/intel_pstate_tracer.py > -endif > - > TEST_PROGS := run.sh > TEST_FILES := basic.sh tbench.sh gitsource.sh > > -- > 2.25.1 > >
On Fri, Jan 20, 2023 at 10:17 AM Huang Rui <ray.huang@amd.com> wrote: > > On Fri, Jan 20, 2023 at 01:54:01PM +0800, Doug Smythies wrote: > > Revert the portion of a recent Makefile change that incorrectly > > deletes source files when doing "make clean". > > > > Fixes: ba2d788aa873 ("selftests: amd-pstate: Trigger tbench benchmark and test cpus") > > Reported-by: Sedat Dilek <sedat.dilek@gmail.com> > > Tested-by: Sedat Dilek <sedat.dilek@gmail.com> > > Signed-off-by: Doug Smythies <dsmythies@telus.net> > > (+ Shuah and linux-kselftest mailing list) > > Thanks for fix! > > Acked-by: Huang Rui <ray.huang@amd.com> > [ I already replied - but with these important CCs ] Hi Doug, Thanks for the patch! Small nit, I saw this with: $ make -C tools/ clean Otherwise: Reviewed-by: Sedat Dilek <sedat.dilek@gmail.com> BR, -Sedat- > > --- > > tools/testing/selftests/amd-pstate/Makefile | 5 ----- > > 1 file changed, 5 deletions(-) > > > > diff --git a/tools/testing/selftests/amd-pstate/Makefile b/tools/testing/selftests/amd-pstate/Makefile > > index 5f195ee756d6..5fd1424db37d 100644 > > --- a/tools/testing/selftests/amd-pstate/Makefile > > +++ b/tools/testing/selftests/amd-pstate/Makefile > > @@ -7,11 +7,6 @@ all: > > uname_M := $(shell uname -m 2>/dev/null || echo not) > > ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/x86/ -e s/x86_64/x86/) > > > > -ifeq (x86,$(ARCH)) > > -TEST_GEN_FILES += ../../../power/x86/amd_pstate_tracer/amd_pstate_trace.py > > -TEST_GEN_FILES += ../../../power/x86/intel_pstate_tracer/intel_pstate_tracer.py > > -endif > > - > > TEST_PROGS := run.sh > > TEST_FILES := basic.sh tbench.sh gitsource.sh > > > > -- > > 2.25.1 > > > >
On 1/20/23 09:11, Sedat Dilek wrote: > On Fri, Jan 20, 2023 at 10:17 AM Huang Rui <ray.huang@amd.com> wrote: >> >> On Fri, Jan 20, 2023 at 01:54:01PM +0800, Doug Smythies wrote: >>> Revert the portion of a recent Makefile change that incorrectly >>> deletes source files when doing "make clean". Ooo. That is bad. >>> >>> Fixes: ba2d788aa873 ("selftests: amd-pstate: Trigger tbench benchmark and test cpus") >>> Reported-by: Sedat Dilek <sedat.dilek@gmail.com> >>> Tested-by: Sedat Dilek <sedat.dilek@gmail.com> >>> Signed-off-by: Doug Smythies <dsmythies@telus.net> >> >> (+ Shuah and linux-kselftest mailing list) >> >> Thanks for fix! >> >> Acked-by: Huang Rui <ray.huang@amd.com> >> > > [ I already replied - but with these important CCs ] > > Hi Doug, > > Thanks for the patch! > > Small nit, I saw this with: What did you see and should that be fixed as well. > > $ make -C tools/ clean > > Otherwise: > > Reviewed-by: Sedat Dilek <sedat.dilek@gmail.com> > Send me the revised patch with all the right CCs and I will pull this right away. thanks, -- Shuah
On Fri, Jan 20, 2023 at 5:15 PM Shuah Khan <skhan@linuxfoundation.org> wrote: > > On 1/20/23 09:11, Sedat Dilek wrote: > > On Fri, Jan 20, 2023 at 10:17 AM Huang Rui <ray.huang@amd.com> wrote: > >> > >> On Fri, Jan 20, 2023 at 01:54:01PM +0800, Doug Smythies wrote: > >>> Revert the portion of a recent Makefile change that incorrectly > >>> deletes source files when doing "make clean". > > Ooo. That is bad. > > >>> > >>> Fixes: ba2d788aa873 ("selftests: amd-pstate: Trigger tbench benchmark and test cpus") > >>> Reported-by: Sedat Dilek <sedat.dilek@gmail.com> > >>> Tested-by: Sedat Dilek <sedat.dilek@gmail.com> > >>> Signed-off-by: Doug Smythies <dsmythies@telus.net> > >> > >> (+ Shuah and linux-kselftest mailing list) > >> > >> Thanks for fix! > >> > >> Acked-by: Huang Rui <ray.huang@amd.com> > >> > > > > [ I already replied - but with these important CCs ] > > > > Hi Doug, > > > > Thanks for the patch! > > > > Small nit, I saw this with: > > What did you see and should that be fixed as well. > > > > > $ make -C tools/ clean > > > > Otherwise: > > > > Reviewed-by: Sedat Dilek <sedat.dilek@gmail.com> > > > > Send me the revised patch with all the right CCs and I will pull > this right away. > Hi Shuah, that was my original posting... Subject: [6.2-rc4] tools: {amd,intel}_pstate_tracer: make -C tools/ clean https://lore.kernel.org/all/CA+icZUUOckm1kwOEZhSw8zsaL5z7r8uczwiKeKGEVioZ=GeFNg@mail.gmail.com/ ...and should contain all CCs I got with scripts/get_maintainer.pl. Is that OK? BR, -Sedat-
On 1/20/23 09:20, Sedat Dilek wrote: > On Fri, Jan 20, 2023 at 5:15 PM Shuah Khan <skhan@linuxfoundation.org> wrote: >> >> On 1/20/23 09:11, Sedat Dilek wrote: >>> On Fri, Jan 20, 2023 at 10:17 AM Huang Rui <ray.huang@amd.com> wrote: >>>> >>>> On Fri, Jan 20, 2023 at 01:54:01PM +0800, Doug Smythies wrote: >>>>> Revert the portion of a recent Makefile change that incorrectly >>>>> deletes source files when doing "make clean". >> >> Ooo. That is bad. >> >>>>> >>>>> Fixes: ba2d788aa873 ("selftests: amd-pstate: Trigger tbench benchmark and test cpus") >>>>> Reported-by: Sedat Dilek <sedat.dilek@gmail.com> >>>>> Tested-by: Sedat Dilek <sedat.dilek@gmail.com> >>>>> Signed-off-by: Doug Smythies <dsmythies@telus.net> >>>> >>>> (+ Shuah and linux-kselftest mailing list) >>>> >>>> Thanks for fix! >>>> >>>> Acked-by: Huang Rui <ray.huang@amd.com> >>>> >>> >>> [ I already replied - but with these important CCs ] >>> >>> Hi Doug, >>> >>> Thanks for the patch! >>> >>> Small nit, I saw this with: >> >> What did you see and should that be fixed as well. >> >>> >>> $ make -C tools/ clean >>> >>> Otherwise: >>> >>> Reviewed-by: Sedat Dilek <sedat.dilek@gmail.com> >>> >> >> Send me the revised patch with all the right CCs and I will pull >> this right away. >> > > Hi Shuah, > > that was my original posting... > > Subject: [6.2-rc4] tools: {amd,intel}_pstate_tracer: make -C tools/ clean > https://lore.kernel.org/all/CA+icZUUOckm1kwOEZhSw8zsaL5z7r8uczwiKeKGEVioZ=GeFNg@mail.gmail.com/ > > ...and should contain all CCs I got with scripts/get_maintainer.pl. > > Is that OK? > Yes - the current list looks complete to me. thanks, -- Shuah
diff --git a/tools/testing/selftests/amd-pstate/Makefile b/tools/testing/selftests/amd-pstate/Makefile index 5f195ee756d6..5fd1424db37d 100644 --- a/tools/testing/selftests/amd-pstate/Makefile +++ b/tools/testing/selftests/amd-pstate/Makefile @@ -7,11 +7,6 @@ all: uname_M := $(shell uname -m 2>/dev/null || echo not) ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/x86/ -e s/x86_64/x86/) -ifeq (x86,$(ARCH)) -TEST_GEN_FILES += ../../../power/x86/amd_pstate_tracer/amd_pstate_trace.py -TEST_GEN_FILES += ../../../power/x86/intel_pstate_tracer/intel_pstate_tracer.py -endif - TEST_PROGS := run.sh TEST_FILES := basic.sh tbench.sh gitsource.sh
Revert the portion of a recent Makefile change that incorrectly deletes source files when doing "make clean". Fixes: ba2d788aa873 ("selftests: amd-pstate: Trigger tbench benchmark and test cpus") Reported-by: Sedat Dilek <sedat.dilek@gmail.com> Tested-by: Sedat Dilek <sedat.dilek@gmail.com> Signed-off-by: Doug Smythies <dsmythies@telus.net> --- tools/testing/selftests/amd-pstate/Makefile | 5 ----- 1 file changed, 5 deletions(-) -- 2.25.1