From patchwork Thu Sep 1 18:12:02 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Hilman X-Patchwork-Id: 1121042 Received: from smtp1.linux-foundation.org (smtp1.linux-foundation.org [140.211.169.13]) by demeter2.kernel.org (8.14.4/8.14.4) with ESMTP id p8214YuN009238 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL) for ; Fri, 2 Sep 2011 01:05:00 GMT Received: from daredevil.linux-foundation.org (localhost [127.0.0.1]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id p8212pc2014989; Thu, 1 Sep 2011 18:02:51 -0700 Received: from na3sys009aog104.obsmtp.com (na3sys009aog104.obsmtp.com [74.125.149.73]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with SMTP id p81IBS8S002818 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Thu, 1 Sep 2011 11:11:30 -0700 Received: from mail-gx0-f181.google.com ([209.85.161.181]) (using TLSv1) by na3sys009aob104.postini.com ([74.125.148.12]) with SMTP ID DSNKTl/K0L1rkgDGpF2z8+VgbyVr0r0DzZZ5@postini.com; Thu, 01 Sep 2011 11:11:30 PDT Received: by mail-gx0-f181.google.com with SMTP id 9so28271gxk.26 for ; Thu, 01 Sep 2011 11:11:28 -0700 (PDT) Received: by 10.68.29.193 with SMTP id m1mr462769pbh.92.1314900688379; Thu, 01 Sep 2011 11:11:28 -0700 (PDT) Received: from localhost (c-24-19-7-36.hsd1.wa.comcast.net. [24.19.7.36]) by mx.google.com with ESMTPS id p7sm4765688pbe.0.2011.09.01.11.11.27 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 01 Sep 2011 11:11:27 -0700 (PDT) From: Kevin Hilman To: "Rafael J. Wysocki" Date: Thu, 1 Sep 2011 11:12:02 -0700 Message-Id: <1314900722-10252-1-git-send-email-khilman@ti.com> X-Mailer: git-send-email 1.7.6 Received-SPF: pass (localhost is always allowed.) X-Spam-Status: No, hits=-105.483 required=5 tests=AWL, BAYES_00, OSDL_HEADER_SUBJECT_BRACKETED, PATCH_SUBJECT_OSDL, USER_IN_WHITELIST X-Spam-Checker-Version: SpamAssassin 3.2.4-osdl_revision__1.47__ X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.21 X-Scanned-By: MIMEDefang 2.63 on 140.211.169.51 Cc: linux-pm@lists.linux-foundation.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Arnd Bergmann Subject: [linux-pm] [PATCH] OMAP: omap_device: fix !CONFIG_SUSPEND case in _noirq handlers X-BeenThere: linux-pm@lists.linux-foundation.org X-Mailman-Version: 2.1.9 Precedence: list List-Id: Linux power management List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-pm-bounces@lists.linux-foundation.org Errors-To: linux-pm-bounces@lists.linux-foundation.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Fri, 02 Sep 2011 01:05:00 +0000 (UTC) The suspend/resume _noirq handlers were #ifdef'd out in the !CONFIG_SUSPEND case, but were still assigned to the dev_pm_ops struct. Fix by defining them to NULL in the !CONFIG_SUSPEND case. Reported-by: Arnd Bergmann Signed-off-by: Kevin Hilman Acked-by: Arnd Bergmann --- Applies to v3.1-rc4. arch/arm/plat-omap/omap_device.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/arch/arm/plat-omap/omap_device.c b/arch/arm/plat-omap/omap_device.c index 9a6a538..02609ee 100644 --- a/arch/arm/plat-omap/omap_device.c +++ b/arch/arm/plat-omap/omap_device.c @@ -615,6 +615,9 @@ static int _od_resume_noirq(struct device *dev) return pm_generic_resume_noirq(dev); } +#else +#define _od_suspend_noirq NULL +#define _od_resume_noirq NULL #endif static struct dev_pm_domain omap_device_pm_domain = {